Closed jokergoo closed 9 months ago
Hi @jokergoo
Thanks for submitting your package. We are taking a quick look at it and you will hear back from us soon.
The DESCRIPTION file for this package is:
Package: simona
Type: Package
Title: Semantic Similarity in Bio-Ontologies
Version: 0.99.0
Date: 2023-08-02
Authors@R: person("Zuguang", "Gu", email = "z.gu@dkfz.de", role = c("aut", "cre"),
comment = c('ORCID'="0000-0002-7395-8709"))
Depends: R (>= 4.2.0)
Imports: methods, Rcpp, matrixStats, GetoptLong, grid, GlobalOptions,
igraph, Polychrome, S4Vectors, xml2, circlize, TSP, ComplexHeatmap,
grDevices, stats, utils
Suggests: knitr, testthat, BiocManager, GO.db, org.Hs.eg.db, proxyC, AnnotationDbi,
Matrix, DiagrammeR
LinkingTo: Rcpp
VignetteBuilder: knitr
Description: The package implements a rich set of methods for semantic similarity
analysis on bio-ontologies. They include methods for information contents, similarities between
two terms as well as similarities between two groups of terms. It also implements
visualizations on DAGs.
biocViews: Software, Annotation, GO, BiomedicalInformatics
URL: https://github.com/jokergoo/simona
SystemRequirements: Perl, Java
License: MIT + file LICENSE
RoxygenNote: 7.2.3
Encoding: UTF-8
Roxygen: list(markdown = TRUE)
u have .o files in src plz remove and bump version
Your package has been added to git.bioconductor.org to continue the pre-review process. A build report will be posted shortly. Please fix any ERROR and WARNING in the build report before a reviewer is assigned or provide a justification on why you feel the ERROR or WARNING should be granted an exception.
IMPORTANT: Please read this documentation for setting up remotes to push to git.bioconductor.org. All changes should be pushed to git.bioconductor.org moving forward. It is required to push a version bump to git.bioconductor.org to trigger a new build report.
Bioconductor utilized your github ssh-keys for git.bioconductor.org access. To manage keys and future access you may want to active your Bioconductor Git Credentials Account
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Build System.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
The following are build products from R CMD build on the Bioconductor Build System: macOS 12.6.5 Monterey: simona_0.99.0.tar.gz Linux (Ubuntu 22.04.2 LTS): simona_0.99.0.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/simona
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
A reviewer has been assigned to your package for an indepth review. Please respond accordingly to any further comments from the reviewer.
Your package has been added to git.bioconductor.org to continue the pre-review process. A build report will be posted shortly. Please fix any ERROR and WARNING in the build report before a reviewer is assigned or provide a justification on why you feel the ERROR or WARNING should be granted an exception.
IMPORTANT: Please read this documentation for setting up remotes to push to git.bioconductor.org. All changes should be pushed to git.bioconductor.org moving forward. It is required to push a version bump to git.bioconductor.org to trigger a new build report.
Bioconductor utilized your github ssh-keys for git.bioconductor.org access. To manage keys and future access you may want to active your Bioconductor Git Credentials Account
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Build System.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
The following are build products from R CMD build on the Bioconductor Build System: macOS 12.6.5 Monterey: simona_0.99.0.tar.gz Linux (Ubuntu 22.04.2 LTS): simona_0.99.0.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/simona
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Your package has been added to git.bioconductor.org to continue the pre-review process. A build report will be posted shortly. Please fix any ERROR and WARNING in the build report before a reviewer is assigned or provide a justification on why you feel the ERROR or WARNING should be granted an exception.
IMPORTANT: Please read this documentation for setting up remotes to push to git.bioconductor.org. All changes should be pushed to git.bioconductor.org moving forward. It is required to push a version bump to git.bioconductor.org to trigger a new build report.
Bioconductor utilized your github ssh-keys for git.bioconductor.org access. To manage keys and future access you may want to active your Bioconductor Git Credentials Account
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Build System.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
The following are build products from R CMD build on the Bioconductor Build System: Linux (Ubuntu 22.04.2 LTS): simona_0.99.0.tar.gz macOS 12.6.5 Monterey: simona_0.99.0.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/simona
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 5df59de4c9881b3a1f787b85af76ca52b17a2084
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Build System.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
The following are build products from R CMD build on the Bioconductor Build System: macOS 12.6.5 Monterey: simona_0.99.1.tar.gz Linux (Ubuntu 22.04.2 LTS): simona_0.99.1.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/simona
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: eaed99c7ccd2a1a8a673a76e68276cc62db35cb1
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Build System.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
The following are build products from R CMD build on the Bioconductor Build System: macOS 12.6.5 Monterey: simona_0.99.2.tar.gz Linux (Ubuntu 22.04.2 LTS): simona_0.99.2.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/simona
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: eb6fef2d1bea4367b2f814ba6df1b683b936fad2
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Build System.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details.
The following are build products from R CMD build on the Bioconductor Build System: Linux (Ubuntu 22.04.2 LTS): simona_0.99.3.tar.gz macOS 12.6.5 Monterey: simona_0.99.3.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/simona
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Thank you for submitting your package to Bioconductor. The package passed check and build. It is in pretty good shape. However there are several things need to be fixed. Please try to answer the comments line by line when you are ready for a second review. Code: Note: please consider; Important: must be addressed.
importFrom
instead of import all with import
.
[ ] NOTE: no direct slot access with @
or slot()
- accessors implemented and used.
[ ] Important: no <<-
. Try to set a global environment for the package.
[ ] Important: vapply
instead of sapply
.
[ ] Important: system2
instead of system
.
[ ] Important: No paste
in message()
, message
, stop
. Move it outside.
[ ] NOTE: ::
is not suggested in source code unless you can make sure all the packages are imported. Some people think it is better to keep ::
. However please note that you need to manully double check the import items when you make any change in the DESCRIPTION file during development. My recommendation is to remove one or two repeats to force the dependency check.
[ ] Important: 1:n
is not suggested in source code. Use seq_along
or seq.int
instead.
[ ] NOTE: Vectorize: for
loops present, try to replace them by *apply
funcitons.
[ ] Important: Remove unused code.
[ ] NOTE: Avoid 'suppressWarnings'/'*Messages' if possible
[ ] NOTE: Avoid using '=' for assignment and use '<-' instead. Please user styler
package to reformat your package.
[ ] Important: Please consider to add drop=FALSE
to avoid the reduction of dimension for matrices and arrays. Ignore this if using datatable.
[ ] To avoid the * NOTE: Avoid redundant 'stop' and 'warn*' in signal conditions
in BioCheck,
could you please change the word error
to other word in
[ ] NOTE: Functional programming: code repetition.
.dag_singular_dist
, dag_depth
, dag_height
, dag_shortest_dist_from_root
, dag_shortest_dist_to_leaves
, n_ancestors
, n_annotations
, n_children
, n_connected_leaves
, n_offspring
, and n_parents
.sim_overlap
and .sim_overlap_from_two_groups
annotation
should be set in create_ontology_DAG()
.")annotation
should be set in create_ontology_DAG()
.").sim_overlap
and validate_dag_has_annotation
, .sim_overlap_from_two_groups
annotation
should be set in create_ontology_DAG()
.")annotation
should be set in create_ontology_DAG()
.")annotation
should be set in create_ontology_DAG()
.")all_group_sim_methods
and all_ic_methods
, all_term_sim_methods
annotated_terms
and term_annotations
dag_ancestors
and dag_offspring
dag_as_DOT
and dag_as_igraph
dag_as_DOT
and dag_circular_viz
color
should be one or @{n_terms} (number of terms in the DAG)."))style
should be one or @{n_terms} (number of terms in the DAG)."))fontcolor
should be one or @{n_terms} (number of terms in the DAG)."))fontsize
should be one or @{n_terms} (number of terms in the DAG)."))shape
should be one or @{n_terms} (number of terms in the DAG)."))edge_color
should cover all relation types.")edge_type
should cover all relation types.")node_col
should be one or @{n_terms} (number of terms in the DAG)."))node_transparency
should be one or @{n_terms} (number of terms in the DAG)."))node_size
should be one or @{n_terms} (number of terms in the DAG)."))edge_col
should cover all relation types.")edge_transparency
should cover all relation types.")dag_as_DOT
and dag_filter
, dag_as_igraph
, dag_circular_viz
get_group_sim_method
and get_IC_method
get_term_sim_method
all_group_sim_methods()
.")all_ic_methods()
.")all_term_sim_methods()
.")GroupSim_Dice
and GroupSim_Jaccard
GroupSim_Kappa
GroupSim_Overlap
GroupSim_SimALN
, Sim_AlMubaid_2006
, Sim_Leocock_1998
, Sim_Li_2003
Sim_Rada_1989
, Sim_Resnik_edge_2005
, Sim_RSS_2013
, and Sim_Shenoy_2012
distance
can only be in 'shortest_distances_via_CA' or 'longest_distances_via_LCA'.")distance
can only be in 'shortest_distances_via_CA' or 'longest_distances_via_LCA'.")distance
can only be in 'shortest_distances_via_NCA' or 'longest_distances_via_LCA'.")distance
can only be in 'shortest_distances_via_CA' or 'longest_distances_via_LCA'.")distance
can only be in 'shortest_distances_via_NCA' or 'longest_distances_via_LCA'.")distance
can only be in 'shortest_distances_via_NCA' or 'longest_distances_via_LCA'.")distance
can only be in 'shortest_distances_via_CA' or 'longest_distances_via_LCA'.")distance
can only be in 'shortest_distances_via_NCA' or 'longest_distances_via_LCA'.")IC_annotation
and n_annotations
IC_universal
and totipotency
IC_Wang_2007
and Sim_Wang_2007
relations
is not set when creating the ontology_DAG object.")contribution_factor
should be a named numeric vector where names should correspond to all relations.")relations
is not set when creating the ontology_DAG object.")contribution_factor
should be a named numeric vector where names should correspond to all relations.")import_obo
and import_owl
import_obo
, import_ttl
, import_owl
max_ancestor_id
max_ancestor_v
, NCA_term
value
should be the same as number of total terms in the DAG.")value
should be the same as number of total terms in the DAG.")message_wrap
, stop_wrap
, and warning_wrap
n_ancestors
and n_offspring
shortest_distances_directed
and shortest_distances_via_NCA
[ ] Important: Vignette should use BiocStyle
package for formatting.
[ ] Important: Vignette should have an Introduction section. Add sub title Introduction
.
[ ] Important: Vignette should have an Installation section.
[ ] Important: Please include Bioconductor installation instructions using BiocManager.
[ ] Note: Vignette includes motivation for submitting to Bioconductor
as part of the abstract/intro of the main vignette.
[ ] Note: Please consider to add prefix for the variable in #ifndef ... #define
Thanks for your time on reviewing my package. I have fixed most of the issues marked as "important".
[ ] Important: Selective imports using importFrom
instead of import all with import
.
in line 73 import(ComplexHeatmap)
in line 74 import(GlobalOptions)
I have to import the whole namespace of these two packages.
[ ] Important: no <<-
. Try to set a global environment for the package.
I have to use the global assignment for these cases. But I can make sure the global assignment is only restricted in specific functions.
[x] Important: vapply
instead of sapply
.
[x] Important: system2
instead of system
.
[x] Important: No paste
in message()
, message
, stop
. Move it outside.
[x] Important: 1:n
is not suggested in source code. Use seq_along
or seq.int
instead.
[x] Important: Remove unused code.
[x] Important: Please consider to add drop=FALSE
to avoid the reduction of dimension for matrices and arrays. Ignore this if using datatable.
BiocStyle
package for formatting.Introduction
.I want to ask these requirement mandatory for bioc packages? I would guess they are "suggested"? I would like to keep the vignettes in their original formats.
I added Introduction, Installation to the readme file of the package.
Received a valid push on git.bioconductor.org; starting a build for commit id: afa9de75767a36500bb4b8c0ff33f900ecb1bb87
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Build System.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details.
The following are build products from R CMD build on the Bioconductor Build System: Linux (Ubuntu 22.04.2 LTS): simona_0.99.4.tar.gz macOS 12.6.5 Monterey: simona_0.99.4.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/simona
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
@jokergoo Thank you for your quick updates. LGTM. Please updates the NEWS file. And I will make the package as accepted.
Received a valid push on git.bioconductor.org; starting a build for commit id: f62574539bb9b40cb9ec1c678ceb23d5380047b4
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Build System.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details.
The following are build products from R CMD build on the Bioconductor Build System: Linux (Ubuntu 22.04.2 LTS): simona_0.99.6.tar.gz macOS 12.6.5 Monterey: simona_0.99.6.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/simona
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
@jianhong Thank you very much! The NEWS file has been updated.
Your package has been accepted. It will be added to the Bioconductor nightly builds.
Thank you for contributing to Bioconductor!
Reviewers for Bioconductor packages are volunteers from the Bioconductor community. If you are interested in becoming a Bioconductor package reviewer, please see Reviewers Expectations.
The default branch of your GitHub repository has been added to Bioconductor's git repository as branch devel.
To use the git.bioconductor.org repository, we need an 'ssh' key to associate with your github user name. If your GitHub account already has ssh public keys (https://github.com/jokergoo.keys is not empty), then no further steps are required. Otherwise, do the following:
See further instructions at
https://bioconductor.org/developers/how-to/git/
for working with this repository. See especially
https://bioconductor.org/developers/how-to/git/new-package-workflow/ https://bioconductor.org/developers/how-to/git/sync-existing-repositories/
to keep your GitHub and Bioconductor repositories in sync.
Your package will be included in the next nigthly 'devel' build (check-out from git at about 6 pm Eastern; build completion around 2pm Eastern the next day) at
https://bioconductor.org/checkResults/
(Builds sometimes fail, so ensure that the date stamps on the main landing page are consistent with the addition of your package). Once the package builds successfully, you package will be available for download in the 'Devel' version of Bioconductor using BiocManager::install("simona")
. The package 'landing page' will be created at
https://bioconductor.org/packages/simona
If you have any questions, please contact the bioc-devel mailing list (https://stat.ethz.ch/mailman/listinfo/bioc-devel); this issue will not be monitored further.
Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor
Confirm the following by editing each check box to '[x]'
[x] I understand that by submitting my package to Bioconductor, the package source and all review commentary are visible to the general public.
[x] I have read the Bioconductor Package Submission instructions. My package is consistent with the Bioconductor Package Guidelines.
[x] I understand Bioconductor Package Naming Policy and acknowledge Bioconductor may retain use of package name.
[x] I understand that a minimum requirement for package acceptance is to pass R CMD check and R CMD BiocCheck with no ERROR or WARNINGS. Passing these checks does not result in automatic acceptance. The package will then undergo a formal review and recommendations for acceptance regarding other Bioconductor standards will be addressed.
[x] My package addresses statistical or bioinformatic issues related to the analysis and comprehension of high throughput genomic data.
[x] I am committed to the long-term maintenance of my package. This includes monitoring the support site for issues that users may have, subscribing to the bioc-devel mailing list to stay aware of developments in the Bioconductor community, responding promptly to requests for updates from the Core team in response to changes in R or underlying software.
[x] I am familiar with the Bioconductor code of conduct and agree to abide by it.
I am familiar with the essential aspects of Bioconductor software management, including:
For questions/help about the submission process, including questions about the output of the automatic reports generated by the SPB (Single Package Builder), please use the #package-submission channel of our Community Slack. Follow the link on the home page of the Bioconductor website to sign up.