Closed adeschen closed 8 months ago
Hi @adeschen
Thanks for submitting your package. We are taking a quick look at it and you will hear back from us soon.
The DESCRIPTION file for this package is:
Package: enrichViewNet
Type: Package
Version: 0.99.0
Date: 2021-03-25
Title: From functional enrichment results to biological networks
Description: This package enables the visualization of functional
enrichment results as network graphs. First the package enables the
visualization of enrichment results, in a format corresponding to the one
generated by gprofiler2, as a customizable Cytoscape network. In those
networks, both gene datasets (GO terms/pathways/protein complexes) and
genes associated to the datasets are represented as nodes. While the
edges connect each gene to its dataset(s). The package also provides the
option to create enrichment maps from functional enrichment results.
Enrichment maps enable the visualization of enriched terms into a network
with edges connecting overlapping genes.
Authors@R: c(person("Astrid", "Deschênes", email = "adeschen@hotmail.com",
role=c("aut", "cre"), comment=c(ORCID = "0000-0001-7846-6749")),
person("Pascal", "Belleau", email = "pascal_belleau@hotmail.com",
role=c("aut"), comment = c(ORCID = "0000-0002-0802-1071")),
person("Robert L.", "Faure", email="robert.faure@crchudequebec.ulaval.ca",
role=c("aut"), comment=c(ORCID="0000-0003-1798-4723")),
person("Maria J.", "Fernandes",
email="maria.fernandes@crchudequebec.ulaval.ca", role = c("aut"),
comment=c(ORCID="0000-0002-3973-025X")),
person(given="Alexander", family="Krasnitz", email="krasnitz@cshl.edu",
role=c("aut")),
person(given="David A.", family="Tuveson",
email="dtuveson@cshl.edu",
role=c("aut"), comment=c(ORCID="0000-0002-8017-2712")))
Encoding: UTF-8
License: Artistic-2.0
Depends: R (>= 4.3.0)
Imports: gprofiler2,
strex,
RCy3,
jsonlite,
stringr,
enrichplot,
methods
Suggests:
BiocStyle,
knitr,
rmarkdown,
testthat
biocViews: BiologicalQuestion,
Software,
Network,
NetworkEnrichment,
GO
VignetteBuilder: knitr
URL: https://github.com/adeschen/enrichViewNet, https://adeschen.github.io/enrichViewNet/
BugReports: https://github.com/adeschen/enrichViewNet/issues
RoxygenNote: 7.2.3
Your package has been added to git.bioconductor.org to continue the pre-review process. A build report will be posted shortly. Please fix any ERROR and WARNING in the build report before a reviewer is assigned or provide a justification on why you feel the ERROR or WARNING should be granted an exception.
IMPORTANT: Please read this documentation for setting up remotes to push to git.bioconductor.org. All changes should be pushed to git.bioconductor.org moving forward. It is required to push a version bump to git.bioconductor.org to trigger a new build report.
Bioconductor utilized your github ssh-keys for git.bioconductor.org access. To manage keys and future access you may want to active your Bioconductor Git Credentials Account
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Build System.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details.
The following are build products from R CMD build on the Bioconductor Build System: macOS 12.6.5 Monterey: enrichViewNet_0.99.0.tar.gz Linux (Ubuntu 22.04.2 LTS): enrichViewNet_0.99.0.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/enrichViewNet
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
A reviewer has been assigned to your package for an indepth review. Please respond accordingly to any further comments from the reviewer.
Thank you for submitting your package to Bioconductor. The package passed check and build. It is in pretty good shape. If you can enhance the power of functions using RCy3 to explore the data will be even better, but that is out of this review process. Please try to answer the comments line by line when you are ready for a second review. Code: Note: please consider; Important: must be addressed.
is()
or inherits()
instead of class()
.
::
is not suggested in source code unless you can make sure all the packages are imported. Some people think it is better to keep ::
. However please note that you need to manully double check the import items when you make any change in the DESCRIPTION file during development. My recommendation is to remove one or two repeats to force the dependency check.
for
loops present, try to replace them by *apply
funcitons.
is.character/numeric/integer/logical
to replace is(, "character/numeric/integer/logical")
drop=FALSE
to avoid the reduction of dimension for matrices and arrays. Ignore this if using datatable.createEnrichMap
and createNetwork
extractNodesAndEdgesWhenIntersection
and extractNodesAndEdgesWhenNoIntersection
validateCreateEnrichMapArguments
and validateCreateNetworkArguments
motivation for submitting to Bioconductor
as part of the abstract/intro of the main vignette.
Received a valid push on git.bioconductor.org; starting a build for commit id: 84eab271c9ac1fe4866cbaa65a8b08f0ce99b4a2
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Build System.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details.
The following are build products from R CMD build on the Bioconductor Build System: macOS 12.6.5 Monterey: enrichViewNet_0.99.1.tar.gz Linux (Ubuntu 22.04.2 LTS): enrichViewNet_0.99.1.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/enrichViewNet
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Dear @jianhong ,
We thank you for the thoughtful comments and, in response, have revised the code as follows.
All class() have been replaced by inherits() in the code.
We are now importing the methods and we have removed the :: from the code.
All for() loop have been replaced by *apply functions.
The unused code has been removed.
All is(, "character/numeric/integer/logical") functions have been replaced.
At the moment, we do not use matrices in the code.
The extractNodesAndEdgesWhenIntersection and extractNodesAndEdgesWhenNoIntersection functions are similar but request different data manipulation. We have not found a easy way to remove the repetition from those functions.
We will address the repetition in validateCreateEnrichMapArguments and validateCreateNetworkArguments functions as soon as possible. As well as in the createEnrichMap and createNetwork functions.
[X] Important: Please include Bioconductor installation instructions using BiocManager.
rmd file vignettes/enrichViewNet.Rmd
We have included Bioconductor installation instructions using BiocManager in the vignette.
[X] Note: Vignette includes motivation for submitting to Bioconductor as part of the abstract/intro of the main vignette.
rmd file vignettes/enrichViewNet.Rmd
We have included the motivation at the end of the Introduction of the main vignette.
All examples in the vignette are now runable.
in man page examples. 11% of man pages use at least one of these tags. If not avoidable, use donttest{} instead of dontrun{}.
All dontrun{} / donttest{} have been removed for the man pages.
Best Regards, Astrid and Pascal
Rd file 'extractNodesAndEdgesWhenIntersection.Rd': \examples lines wider than 100 characters: results <- parentalNapaVsDMSOEnrichment$result[parentalNapaVsDMSOEnrichment$result$source == "GO:MF", ]
Please fix this as soon as possible. Today is the last day for current release.
Received a valid push on git.bioconductor.org; starting a build for commit id: a68466d1fab1b90219822268c3d550f66d1f1093
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Build System.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details.
The following are build products from R CMD build on the Bioconductor Build System: Linux (Ubuntu 22.04.2 LTS): enrichViewNet_0.99.2.tar.gz macOS 12.6.5 Monterey: enrichViewNet_0.99.2.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/enrichViewNet
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Your package has been accepted. It will be added to the Bioconductor nightly builds.
Thank you for contributing to Bioconductor!
Reviewers for Bioconductor packages are volunteers from the Bioconductor community. If you are interested in becoming a Bioconductor package reviewer, please see Reviewers Expectations.
The default branch of your GitHub repository has been added to Bioconductor's git repository as branch devel.
To use the git.bioconductor.org repository, we need an 'ssh' key to associate with your github user name. If your GitHub account already has ssh public keys (https://github.com/adeschen.keys is not empty), then no further steps are required. Otherwise, do the following:
See further instructions at
https://bioconductor.org/developers/how-to/git/
for working with this repository. See especially
https://bioconductor.org/developers/how-to/git/new-package-workflow/ https://bioconductor.org/developers/how-to/git/sync-existing-repositories/
to keep your GitHub and Bioconductor repositories in sync.
Your package will be included in the next nigthly 'devel' build (check-out from git at about 6 pm Eastern; build completion around 2pm Eastern the next day) at
https://bioconductor.org/checkResults/
(Builds sometimes fail, so ensure that the date stamps on the main landing page are consistent with the addition of your package). Once the package builds successfully, you package will be available for download in the 'Devel' version of Bioconductor using BiocManager::install("enrichViewNet")
. The package 'landing page' will be created at
https://bioconductor.org/packages/enrichViewNet
If you have any questions, please contact the bioc-devel mailing list (https://stat.ethz.ch/mailman/listinfo/bioc-devel); this issue will not be monitored further.
Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor
Confirm the following by editing each check box to '[x]'
[x] I understand that by submitting my package to Bioconductor, the package source and all review commentary are visible to the general public.
[x] I have read the Bioconductor Package Submission instructions. My package is consistent with the Bioconductor Package Guidelines.
[x] I understand Bioconductor Package Naming Policy and acknowledge Bioconductor may retain use of package name.
[x] I understand that a minimum requirement for package acceptance is to pass R CMD check and R CMD BiocCheck with no ERROR or WARNINGS. Passing these checks does not result in automatic acceptance. The package will then undergo a formal review and recommendations for acceptance regarding other Bioconductor standards will be addressed.
[x] My package addresses statistical or bioinformatic issues related to the analysis and comprehension of high throughput genomic data.
[x] I am committed to the long-term maintenance of my package. This includes monitoring the support site for issues that users may have, subscribing to the bioc-devel mailing list to stay aware of developments in the Bioconductor community, responding promptly to requests for updates from the Core team in response to changes in R or underlying software.
[x] I am familiar with the Bioconductor code of conduct and agree to abide by it.
I am familiar with the essential aspects of Bioconductor software management, including:
For questions/help about the submission process, including questions about the output of the automatic reports generated by the SPB (Single Package Builder), please use the #package-submission channel of our Community Slack. Follow the link on the home page of the Bioconductor website to sign up.