Bioconductor / Contributions

Contribute Packages to Bioconductor
135 stars 33 forks source link

(inactive) CAM3 #3205

Closed niccolodpdu closed 11 months ago

niccolodpdu commented 1 year ago

Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor

Confirm the following by editing each check box to '[x]'

I am familiar with the essential aspects of Bioconductor software management, including:

For questions/help about the submission process, including questions about the output of the automatic reports generated by the SPB (Single Package Builder), please use the #package-submission channel of our Community Slack. Follow the link on the home page of the Bioconductor website to sign up.

bioc-issue-bot commented 1 year ago

Hi @niccolodpdu

Thanks for submitting your package. We are taking a quick look at it and you will hear back from us soon.

The DESCRIPTION file for this package is:

Package: CAM3
Type: Package
Title: Convex Analysis of Mixtures Version 3
Version: 0.99.0
Authors@R: person("Chiung-Ting", "Wu", email = "ctwu@vt.edu",role = c("aut", "cre"))
biocViews: Software, CellBiology, GeneExpression
Description: An R package for fully unsupervised deconvolution of complex 
    tissues. It provides basic functions to perform 
    unsupervised deconvolution on mixture expression profiles by 
    Convex Analysis of Mixtures (CAM) and some 
    auxiliary functions to help understand the subpopulation-specific results. 
    It also implements functions to perform supervised deconvolution based on 
    prior knowledge of molecular markers, S matrix or A matrix. Combining 
    molecular markers from CAM and from prior knowledge can achieve 
    semi-supervised deconvolution of mixtures.
License: GPL-2
Encoding: UTF-8
Roxygen: list(markdown = TRUE)
RoxygenNote: 7.1.1
Depends: R (>= 3.6) 
Suggests: 
    knitr,
    rmarkdown,
    BiocStyle,
    testthat,
    GEOquery,
    rgl
VignetteBuilder: knitr
Imports:
    methods,
    debCAM,
    stats,
    Biobase,
    SummarizedExperiment,
    corpcor,
    geometry,
    NMF,
    nnls,
    graphics,
    geometry
lshep commented 1 year ago

You should remove the build directory and inst/doc directory. Please make sure your data sets are documented.

bioc-issue-bot commented 1 year ago

Your package has been added to git.bioconductor.org to continue the pre-review process. A build report will be posted shortly. Please fix any ERROR and WARNING in the build report before a reviewer is assigned or provide a justification on why you feel the ERROR or WARNING should be granted an exception.

IMPORTANT: Please read this documentation for setting up remotes to push to git.bioconductor.org. All changes should be pushed to git.bioconductor.org moving forward. It is required to push a version bump to git.bioconductor.org to trigger a new build report.

Bioconductor utilized your github ssh-keys for git.bioconductor.org access. To manage keys and future access you may want to active your Bioconductor Git Credentials Account

niccolodpdu commented 1 year ago

Thanks for the reply. Should I also remove everything in the build and inst/doc directory or move them elsewhere? Any suggestions on how to document the data sets in this case?

bioc-issue-bot commented 1 year ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Build System.

On one or more platforms, the build results were: "ERROR, WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Bioconductor Build System: macOS 12.6.5 Monterey: CAM3_0.99.0.tar.gz Linux (Ubuntu 22.04.2 LTS): CAM3_0.99.0.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/CAM3 to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

lshep commented 1 year ago

Please fix ERROR/warnings in the build report or justify any that remain before a reviewer is assigned for in depth review.

lshep commented 11 months ago

do you plan on making updates to fix ERROR and warnings soon?

niccolodpdu commented 11 months ago

Hi I saw no error or warnings from my side by running 'BiocCheck::BiocCheck('new-package'=TRUE)'. [image: image.png]

On Fri, Dec 8, 2023 at 12:11 PM lshep @.***> wrote:

do you plan on making updates to fix ERROR and warnings soon?

— Reply to this email directly, view it on GitHub https://github.com/Bioconductor/Contributions/issues/3205#issuecomment-1847542233, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVMAS7GQZTFO7ENCUAO3GCTYINC2RAVCNFSM6AAAAAA5TK27GSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBXGU2DEMRTGM . You are receiving this because you were mentioned.Message ID: @.***>

lshep commented 11 months ago

The build report produced on our system had ERROR and Warnings that need to be fixed before we assign a reviewer. You need to respect the reports on our system. As its been over 3 weeks the report above it not available any more but here is a link to the report. Please push changes to git.bioconductor.org with a valid version bump to trigger a new report.

lshep commented 11 months ago

We will close this issue for inactivity. If you plan on revising the package to fix the ERROR, Warning and Notes let us know and we can reopen the issue.

bioc-issue-bot commented 11 months ago

This issue is being closed because there has been no progress for an extended period of time. You may reopen the issue when you have the time to actively participate in the review / submission process. Please also keep in mind that a package accepted to Bioconductor requires a commitment on your part to ongoing maintenance.

Thank you for your interest in Bioconductor.