Bioconductor / Contributions

Contribute Packages to Bioconductor
131 stars 33 forks source link

txdbmaker #3226

Closed hpages closed 3 months ago

hpages commented 8 months ago

Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor

Confirm the following by editing each check box to '[x]'

I am familiar with the essential aspects of Bioconductor software management, including:

For questions/help about the submission process, including questions about the output of the automatic reports generated by the SPB (Single Package Builder), please use the #package-submission channel of our Community Slack. Follow the link on the home page of the Bioconductor website to sign up.

bioc-issue-bot commented 8 months ago

Hi @hpages

Thanks for submitting your package. We are taking a quick look at it and you will hear back from us soon.

The DESCRIPTION file for this package is:

Package: txdbmaker
Title: Tools for making TxDb objects from genomic annotations
Description: A set of tools for making TxDb objects from genomic annotations
    from various sources (e.g. UCSC, Ensembl, and GFF files). These tools
    allow the user to download the genomic locations of transcripts,
    exons, and CDS, for a given assembly, and to import them in a TxDb
    object. TxDb objects are implemented in the GenomicFeatures package,
    together with flexible methods for extracting the desired features in
    convenient formats.
biocViews: Infrastructure, DataImport, Annotation, GenomeAnnotation,
    GenomeAssembly, Genetics, Sequencing
URL: https://bioconductor.org/packages/txdbmaker
BugReports: https://github.com/Bioconductor/txdbmaker/issues
Version: 0.99.0
License: Artistic-2.0
Encoding: UTF-8
Authors@R: c(
    person("H.", "Pagès", role=c("aut", "cre"),
        email="hpages.on.github@gmail.com"),
    person("M.", "Carlson", role="aut"),
    person("P.", "Aboyoun", role="aut"),
    person("S.", "Falcon", role="aut"),
    person("M.", "Morgan", role="aut"),
    person("M.", "Lawrence", role="aut"),
    person("J.", "MacDonald", role="ctb"),
    person("M.", "Ramos", role="ctb"),
    person("S.", "Saini", role="ctb"),
    person("L.", "Shepherd", role="ctb"))
Depends: R (>= 4.4.0), BiocGenerics, S4Vectors, IRanges, GenomeInfoDb,
    AnnotationDbi, GenomicRanges, GenomicFeatures
Imports: methods, utils, stats, tools, DBI, RSQLite (>= 2.0),
    Biobase, BiocIO, rtracklayer, biomaRt
Suggests: RMariaDB, mirbase.db, ensembldb, RUnit, BiocStyle, knitr, markdown
VignetteBuilder: knitr
Collate: utils.R
    UCSC-utils.R
    Ensembl-utils.R
    findCompatibleMarts.R
    TxDb-schema.R
    TxDb-CREATE-TABLE-helpers.R
    makeTxDb.R
    makeTxDbFromUCSC.R
    makeTxDbFromBiomart.R
    makeTxDbFromEnsembl.R
    makeTxDbFromGRanges.R
    makeTxDbFromGFF.R
    makeFeatureDbFromUCSC.R
    makeTxDbPackage.R
    zzz.R
hpages commented 8 months ago

This is a spin-off from GenomicFeatures that contains the tools for making TxDb objects. The plan is to deprecate these tools in GenomicFeatures (in BioC 3.19), and redirect to the tools in txdbmaker. Then to defunct them (in BioC 3.20). And finally to remove them from GenomicFeatures (in BioC 3.21). Once this is done, GenomicFeatures will only contain the functions and methods to operate on TxDb objects (consumers), while txdbmaker provides the tools to make them (producers).

The motivations for this split are:

bioc-issue-bot commented 8 months ago

Your package has been added to git.bioconductor.org to continue the pre-review process. A build report will be posted shortly. Please fix any ERROR and WARNING in the build report before a reviewer is assigned or provide a justification on why you feel the ERROR or WARNING should be granted an exception.

IMPORTANT: Please read this documentation for setting up remotes to push to git.bioconductor.org. All changes should be pushed to git.bioconductor.org moving forward. It is required to push a version bump to git.bioconductor.org to trigger a new build report.

Bioconductor utilized your github ssh-keys for git.bioconductor.org access. To manage keys and future access you may want to active your Bioconductor Git Credentials Account

bioc-issue-bot commented 8 months ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Build System.

On one or more platforms, the build results were: "ERROR, skipped". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Bioconductor Build System: ERROR before build products produced.

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/txdbmaker to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

lshep commented 8 months ago

I haven't switch the SPB to build on 3.19 yet so its still running R 4.3/Bioc 3.18

bioc-issue-bot commented 8 months ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 982cc9a904c0efd59180be060ec18cd89084d737

hpages commented 8 months ago

@lshep I see. I'm just temporarily removing R (>= 4.4.0) from Depends so we'll see how that goes.

bioc-issue-bot commented 8 months ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Build System.

On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Bioconductor Build System: macOS 12.6.5 Monterey: txdbmaker_0.99.1.tar.gz Linux (Ubuntu 22.04.2 LTS): txdbmaker_0.99.1.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/txdbmaker to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

hpages commented 8 months ago

Hmm.. R CMD check takes only 7m8s on my laptop:

hpages@XPS15:~/WIP/txdbmaker$ time R CMD check txdbmaker_0.99.1.tar.gz 
* using log directory ‘/home/hpages/WIP/txdbmaker/txdbmaker.Rcheck’
...
* checking re-building of vignette outputs ... OK
* checking PDF version of manual ... OK
* DONE

Status: 2 NOTEs
See
  ‘/home/hpages/WIP/txdbmaker/txdbmaker.Rcheck/00check.log’
for details.

real    7m8.177s
user    3m24.953s
sys 0m7.912s

The daily builds are currently running on nebbiolo2 and lconway, and the load is very high on the 2 machines, so maybe that's why R CMD check took more than 10 minutes. I'll trigger another build later when the daily builds are not running to see if that makes a difference.

bioc-issue-bot commented 8 months ago

Received a valid push on git.bioconductor.org; starting a build for commit id: dcc6dfc92edf577733cd540069f04d41292cd7c1

bioc-issue-bot commented 8 months ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Build System.

On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Bioconductor Build System: macOS 12.6.5 Monterey: txdbmaker_0.99.2.tar.gz Linux (Ubuntu 22.04.2 LTS): txdbmaker_0.99.2.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/txdbmaker to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

hpages commented 8 months ago

R CMD check went slightly faster now that the build machines are no longer busy, but still took slightly more than 10 minutes: 12 minutes 13.50 seconds on nebbiolo2, and 10 minutes 5.24 seconds on lconway. I hope that's acceptable.

bioc-issue-bot commented 7 months ago

A reviewer has been assigned to your package for an indepth review. Please respond accordingly to any further comments from the reviewer.

Kayla-Morrell commented 7 months ago

@hpages - Please see the initial review of the package below. No major changes to the package, just a few points that could be addressed. The required changes must be made while the suggested changes do not have to be (though strongly encouraged). Comment back when updates have been made and I'll do a re-review.

DESCRIPTION

Data

Vignette

Man pages

R code

Best, Kayla

lshep commented 6 months ago

@hpages may we expect updates to the package to address the review comments soon?

hpages commented 5 months ago

Hi @Kayla-Morrell, thanks for your feedback. I'll work on it this week.

bioc-issue-bot commented 5 months ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 7130ac1b355911592e878f469a5cbf069b4be788

bioc-issue-bot commented 5 months ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Single Package Builder.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Single Package Builder: macOS 12.7.1 Monterey: txdbmaker_0.99.3.tar.gz Linux (Ubuntu 22.04.2 LTS): txdbmaker_0.99.3.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/txdbmaker to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 5 months ago

Received a valid push on git.bioconductor.org; starting a build for commit id: d0a52f1abc384e5bed6a41ddcb412c64cd3a51cb

bioc-issue-bot commented 5 months ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Single Package Builder.

On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Single Package Builder: macOS 12.7.1 Monterey: txdbmaker_0.99.4.tar.gz Linux (Ubuntu 22.04.2 LTS): txdbmaker_0.99.4.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/txdbmaker to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

hpages commented 5 months ago

This R CMD check WARNING will go away when the package makes it to release:

* checking Rd cross-references ... WARNING
Missing link or links in Rd file 'txdbmaker-package.Rd':
  ‘https://bioconductor.org/packages/release/bioc/vignettes/txdbmaker/inst/doc/txdbmaker.html’

I thought it might be convenient to link the online vignette off the package man page but I can drop that if it's too problematic.

All REQUIRED changes were made. To document the data in inst/extdata/ I added a README.txt in inst/extdata/ rather than in inst/scripts/.

Here are the SUGGESTED changes I made:

H.

Kayla-Morrell commented 3 months ago

@hpages - Thank you for making the necessary changes. I've looked everything over and I'm more than happy to accept the package.

Best, Kayla

bioc-issue-bot commented 3 months ago

Your package has been accepted. It will be added to the Bioconductor nightly builds.

Thank you for contributing to Bioconductor!

Reviewers for Bioconductor packages are volunteers from the Bioconductor community. If you are interested in becoming a Bioconductor package reviewer, please see Reviewers Expectations.

lshep commented 3 months ago

The default branch of your GitHub repository has been added to Bioconductor's git repository as branch devel.

To use the git.bioconductor.org repository, we need an 'ssh' key to associate with your github user name. If your GitHub account already has ssh public keys (https://github.com/hpages.keys is not empty), then no further steps are required. Otherwise, do the following:

  1. Add an SSH key to your github account
  2. Submit your SSH key to Bioconductor

See further instructions at

https://bioconductor.org/developers/how-to/git/

for working with this repository. See especially

https://bioconductor.org/developers/how-to/git/new-package-workflow/ https://bioconductor.org/developers/how-to/git/sync-existing-repositories/

to keep your GitHub and Bioconductor repositories in sync.

Your package will be included in the next nigthly 'devel' build (check-out from git at about 6 pm Eastern; build completion around 2pm Eastern the next day) at

https://bioconductor.org/checkResults/

(Builds sometimes fail, so ensure that the date stamps on the main landing page are consistent with the addition of your package). Once the package builds successfully, you package will be available for download in the 'Devel' version of Bioconductor using BiocManager::install("txdbmaker"). The package 'landing page' will be created at

https://bioconductor.org/packages/txdbmaker

If you have any questions, please contact the bioc-devel mailing list (https://stat.ethz.ch/mailman/listinfo/bioc-devel); this issue will not be monitored further.