Bioconductor / Contributions

Contribute Packages to Bioconductor
131 stars 33 forks source link

tidyCoverage #3248

Closed js2264 closed 5 months ago

js2264 commented 7 months ago

Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor

Confirm the following by editing each check box to '[x]'

I am familiar with the essential aspects of Bioconductor software management, including:

For questions/help about the submission process, including questions about the output of the automatic reports generated by the SPB (Single Package Builder), please use the #package-submission channel of our Community Slack. Follow the link on the home page of the Bioconductor website to sign up.

bioc-issue-bot commented 7 months ago

Hi @js2264

Thanks for submitting your package. We are taking a quick look at it and you will hear back from us soon.

The DESCRIPTION file for this package is:

Package: tidyCoverage
Title: Extract and aggregate genomic coverage over features of interest
Version: 0.99.0
Date: 2023-11-09
Authors@R: 
    person("Jacques", "Serizay", , "jacquesserizay@gmail.com", 
        role = c("aut", "cre"))
Description: `tidyCoverage` framework enables tidy manipulation 
    of collections of genomic tracks and features using 
    `tidySummarizedExperiment` methods. It facilitates the 
    extraction, aggregation and visualization of genomic coverage over 
    individual of thousands of genomic loci, relying on `CoverageExperiment`
    and `AggregatedCoverage` classes. This accelerates the integration 
    of genomic track data in genomic analysis workflows. 
License: MIT + file LICENSE
URL: https://github.com/js2264/tidyCoverage
BugReports: https://github.com/js2264/tidyCoverage/issues
biocViews: 
    Software, 
    Coverage
Encoding: UTF-8
Roxygen: list(markdown = TRUE)
RoxygenNote: 7.2.3
Depends: 
    R (>= 4.3.0),
    SummarizedExperiment
Imports: 
    S4Vectors, 
    IRanges,
    GenomicRanges,
    GenomeInfoDb, 
    BiocParallel, 
    rtracklayer,
    methods,
    tidyr, 
    dplyr,
    fansi, 
    pillar, 
    rlang, 
    cli, 
    purrr, 
    vctrs, 
    stats
Suggests: 
    tidySummarizedExperiment,
    plyranges,
    ggplot2,
    TxDb.Hsapiens.UCSC.hg19.knownGene,
    AnnotationHub,
    GenomicFeatures, 
    BiocStyle,
    hues, 
    knitr,
    rmarkdown,
    sessioninfo,
    testthat (>= 3.0.0)
Config/testthat/edition: 3
VignetteBuilder: knitr
LazyData: false
bioc-issue-bot commented 6 months ago

Your package has been added to git.bioconductor.org to continue the pre-review process. A build report will be posted shortly. Please fix any ERROR and WARNING in the build report before a reviewer is assigned or provide a justification on why you feel the ERROR or WARNING should be granted an exception.

IMPORTANT: Please read this documentation for setting up remotes to push to git.bioconductor.org. All changes should be pushed to git.bioconductor.org moving forward. It is required to push a version bump to git.bioconductor.org to trigger a new build report.

Bioconductor utilized your github ssh-keys for git.bioconductor.org access. To manage keys and future access you may want to active your Bioconductor Git Credentials Account

bioc-issue-bot commented 6 months ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Single Package Builder.

On one or more platforms, the build results were: "TIMEOUT, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Single Package Builder: Linux (Ubuntu 22.04.2 LTS): tidyCoverage_0.99.0.tar.gz macOS 12.7.1 Monterey: tidyCoverage_0.99.0.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/tidyCoverage to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 6 months ago

Received a valid push on git.bioconductor.org; starting a build for commit id: e4d10b080f65db9951acb072250315269d609818

bioc-issue-bot commented 6 months ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 35af47689fee31cd620863f3dc5e708fa02e5166

bioc-issue-bot commented 6 months ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Single Package Builder.

On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Single Package Builder: ERROR before build products produced.

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/tidyCoverage to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 6 months ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Single Package Builder.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details.

The following are build products from R CMD build on the Single Package Builder: Linux (Ubuntu 22.04.2 LTS): tidyCoverage_0.99.2.tar.gz macOS 12.7.1 Monterey: tidyCoverage_0.99.2.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/tidyCoverage to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 6 months ago

A reviewer has been assigned to your package for an indepth review. Please respond accordingly to any further comments from the reviewer.

DarioS commented 5 months ago

The code is well-written and S4 classes are methods are used. The vignette needs improvement.

bioc-issue-bot commented 5 months ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 68332f1d614b7e50c9df41f4a55e769fa8e6ffa0

bioc-issue-bot commented 5 months ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Single Package Builder.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Single Package Builder: macOS 12.7.1 Monterey: tidyCoverage_0.99.3.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/tidyCoverage to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 5 months ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 17d83fc5852958fdcffb6c80c2e5c4cae4d765f1

bioc-issue-bot commented 5 months ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Single Package Builder.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Single Package Builder: macOS 12.7.1 Monterey: tidyCoverage_0.99.4.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/tidyCoverage to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

js2264 commented 5 months ago

Hi @DarioS thanks for reviewing my package. I have addressed your comments and updated the vignette and README. Not sure why I now have an ERROR related to me not being subscribed to the Bioc-devel mailing list. I have been subscribed to the mailing list for 5+ years. Also, this ERROR was not raised in previous builds in this issue 🧐 Let me know if I can further improve the package!

DarioS commented 5 months ago

The issues have been addressed well.

bioc-issue-bot commented 5 months ago

Your package has been accepted. It will be added to the Bioconductor nightly builds.

Thank you for contributing to Bioconductor!

Reviewers for Bioconductor packages are volunteers from the Bioconductor community. If you are interested in becoming a Bioconductor package reviewer, please see Reviewers Expectations.

js2264 commented 5 months ago

Thanks for the review and the fast turnaround @DarioS, much appreciated!

lshep commented 5 months ago

The default branch of your GitHub repository has been added to Bioconductor's git repository as branch devel.

To use the git.bioconductor.org repository, we need an 'ssh' key to associate with your github user name. If your GitHub account already has ssh public keys (https://github.com/js2264.keys is not empty), then no further steps are required. Otherwise, do the following:

  1. Add an SSH key to your github account
  2. Submit your SSH key to Bioconductor

See further instructions at

https://bioconductor.org/developers/how-to/git/

for working with this repository. See especially

https://bioconductor.org/developers/how-to/git/new-package-workflow/ https://bioconductor.org/developers/how-to/git/sync-existing-repositories/

to keep your GitHub and Bioconductor repositories in sync.

Your package will be included in the next nigthly 'devel' build (check-out from git at about 6 pm Eastern; build completion around 2pm Eastern the next day) at

https://bioconductor.org/checkResults/

(Builds sometimes fail, so ensure that the date stamps on the main landing page are consistent with the addition of your package). Once the package builds successfully, you package will be available for download in the 'Devel' version of Bioconductor using BiocManager::install("tidyCoverage"). The package 'landing page' will be created at

https://bioconductor.org/packages/tidyCoverage

If you have any questions, please contact the bioc-devel mailing list (https://stat.ethz.ch/mailman/listinfo/bioc-devel); this issue will not be monitored further.