Bioconductor / Contributions

Contribute Packages to Bioconductor
134 stars 33 forks source link

TENxXeniumData #3255

Closed mrbakhsh closed 7 months ago

mrbakhsh commented 9 months ago

Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor

Confirm the following by editing each check box to '[x]'

I am familiar with the essential aspects of Bioconductor software management, including:

For questions/help about the submission process, including questions about the output of the automatic reports generated by the SPB (Single Package Builder), please use the #package-submission channel of our Community Slack. Follow the link on the home page of the Bioconductor website to sign up.

bioc-issue-bot commented 9 months ago

Hi @mrbakhsh

Thanks for submitting your package. We are taking a quick look at it and you will hear back from us soon.

The DESCRIPTION file for this package is:

Package: TENxXeniumData
Version: 0.99.0
Title: Collection of Xenium spatial data by 10X genomics
Description: 
    Collection of Xenium spatial transcriptomics datasets provided by 10x 
    Genomics, formatted into the Bioconductor classes, the SpatialExperiment 
    or SpatialFeatureExperiment (SFE), to facilitate seamless integration 
    into various applications, including examples, demonstrations, 
    and tutorials. The constructed data objects include gene expression 
    profiles, per-transcript location data, centroid, segmentation 
    boundaries (e.g., cell or nucleus boundaries), and image. 
Authors@R: c(person("Matineh", "Rahmatbakhsh", email = "matinerb.94@gmail.com",
    role = c("aut")),
    person("Monica", "Ge", email = "gex5@gene.com",
    role = c("aut", "cre")))
URL: https://github.com/mrbakhsh/TENxXeniumData
BugReports: https://github.com/mrbakhsh/TENxXeniumData/issues
License: MIT + file LICENSE
Encoding: UTF-8
biocViews:
    ExperimentData, 
    ExperimentHub, 
    SpatialData
Depends: 
    ExperimentHub
Imports:
    SpatialExperiment,
    SpatialFeatureExperiment,
    BumpyMatrix,
    SummarizedExperiment
VignetteBuilder: knitr
Suggests:
    BiocStyle, 
    knitr, 
    rmarkdown
RoxygenNote: 7.2.3
bioc-issue-bot commented 9 months ago

Your package has been added to git.bioconductor.org to continue the pre-review process. A build report will be posted shortly. Please fix any ERROR and WARNING in the build report before a reviewer is assigned or provide a justification on why you feel the ERROR or WARNING should be granted an exception.

IMPORTANT: Please read this documentation for setting up remotes to push to git.bioconductor.org. All changes should be pushed to git.bioconductor.org moving forward. It is required to push a version bump to git.bioconductor.org to trigger a new build report.

Bioconductor utilized your github ssh-keys for git.bioconductor.org access. To manage keys and future access you may want to active your Bioconductor Git Credentials Account

bioc-issue-bot commented 9 months ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Single Package Builder.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Single Package Builder: macOS 12.7.1 Monterey: TENxXeniumData_0.99.0.tar.gz Linux (Ubuntu 22.04.2 LTS): TENxXeniumData_0.99.0.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/TENxXeniumData to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 9 months ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 23bf1e5d54dd78c37e05c077d0fea7acc1e872a3

bioc-issue-bot commented 9 months ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Single Package Builder.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details.

The following are build products from R CMD build on the Single Package Builder: macOS 12.7.1 Monterey: TENxXeniumData_0.99.1.tar.gz Linux (Ubuntu 22.04.2 LTS): TENxXeniumData_0.99.1.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/TENxXeniumData to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 8 months ago

A reviewer has been assigned to your package for an indepth review. Please respond accordingly to any further comments from the reviewer.

lshep commented 8 months ago

My only comment is could you please rename the Rmd file from vignette.Rmd to TENxXeniumData.Rmd (or anything more distinct) to avoid naming conflicts with other package. If a package with the same name (as generic as vignette or intro) is loaded on the path first, that file will open instead of your intended package vignette.

bioc-issue-bot commented 8 months ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 495cb1ed2d67cbb517c1b6ac40dd7a675c2f52dd

bioc-issue-bot commented 8 months ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Single Package Builder.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details.

The following are build products from R CMD build on the Single Package Builder: Linux (Ubuntu 22.04.3 LTS): TENxXeniumData_0.99.2.tar.gz macOS 12.7.1 Monterey: TENxXeniumData_0.99.2.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/TENxXeniumData to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

mrbakhsh commented 8 months ago

Hi @lshep , thanks for the suggestion. I have already renamed the vignette from vignette.Rmd to TENxXeniumData.Rmd.

bioc-issue-bot commented 7 months ago

Your package has been accepted. It will be added to the Bioconductor nightly builds.

Thank you for contributing to Bioconductor!

Reviewers for Bioconductor packages are volunteers from the Bioconductor community. If you are interested in becoming a Bioconductor package reviewer, please see Reviewers Expectations.

lshep commented 7 months ago

The default branch of your GitHub repository has been added to Bioconductor's git repository as branch devel.

To use the git.bioconductor.org repository, we need an 'ssh' key to associate with your github user name. If your GitHub account already has ssh public keys (https://github.com/mrbakhsh.keys is not empty), then no further steps are required. Otherwise, do the following:

  1. Add an SSH key to your github account
  2. Submit your SSH key to Bioconductor

See further instructions at

https://bioconductor.org/developers/how-to/git/

for working with this repository. See especially

https://bioconductor.org/developers/how-to/git/new-package-workflow/ https://bioconductor.org/developers/how-to/git/sync-existing-repositories/

to keep your GitHub and Bioconductor repositories in sync.

Your package will be included in the next nigthly 'devel' build (check-out from git at about 6 pm Eastern; build completion around 2pm Eastern the next day) at

https://bioconductor.org/checkResults/

(Builds sometimes fail, so ensure that the date stamps on the main landing page are consistent with the addition of your package). Once the package builds successfully, you package will be available for download in the 'Devel' version of Bioconductor using BiocManager::install("TENxXeniumData"). The package 'landing page' will be created at

https://bioconductor.org/packages/TENxXeniumData

If you have any questions, please contact the bioc-devel mailing list (https://stat.ethz.ch/mailman/listinfo/bioc-devel); this issue will not be monitored further.