Closed brianSroberts closed 3 months ago
Hi @brianSroberts
Thanks for submitting your package. We are taking a quick look at it and you will hear back from us soon.
The DESCRIPTION file for this package is:
Package: DegCre
Type: Package
Title: Probabilistic association of DEGs to CREs from differential data
Version: 0.99.0
Date: 2023-12-04
Authors@R: person(given="Brian S.",
family="Roberts",
email = "brianroberts1976@yahoo.com",
role = c("aut", "cre"),
comment=c(ORCID = "0009-0001-2914-6826"))
Maintainer@R: person(given="Brian S.",
family="Roberts",
email = "brianroberts1976@yahoo.com",
comment=c(ORCID = "0009-0001-2914-6826"))
Description:
DegCre generates associations between differentially expressed genes (DEGs)
and cis-regulatory elements (CREs) based on non-parametric concordance
between differential data. The user provides GRanges of DEG TSS and CRE
regions with differential p-value and optionally log-fold changes and
DegCre returns an annotated Hits object with associations and their
calculated probabilities. Additionally, the package provides functionality
for visualization and conversion to other formats.
License: MIT + file LICENSE
Encoding: UTF-8
RoxygenNote: 7.2.3
Depends: R (>= 4.2.1)
URL: https://github.com/brianSroberts/DegCre
Imports:
GenomicRanges,
InteractionSet,
plotgardener,
S4Vectors,
stats,
graphics,
grDevices
biocViews:
GeneExpression,
GeneRegulation,
ATACSeq,
ChIPSeq,
DNaseSeq,
RNASeq
Suggests:
BSgenome,
BSgenome.Hsapiens.UCSC.hg38,
org.Hs.eg.db,
knitr,
rmarkdown,
TxDb.Hsapiens.UCSC.hg38.knownGene,
TxDb.Mmusculus.UCSC.mm10.knownGene,
testthat (>= 3.0.0)
VignetteBuilder: knitr
Config/testthat/edition: 3
Please write to a tempdir() in examples and vignettes. I see a write call in man/convertDegCreDataFrame.Rd that would save to the current working directory if run.
When I tried to build your package I got the following ERROR:
lorikern@jbcj433:~/PkgReview$ R CMD build DegCre
* checking for file 'DegCre/DESCRIPTION' ... OK
* preparing 'DegCre':
* checking DESCRIPTION meta-information ... OK
* installing the package to build vignettes
* creating vignettes ... ERROR
--- re-building ‘degcre_introduction_and_examples.Rmd’ using rmarkdown
Warning in doTryCatch(return(expr), name, parentenv, handler) :
semi-transparency is not supported on this device: reported only once per page
Warning in doTryCatch(return(expr), name, parentenv, handler) :
semi-transparency is not supported on this device: reported only once per page
Warning in doTryCatch(return(expr), name, parentenv, handler) :
semi-transparency is not supported on this device: reported only once per page
Warning in grid.Call.graphics(C_polygon, x$x, x$y, list(as.integer(seq_along(x$x)))) :
semi-transparency is not supported on this device: reported only once per page
Quitting from lines 336-340 [demo convert to DataFrame] (degcre_introduction_and_examples.Rmd)
Error: processing vignette 'degcre_introduction_and_examples.Rmd' failed with diagnostics:
undefined columns selected
--- failed re-building ‘degcre_introduction_and_examples.Rmd’
SUMMARY: processing the following file failed:
‘degcre_introduction_and_examples.Rmd’
Error: Vignette re-building failed.
Execution halted
I have changed the example to write to a temp file. I also fixed a bug in convertDegCreDataFrame() that was causing the vignette build to error. I also added a test function for convertDegCreDataFrame().
Hi, just posting again to get this issue to pop up again. I've made the changes and everything should be working correctly now.
Your package has been added to git.bioconductor.org to continue the pre-review process. A build report will be posted shortly. Please fix any ERROR and WARNING in the build report before a reviewer is assigned or provide a justification on why you feel the ERROR or WARNING should be granted an exception.
IMPORTANT: Please read this documentation for setting up remotes to push to git.bioconductor.org. All changes should be pushed to git.bioconductor.org moving forward. It is required to push a version bump to git.bioconductor.org to trigger a new build report.
Bioconductor utilized your github ssh-keys for git.bioconductor.org access. To manage keys and future access you may want to active your Bioconductor Git Credentials Account
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Single Package Builder.
On one or more platforms, the build results were: "TIMEOUT, WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
The following are build products from R CMD build on the Single Package Builder: macOS 12.7.1 Monterey: DegCre_0.99.0.tar.gz Linux (Ubuntu 22.04.2 LTS): DegCre_0.99.0.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/DegCre
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
I'm not able to push to the Bioconductor git. I have activated my git credentials and the ssh key listed there matches mine. But when I try:
git push upstream main:devel
I get
git@git.bioconductor.org: Permission denied (publickey).
Running git remote -v returns:
origin https://github.com/brianSroberts/DegCre.git (fetch) origin https://github.com/brianSroberts/DegCre.git (push) upstream git@git.bioconductor.org:packages/DegCre.git (fetch) upstream git@git.bioconductor.org:packages/DegCre.git (push)
which seems right.
So I'm not sure what I'm doing wrong. Any help is appreciated!
That does look correct as does all our configuration on our end. I would check out maybe number 15 of http://contributions.bioconductor.org/git-version-control.html#faq or add a new ssh key.
Received a valid push on git.bioconductor.org; starting a build for commit id: 5356d9df1761ded323b33f71f092360b0a455bab
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Single Package Builder.
On one or more platforms, the build results were: "TIMEOUT, skipped". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
The following are build products from R CMD build on the Single Package Builder: Linux (Ubuntu 22.04.3 LTS): DegCre_0.99.1.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/DegCre
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: f27f2d0191d1912abcdb6bedb1c26ea6ae72cd7d
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Single Package Builder.
On one or more platforms, the build results were: "TIMEOUT, WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
The following are build products from R CMD build on the Single Package Builder: Linux (Ubuntu 22.04.3 LTS): DegCre_0.99.2.tar.gz macOS 12.7.1 Monterey: DegCre_0.99.2.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/DegCre
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 3c61f6c540d88a80c2641a6de0fa52989b0ef2ac
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Single Package Builder.
On one or more platforms, the build results were: "TIMEOUT, skipped". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
The following are build products from R CMD build on the Single Package Builder: : DegCre_0.99.3.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/DegCre
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 0d6714503fb988fa57381c12893c09fdbf6da75b
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Single Package Builder.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
The following are build products from R CMD build on the Single Package Builder: macOS 12.7.1 Monterey: DegCre_0.99.4.tar.gz : DegCre_0.99.4.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/DegCre
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: a610f3bce049e5796076596b8fce6bfe7564c4bc
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Single Package Builder.
On one or more platforms, the build results were: "TIMEOUT, skipped". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
The following are build products from R CMD build on the Single Package Builder: : DegCre_0.99.5.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/DegCre
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Single Package Builder.
On one or more platforms, the build results were: "WARNINGS, TIMEOUT". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
The following are build products from R CMD build on the Single Package Builder: Linux (Ubuntu 22.04.3 LTS): DegCre_0.99.5.tar.gz macOS 12.7.1 Monterey: DegCre_0.99.5.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/DegCre
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
The bio-issue-bot changed the tag from ERROR to WARNINGS. It appears that it is timing out when trying to run examples and build vignettes. The code in those is expected to take a while to run because the inputs are complex in order to faithfully reproduce actual uses of the package. Do I need to do something here?
Often times smaller datasets can be used to demonstrate the package effectively. Can the amount of input being used be minimized to reduce timing. We expect packages to build and check in a reasonable amount of time.
Received a valid push on git.bioconductor.org; starting a build for commit id: f720965a85a918c8958ff134f357ceeacb7f2e40
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Single Package Builder.
On one or more platforms, the build results were: "WARNINGS, TIMEOUT". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
The following are build products from R CMD build on the Single Package Builder: Linux (Ubuntu 22.04.3 LTS): DegCre_0.99.6.tar.gz macOS 12.7.1 Monterey: DegCre_0.99.6.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/DegCre
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: c9e9f8c4c7acb824e427f032c46bc8c6ca05a89b
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Single Package Builder.
On one or more platforms, the build results were: "WARNINGS, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
The following are build products from R CMD build on the Single Package Builder: Linux (Ubuntu 22.04.3 LTS): DegCre_0.99.7.tar.gz macOS 12.7.1 Monterey: DegCre_0.99.7.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/DegCre
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 14c1c9f1274e8326586f457ff25fa7e164d29605
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Single Package Builder.
On one or more platforms, the build results were: "WARNINGS, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
The following are build products from R CMD build on the Single Package Builder: Linux (Ubuntu 22.04.3 LTS): DegCre_0.99.8.tar.gz macOS 12.7.1 Monterey: DegCre_0.99.8.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/DegCre
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: b89e13f52ba4572523e65bbd06a3f30373089255
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Single Package Builder.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
The following are build products from R CMD build on the Single Package Builder: Linux (Ubuntu 22.04.3 LTS): DegCre_0.99.9.tar.gz macOS 12.7.1 Monterey: DegCre_0.99.9.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/DegCre
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 0fed590980d0029d59c5234b03f69f53bbbb3015
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Single Package Builder.
On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
The following are build products from R CMD build on the Single Package Builder: macOS 12.7.1 Monterey: DegCre_0.99.10.tar.gz Linux (Ubuntu 22.04.3 LTS): DegCre_0.99.10.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/DegCre
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 6c1f17a6aa360cbd912369ceb05a17513e9851d4
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Single Package Builder.
On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
The following are build products from R CMD build on the Single Package Builder: macOS 12.7.1 Monterey: DegCre_0.99.11.tar.gz Linux (Ubuntu 22.04.3 LTS): DegCre_0.99.11.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/DegCre
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 73e91599444a939c8044bcadc74489e446e3bfbb
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Single Package Builder.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details.
The following are build products from R CMD build on the Single Package Builder: macOS 12.7.1 Monterey: DegCre_0.99.12.tar.gz Linux (Ubuntu 22.04.3 LTS): DegCre_0.99.12.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/DegCre
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
A reviewer has been assigned to your package for an indepth review. Please respond accordingly to any further comments from the reviewer.
Thank you for submitting your package to Bioconductor. The package passed check and build. It is in pretty good shape. However there are several things need to be fixed. Please try to answer the comments line by line when you are ready for a second review. Code: Note: please consider; Important: must be addressed.
importFrom
instead of import all with import
.
::
is not suggested in source code unless you can make sure all the packages are imported. Some people think it is better to keep ::
. However please note that you need to manully double check the import items when you make any change in the DESCRIPTION file during development. My recommendation is to remove one or two repeats to force the dependency check.for
loops present, try to replace them by *apply
funcitons.
drop=FALSE
to avoid the reduction of dimension for matrices and arrays. Ignore this if using datatable.
seq.int
or seq_len
. For example using seq.int(min(5, nrow(data)))
to replace seq.int(5)
convertDegCreDataFrame
and convertdegCreResListToGInteraction
BiocStyle
package for formatting.
Package 'DegCre' Review
Thank you for submitting your package to Bioconductor. The package passed check and build. It is in pretty good shape. However there are several things need to be fixed. Please try to answer the comments line by line when you are ready for a second review. Code: Note: please consider; Important: must be addressed.
The DESCRIPTION file
- [ ] Important: R version should be no less than 4.4
The R version has been updated to R 4.3.3 which is the latest public release
The NAMESPACE file
[ ] NOTE: Selective imports using
importFrom
instead of import all withimport
.
- in line 17 import(GenomicRanges)
- in line 18 import(S4Vectors)
- in line 19 import(grDevices)
These have been changed to importFrom()
R code
- [ ] NOTE:
::
is not suggested in source code unless you can make sure all the packages are imported. Some people think it is better to keep::
. However please note that you need to manully double check the import items when you make any change in the DESCRIPTION file during development. My recommendation is to remove one or two repeats to force the dependency check.I prefer to keep the
::
notation in the source code because to me it enhances readability. I have checked the imported items and verified their operation.
[ ] NOTE: Vectorize:
for
loops present, try to replace them by*apply
funcitons.
In file R/degCreConversions.R:
at line 63 found ' for(binIdY in uniqBinIds){'
In testing, I found that running this in a for loop was faster than in an *apply function due to the need to assign out of the loop frame.
In file R/degCreCore.R:
at line 1346 found ' for (uniqDBinY in uniqDistBinsX) {'
This for loop allows for the overwriting of elements in adjRefAssocProbsX as the algorithm steps through distance bins. It would use more resources within an *apply function.
In file R/degCrePlotFuns.R:
at line 223 found ' for(i in seq_along(uniqMaxBinDists)){'
This has been replaced with an lapply()
[ ] Important: Please consider to add
drop=FALSE
to avoid the reduction of dimension for matrices and arrays. Ignore this if using datatable.
In file R/degCreConversions.R:
at line 280 found ' keepHitsMcolsDf <- hitsMcolsDf[,c(seq_len(4),seq(from=8,to=10))]'
at line 282 found ' outDf <- data.frame(keepDegDfx[,seq_len(4)],'
at line 283 found ' keepCreDfx[,seq_len(4)],'
at line 285 found ' keepDegDfx[,seq(from=5,to=ncol(keepDegDfx))],'
at line 286 found ' keepCreDfx[,seq(from=5,to=ncol(keepCreDfx))])'
"drop=FALSE" has been added to each of these lines
In file R/degCreCore.R:
- at line 323 found ' sortPromCreHitsDf <- promCreHitsDf[order(promCreHitsDf$assocDist),]'
- at line 455 found ' allDistBinsStatsMat <- cbind(allDistBinsStatsMat[,1],'
- at line 456 found ' allAssocProbFDR,allDistBinsStatsMat[,2:ncol(allDistBinsStatsMat)])'
- at line 462 found ' sortPromCreHitsStatsDf <- data.frame(sortPromCreHitsDf[,seq_len(3)],'
- at line 487 found ' mcolsHitsDf <- sortPromCreHitsStatsDf[,3:ncol(sortPromCreHitsStatsDf)]'
- at line 1242 found ' totalObs <- nrow(hitsWithDistDf[subHitsIndex,])'
"drop=FALSE" has been added to each of these lines
In file R/degCrePerDegFuns.R:
- at line 125 found ' uniqGeneDegMcolsDf <- allDegGRMcolsDf[uniqGeneIndices,]'
- at line 237 found ' expectAssocPerDegDf[which(!is.na(rawExpectAssocs)),]'
"drop=FALSE" has been added to each of these lines
[ ] NOTE: Try to check the edge condition when using
seq.int
orseq_len
. For example usingseq.int(min(5, nrow(data)))
to replaceseq.int(5)
In file R/degCreConversions.R:
at line 264 found ' keepDegDfx <- keepDegDfx[,c(seq_len(3),'
at line 272 found ' keepCreDfx <- keepCreDfx[,c(seq_len(3),'
at line 280 found ' keepHitsMcolsDf <- hitsMcolsDf[,c(seq_len(4),seq(from=8,to=10))]'
at line 282 found ' outDf <- data.frame(keepDegDfx[,seq_len(4)],'
at line 283 found ' keepCreDfx[,seq_len(4)],'
These are all instances in which subsets of the data.frames are being kept and thus requires hard subset indices to achieve the end goal.
In file R/degCreCore.R:
- at line 462 found ' sortPromCreHitsStatsDf <- data.frame(sortPromCreHitsDf[,seq_len(3)],'
- at line 685 found ' outList <- listX[seq_len(5)]'
Again, these are instances where the subsetting must occur over a specified range.
[ ] NOTE: Functional programming: code repetition.
repetition in
convertDegCreDataFrame
andconvertdegCreResListToGInteraction
in convertDegCreDataFrame
- line 2:{
- line 3: DegGRX <- degCreResList$DegGR
- line 4: CreGRX <- degCreResList$CreGR
- line 5: degCreHits <- degCreResList$degCreHits
- line 6: maskPassAlpha <- which(mcols(degCreHits)$assocProbFDR <=
- line 7: assocAlpha)
- line 8: if (length(maskPassAlpha) < 1) {
- line 9: warning("No associations FDRs pass alpha.")
- line 10: outDf <- NA
- line 11: }
- line 12: else {
- line 13: keepDegCreHits <- degCreHits[maskPassAlpha]
in convertdegCreResListToGInteraction
- line 2: {
- line 3: DegGRX <- degCreResList$DegGR
- line 4: CreGRX <- degCreResList$CreGR
- line 5: degCreHits <- degCreResList$degCreHits
- line 6: maskPassAlpha <- which(mcols(degCreHits)$assocProbFDR <=
- line 7: assocAlpha)
- line 8: if (length(maskPassAlpha) < 1) {
- line 9: warning("No associations FDRs pass alpha.")
- line 10: outGInter <- NA
- line 11: }
- line 12: else {
- line 13: keepDegCreHits <- degCreHits[maskPassAlpha]
Both of these functions start by subsetting the Hits object on assocProbFDR. The same code is optimal for both. This only happens in these two instances so I did not feel it worth writing a separate function.
Documentation
[ ] Note: Vignette should use
BiocStyle
package for formatting.
- rmd file vignettes/degcre_introduction_and_examples.Rmd
The BiocStyle package has been incorporated for the vignetter formatting.
[ ] Important: Vignette should have an Installation section.
- rmd file vignettes/degcre_introduction_and_examples.Rmd
An Installation section has been added
[ ] Important: Please include Bioconductor installation instructions using BiocManager.
- rmd file vignettes/degcre_introduction_and_examples.Rmd
The Installation section includes instructions for installation with BiocManager.
Received a valid push on git.bioconductor.org; starting a build for commit id: b6ee604d164623d29e979eba2e84758638a9ee26
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Single Package Builder.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
The following are build products from R CMD build on the Single Package Builder: Linux (Ubuntu 22.04.3 LTS): DegCre_0.99.13.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/DegCre
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: cf973ef5bbe97ae74ce7f276ea21ff5b703a5532
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Single Package Builder.
On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
The following are build products from R CMD build on the Single Package Builder: Linux (Ubuntu 22.04.3 LTS): DegCre_0.99.14.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/DegCre
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
It is almost there. However there are several things need to be fixed. Please try to answer the comments line by line when you are ready for a second review. Code: Note: please consider; Important: must be addressed.
/link
be \link
?BiocManager::install(version = "3.18")
in vignettes degcre_introduction_and_examples.Rmd
. In the description, please remove the version 3.18 (R version 4.3)
.Received a valid push on git.bioconductor.org; starting a build for commit id: 8e8985991500dbe0cda72e6ec89071854b4c430c
Package 'DegCre' Review
It is almost there. However there are several things need to be fixed. Please try to answer the comments line by line when you are ready for a second review. Code: Note: please consider; Important: must be addressed.
The DESCRIPTION file
- [ ] Important: Update R version dependency from 4.3.3 to 4.4.0.
I have made this change to R 4.4.0
Namespace
- [ ] Note: Consider adding importFrom("grDevices", "col2rgb", "rgb") importFrom("utils", "head", "tail")
These importFrom calls have been added.
Documentation
- [ ] Important: Multiple typos. Should
/link
be\link
?These typos have been fixed.
[ ] Important: Installation session should not contain the line 28
BiocManager::install(version = "3.18")
in vignettesdegcre_introduction_and_examples.Rmd
. In the description, please remove theversion 3.18 (R version 4.3)
.This change has been made.
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Single Package Builder.
On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
The following are build products from R CMD build on the Single Package Builder: Linux (Ubuntu 22.04.3 LTS): DegCre_0.99.15.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/DegCre
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 471a73cb3c58a1fcdd55080d9500765bbc156429
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Single Package Builder.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details.
The following are build products from R CMD build on the Single Package Builder: Linux (Ubuntu 22.04.3 LTS): DegCre_0.99.16.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/DegCre
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Your package has been accepted. It will be added to the Bioconductor nightly builds.
Thank you for contributing to Bioconductor!
Reviewers for Bioconductor packages are volunteers from the Bioconductor community. If you are interested in becoming a Bioconductor package reviewer, please see Reviewers Expectations.
The default branch of your GitHub repository has been added to Bioconductor's git repository as branch devel.
To use the git.bioconductor.org repository, we need an 'ssh' key to associate with your github user name. If your GitHub account already has ssh public keys (https://github.com/brianSroberts.keys is not empty), then no further steps are required. Otherwise, do the following:
See further instructions at
https://bioconductor.org/developers/how-to/git/
for working with this repository. See especially
https://bioconductor.org/developers/how-to/git/new-package-workflow/ https://bioconductor.org/developers/how-to/git/sync-existing-repositories/
to keep your GitHub and Bioconductor repositories in sync.
Your package will be included in the next nigthly 'devel' build (check-out from git at about 6 pm Eastern; build completion around 2pm Eastern the next day) at
https://bioconductor.org/checkResults/
(Builds sometimes fail, so ensure that the date stamps on the main landing page are consistent with the addition of your package). Once the package builds successfully, you package will be available for download in the 'Devel' version of Bioconductor using BiocManager::install("DegCre")
. The package 'landing page' will be created at
https://bioconductor.org/packages/DegCre
If you have any questions, please contact the bioc-devel mailing list (https://stat.ethz.ch/mailman/listinfo/bioc-devel); this issue will not be monitored further.
Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor
Confirm the following by editing each check box to '[x]'
[ x] I understand that by submitting my package to Bioconductor, the package source and all review commentary are visible to the general public.
[ x] I have read the Bioconductor Package Submission instructions. My package is consistent with the Bioconductor Package Guidelines.
[ x] I understand Bioconductor Package Naming Policy and acknowledge Bioconductor may retain use of package name.
[ x] I understand that a minimum requirement for package acceptance is to pass R CMD check and R CMD BiocCheck with no ERROR or WARNINGS. Passing these checks does not result in automatic acceptance. The package will then undergo a formal review and recommendations for acceptance regarding other Bioconductor standards will be addressed.
[ x] My package addresses statistical or bioinformatic issues related to the analysis and comprehension of high throughput genomic data.
[ x] I am committed to the long-term maintenance of my package. This includes monitoring the support site for issues that users may have, subscribing to the bioc-devel mailing list to stay aware of developments in the Bioconductor community, responding promptly to requests for updates from the Core team in response to changes in R or underlying software.
[ x] I am familiar with the Bioconductor code of conduct and agree to abide by it.
I am familiar with the essential aspects of Bioconductor software management, including:
For questions/help about the submission process, including questions about the output of the automatic reports generated by the SPB (Single Package Builder), please use the #package-submission channel of our Community Slack. Follow the link on the home page of the Bioconductor website to sign up.