Closed kinnaryshah closed 8 months ago
Hi @kinnaryshah
Thanks for submitting your package. We are taking a quick look at it and you will hear back from us soon.
The DESCRIPTION file for this package is:
Package: spoon
Title: Address the Mean-variance Relationship in Spatial Transcriptomics Data
Version: 0.99.0
Authors@R: c(
person(given = "Kinnary",
family = "Shah",
role = c("aut", "cre"),
email = "kinnaryshahh@gmail.com",
comment = c(ORCID = "0000-0001-7098-2116")),
person("Boyi", "Guo",
email = "boyi.guo.work@gmail.com",
role = c("aut"),
comment = c(ORCID = "0000-0003-2950-2349")),
person("Stephanie C.", "Hicks",
email = "shicks19@jhu.edu",
role = c("aut"),
comment = c(ORCID = "0000-0002-7858-0231")))
Description: This package addresses the mean-variance relationship in spatially
resolved transcriptomics data. Precision weights are generated for individual
observations using Empirical Bayes techniques. These weights are used to
rescale the data and covariates, which are then used as input in spatially
variable gene detection tools.
URL: https://github.com/kinnaryshah/spoon
BugReports: https://github.com/kinnaryshah/spoon/issues
Imports: SpatialExperiment, BRISC, nnSVG, scuttle, BiocParallel, Matrix, purrr,
methods, SummarizedExperiment, stats, utils
License: MIT + file LICENSE
Encoding: UTF-8
biocViews:
Spatial, SingleCell, Transcriptomics, GeneExpression, Preprocessing
Roxygen: list(markdown = TRUE)
RoxygenNote: 7.3.0
Suggests:
testthat, STexampleData, knitr
Config/testthat/edition: 3
VignetteBuilder: knitr
Your package has been added to git.bioconductor.org to continue the pre-review process. A build report will be posted shortly. Please fix any ERROR and WARNING in the build report before a reviewer is assigned or provide a justification on why you feel the ERROR or WARNING should be granted an exception.
IMPORTANT: Please read this documentation for setting up remotes to push to git.bioconductor.org. All changes should be pushed to git.bioconductor.org moving forward. It is required to push a version bump to git.bioconductor.org to trigger a new build report.
Bioconductor utilized your github ssh-keys for git.bioconductor.org access. To manage keys and future access you may want to active your Bioconductor Git Credentials Account
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Single Package Builder.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
The following are build products from R CMD build on the Single Package Builder: macOS 12.7.1 Monterey: spoon_0.99.0.tar.gz Linux (Ubuntu 22.04.2 LTS): spoon_0.99.0.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/spoon
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
I see that the error is:
I have already subscribed to this mailing list using the same email in the DESCRIPTION file. Thanks!
Have you checked spam or filters? There is confirmation email that gets sent that sometimes is marked as spam
Thank you! I was able to confirm my subscription.
Received a valid push on git.bioconductor.org; starting a build for commit id: e5ed70a62c6d0e3aa038fb878b9fd90f6faaabf4
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Single Package Builder.
On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
The following are build products from R CMD build on the Single Package Builder: Linux (Ubuntu 22.04.3 LTS): spoon_0.99.1.tar.gz macOS 12.7.1 Monterey: spoon_0.99.1.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/spoon
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
A reviewer has been assigned to your package for an indepth review. Please respond accordingly to any further comments from the reviewer.
@kinnaryshah Please fix the warning Running testthat.R WARNING: R CMD check exceeded 10 min requirement
before I start a review. Thank you.
Thank you for the reminder, @jianhong.
I see the CheckTime with nebbiolo1 is 7 minutes, but the CheckTime with merida1 is 15 minutes, which exceeds the 10 minute maximum. On my local machine (macOS Ventura Version 13.2.1), the CheckTime is 3 minutes. I'm not sure how to address this warning. Are there substantial environmental differences or constraints between the two environments?
Received a valid push on git.bioconductor.org; starting a build for commit id: 31cdb7934be729c58137608de90ddf1a0e8134d9
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Single Package Builder.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details.
The following are build products from R CMD build on the Single Package Builder: Linux (Ubuntu 22.04.3 LTS): spoon_0.99.2.tar.gz macOS 12.7.1 Monterey: spoon_0.99.2.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/spoon
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Thank you for submitting your package to Bioconductor. The package passed check and build. It is in pretty good shape. However there are several things need to be fixed. Please try to answer the comments line by line when you are ready for a second review. Code: Note: please consider; Important: must be addressed.
Depends
field is not found in DESCRIPTION.importFrom
instead of import all with import
.
warning
, message
, stop
instead of cat
and print
outside of show
methods.
for
loops present, try to replace them by *apply
funcitons.
drop=FALSE
to avoid the reduction of dimension for matrices and arrays. Ignore this if using datatable.
generate_weights
and weighted_nnSVG
weighted_nnSVG_calc_mat
and weighted_nnSVG_calc_spe
motivation for submitting to Bioconductor
as part of the abstract/intro of the main vignette.
I noticed that you are using '|>' in source and '%>%' in vignette for pipe operation. Very interesting.
Received a valid push on git.bioconductor.org; starting a build for commit id: 37f534705f1f3ba9afb0a3165badb60f844e1090
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Single Package Builder.
On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
The following are build products from R CMD build on the Single Package Builder: : spoon_0.99.3.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/spoon
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 0e5d739984f9764b1af73477597cfda12212f53a
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Single Package Builder.
On one or more platforms, the build results were: "TIMEOUT". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
The following are build products from R CMD build on the Single Package Builder: macOS 12.7.1 Monterey: spoon_0.99.4.tar.gz : spoon_0.99.4.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/spoon
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: c70b74b0a3d22315541721374c3ae4740e017233
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Single Package Builder.
On one or more platforms, the build results were: "TIMEOUT". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
The following are build products from R CMD build on the Single Package Builder: macOS 12.7.1 Monterey: spoon_0.99.5.tar.gz : spoon_0.99.5.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/spoon
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Thank you @jianhong for your thorough review! I've addressed my changes below:
[x] Important: Depends
field is not found in DESCRIPTION.
This has been added
[x] Important: R version is not clear in DESCRIPTION.
This has been added in the Depends
field
[x] Important: Selective imports using importFrom
instead of import all with import
.
BRISC_order
, BRISC_neighbor
, BRISC_estimation
, BRISC_prediction
_bplapply
, MulticoreParam
rowMeans
spatialCoords
nnSVG
, filter_genes
_computeLibraryFactors
, logNormCounts
[x] Important: warning
, message
, stop
instead of cat
and print
outside of show
methods.
In file R/utils.R:
message
message
[x] NOTE: Vectorize: for
loops present, try to replace them by *apply
funcitons.
In file R/generate_weights.R:
[x] Important: Remove unused code.
In file R/generate_weights.R:
[x] NOTE: Avoid 'suppressWarnings'/'*Messages' if possible
In file R/generate_weights.R:
Warning messages: 1: In BRISC_estimation(coords = coords, y = y_i, x = NULL, cov.model = "exponential", : The ordering of inputs x (covariates) and y (response) in BRISC_estimation has been changed BRISC 1.0.0 onwards. Please check the new documentation with ?BRISC_estimation.
[x] Important: Please consider to add drop=FALSE
to avoid the reduction of dimension for matrices and arrays. Ignore this if using datatable.
In file R/generate_weights.R:
[x] NOTE: Functional programming: code repetition.
repetition in generate_weights
and weighted_nnSVG
_Checking that the assay is present in both functions is important to stop each function at the start if the assay is not present. The BPPARAM variable needs to be set separately for each function for parallelization. The second if (is(input, "SpatialExperiment")) {
in generate_weights
is necessary because the code is different for SpatialExperiment
object inputs and matrix inputs. I've left the code as is._
in generate_weights
line 3:{
line 4: if (is(input, "SpatialExperiment")) {
line 5: spe <- input
line 6: stopifnot(assay_name %in% assayNames(spe))
line 7: }
line 8: if (is.null(BPPARAM)) {
line 9: BPPARAM <- MulticoreParam(workers = n_threads)
line 10: }
line 11: if (is(input, "SpatialExperiment")) {
in weighted_nnSVG
line 6: if (n_threads > 1) {
line 7: BPPARAM <- MulticoreParam(workers = n_threads)
line 8: }
line 9: if (is(input, "SpatialExperiment")) {
line 10: spe <- input
line 11: stopifnot(assay_name %in% assayNames(spe))
line 12: }
repetition in weighted_nnSVG_calc_mat
and weighted_nnSVG_calc_spe
_These are two separate functions: weighted_nnSVG_calc_mat
is used for matrix inputs and weighted_nnSVG_calc_spe
is used for SpatialExperiment
object inputs. I've left the code as is._
in weighted_nnSVG_calc_mat
line 9: }, error = function(e) {
line 10: cat("ERROR :", conditionMessage(e), "\n")
line 11: list(weighted_LR_stat = NA, weighted_sigma.sq = NA,
line 12: weighted_tau.sq = NA, weighted_prop_sv = NA)
line 13: })
line 14: return(res)
in weighted_nnSVG_calc_spe
line 10: }, error = function(e) {
line 11: cat("ERROR :", conditionMessage(e), "\n")
line 12: list(weighted_LR_stat = NA, weighted_sigma.sq = NA,
line 13: weighted_tau.sq = NA, weighted_prop_sv = NA)
line 14: })
line 15: return(res)
[x] Note: Vignette includes motivation for submitting to Bioconductor
as part of the abstract/intro of the main vignette.
I noticed that you are using '|>' in source and '%>%' in vignette for pipe operation. Very interesting.
Received a valid push on git.bioconductor.org; starting a build for commit id: 3342a1c3708de09dea797ef8a1a4d74a3645c572
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Single Package Builder.
On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
The following are build products from R CMD build on the Single Package Builder: macOS 12.7.1 Monterey: spoon_0.99.6.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/spoon
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
I wanted to note that I attempted three new builds yesterday after pushing all of my changes. All of these builds had the exact same code except for the version number. I was timed out on the merida1 macOS build twice and got a warning that the build was over the allowed check time on the third attempt. The nebbiolo1 build was fine each time. I believe this issue is not unique to this package (based on the recent [Bioc-devel] Check time on macOS (MIRit) email thread). While the linux builds have been satisfactory, I dealt with a similar macOS issue when first submitting my package for review: the first build on macOS took about 15 minutes and the second took 7 minutes despite no changes being made except for triggering a new build report.
the macOS has been problematic as of late; using linux (nebbiolo1) as the standard for judging the timing right now is advised. I'll kick off a build manually for you to get a new linux result.
thank you, @lshep!
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Single Package Builder.
On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
The following are build products from R CMD build on the Single Package Builder: Linux (Ubuntu 22.04.3 LTS): spoon_0.99.6.tar.gz macOS 12.7.1 Monterey: spoon_0.99.6.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/spoon
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Please update the dependence of R version to 4.4. The only concern is the running time. After update the R version, I will make it as accepted.
Received a valid push on git.bioconductor.org; starting a build for commit id: a4ae8270604c41fd1e7f2c0f00bd2b3ba3cd87f6
Thanks for all of your help and efforts, @jianhong! I've made the change.
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Single Package Builder.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
The following are build products from R CMD build on the Single Package Builder: Linux (Ubuntu 22.04.3 LTS): spoon_0.99.7.tar.gz macOS 12.7.1 Monterey: spoon_0.99.7.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/spoon
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: d96b8cdabdfd9eb5d2cfebff57e4772054412989
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Single Package Builder.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details.
The following are build products from R CMD build on the Single Package Builder: macOS 12.7.1 Monterey: spoon_0.99.8.tar.gz Linux (Ubuntu 22.04.3 LTS): spoon_0.99.8.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/spoon
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Your package has been accepted. It will be added to the Bioconductor nightly builds.
Thank you for contributing to Bioconductor!
Reviewers for Bioconductor packages are volunteers from the Bioconductor community. If you are interested in becoming a Bioconductor package reviewer, please see Reviewers Expectations.
The default branch of your GitHub repository has been added to Bioconductor's git repository as branch devel.
To use the git.bioconductor.org repository, we need an 'ssh' key to associate with your github user name. If your GitHub account already has ssh public keys (https://github.com/kinnaryshah.keys is not empty), then no further steps are required. Otherwise, do the following:
See further instructions at
https://bioconductor.org/developers/how-to/git/
for working with this repository. See especially
https://bioconductor.org/developers/how-to/git/new-package-workflow/ https://bioconductor.org/developers/how-to/git/sync-existing-repositories/
to keep your GitHub and Bioconductor repositories in sync.
Your package will be included in the next nigthly 'devel' build (check-out from git at about 6 pm Eastern; build completion around 2pm Eastern the next day) at
https://bioconductor.org/checkResults/
(Builds sometimes fail, so ensure that the date stamps on the main landing page are consistent with the addition of your package). Once the package builds successfully, you package will be available for download in the 'Devel' version of Bioconductor using BiocManager::install("spoon")
. The package 'landing page' will be created at
https://bioconductor.org/packages/spoon
If you have any questions, please contact the bioc-devel mailing list (https://stat.ethz.ch/mailman/listinfo/bioc-devel); this issue will not be monitored further.
Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor
Confirm the following by editing each check box to '[x]'
[x] I understand that by submitting my package to Bioconductor, the package source and all review commentary are visible to the general public.
[x] I have read the Bioconductor Package Submission instructions. My package is consistent with the Bioconductor Package Guidelines.
[x] I understand Bioconductor Package Naming Policy and acknowledge Bioconductor may retain use of package name.
[x] I understand that a minimum requirement for package acceptance is to pass R CMD check and R CMD BiocCheck with no ERROR or WARNINGS. Passing these checks does not result in automatic acceptance. The package will then undergo a formal review and recommendations for acceptance regarding other Bioconductor standards will be addressed.
[x] My package addresses statistical or bioinformatic issues related to the analysis and comprehension of high throughput genomic data.
[x] I am committed to the long-term maintenance of my package. This includes monitoring the support site for issues that users may have, subscribing to the bioc-devel mailing list to stay aware of developments in the Bioconductor community, responding promptly to requests for updates from the Core team in response to changes in R or underlying software.
[x] I am familiar with the Bioconductor code of conduct and agree to abide by it.
I am familiar with the essential aspects of Bioconductor software management, including:
For questions/help about the submission process, including questions about the output of the automatic reports generated by the SPB (Single Package Builder), please use the #package-submission channel of our Community Slack. Follow the link on the home page of the Bioconductor website to sign up.