Bioconductor / Contributions

Contribute Packages to Bioconductor
131 stars 33 forks source link

hdxmsqc #3311

Closed ococrook closed 2 months ago

ococrook commented 4 months ago

Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor

Confirm the following by editing each check box to '[x]'

I am familiar with the essential aspects of Bioconductor software management, including:

For questions/help about the submission process, including questions about the output of the automatic reports generated by the SPB (Single Package Builder), please use the #package-submission channel of our Community Slack. Follow the link on the home page of the Bioconductor website to sign up.

bioc-issue-bot commented 4 months ago

Hi @ococrook

Thanks for submitting your package. We are taking a quick look at it and you will hear back from us soon.

The DESCRIPTION file for this package is:

Package: hdxmsqc
Type: Package
Title: An R package for quality Control for hydrogen deuterium exchange 
 mass spectrometry experiments
Version: 0.99.0
Authors@R: c(person(family = "Crook", given = "Oliver M.",
                        email = "oliver.crook@stats.ox.ac.uk",
                        comment = c(ORCID = "0000-0001-5669-8506"),
                        role = c("aut", "cre")))
Description: The hdxmsqc package enables us to analyse and visualise the quality
 of HDX-MS experiments. Either as a final quality check before downstream
 analysis and publication or as part of a interative procedure to determine
 the quality of the data. The package builds on the QFeatures and Spectra
 packages to integrate with other mass-spectrometry data.
License: file LICENSE
Encoding: UTF-8
LazyData: false
Depends: R(>= 4.3), QFeatures, S4Vectors, Spectra
Imports: 
        dplyr,
        tidyr,
        ggplot2,
        BiocStyle,
        knitr,
        methods,
        grDevices,
        stats,
        MsCoreUtils
Suggests: 
        RColorBrewer,
        pheatmap,
        MASS,
        patchwork,
        testthat
VignetteBuilder: knitr
Roxygen: list(markdown=TRUE)
RoxygenNote: 7.2.3
biocViews: QualityControl,DataImport, Proteomics, MassSpectrometry, Metabolomics
BugReports: https://github.com/ococrook/hdxmsqc/issues
URL: http://github.com/ococrook/hdxmsqc
Language: en-US
bioc-issue-bot commented 4 months ago

Your package has been added to git.bioconductor.org to continue the pre-review process. A build report will be posted shortly. Please fix any ERROR and WARNING in the build report before a reviewer is assigned or provide a justification on why you feel the ERROR or WARNING should be granted an exception.

IMPORTANT: Please read this documentation for setting up remotes to push to git.bioconductor.org. All changes should be pushed to git.bioconductor.org moving forward. It is required to push a version bump to git.bioconductor.org to trigger a new build report.

Bioconductor utilized your github ssh-keys for git.bioconductor.org access. To manage keys and future access you may want to active your Bioconductor Git Credentials Account

bioc-issue-bot commented 4 months ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Single Package Builder.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Single Package Builder: Linux (Ubuntu 22.04.3 LTS): hdxmsqc_0.99.0.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/hdxmsqc to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

lshep commented 3 months ago

Please fix build report ERROR's before a reviewer will be assigned for in depth review.

ococrook commented 3 months ago

Thanks will try and fix this oddly I have two issues 1) I cant reproduce the ERROR locally 2) I'm getting access denied fetching from the bioconductor git repository

lshep commented 3 months ago

Everything is correct on our configuration. Maybe add a new ssh key to the account? Can you show the full error

bioc-issue-bot commented 3 months ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 72ddb3ef25a34f9b5a8d10200aa124be136efd3a

ococrook commented 3 months ago

Added a new key not sure what happened to the old one.

bioc-issue-bot commented 3 months ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Single Package Builder.

On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Single Package Builder: Linux (Ubuntu 22.04.3 LTS): hdxmsqc_0.99.1.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/hdxmsqc to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 3 months ago

A reviewer has been assigned to your package for an indepth review. Please respond accordingly to any further comments from the reviewer.

lshep commented 3 months ago

inst

man

vignette

@lgatto any additional comments?

bioc-issue-bot commented 3 months ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 48f2e9562fec18801ec9c979f673e260dd96486a

bioc-issue-bot commented 3 months ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Single Package Builder.

On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Single Package Builder: Linux (Ubuntu 22.04.3 LTS): hdxmsqc_0.99.2.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/hdxmsqc to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 3 months ago

Received a valid push on git.bioconductor.org; starting a build for commit id: cfddc4754bdb6d90bb597d78ee267451bd8222ab

ococrook commented 3 months ago

Thanks @lshep I made those changes, the most recent version should have the correct version update - with an updates NEWS file too.

I didn't supressMessages on all the packages just the ones with a lot of output. Let me know if you would like any other changes.

bioc-issue-bot commented 3 months ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Single Package Builder.

On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Single Package Builder: Linux (Ubuntu 22.04.3 LTS): hdxmsqc_0.99.3.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/hdxmsqc to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 2 months ago

Your package has been accepted. It will be added to the Bioconductor nightly builds.

Thank you for contributing to Bioconductor!

Reviewers for Bioconductor packages are volunteers from the Bioconductor community. If you are interested in becoming a Bioconductor package reviewer, please see Reviewers Expectations.

lshep commented 2 months ago

The default branch of your GitHub repository has been added to Bioconductor's git repository as branch devel.

To use the git.bioconductor.org repository, we need an 'ssh' key to associate with your github user name. If your GitHub account already has ssh public keys (https://github.com/ococrook.keys is not empty), then no further steps are required. Otherwise, do the following:

  1. Add an SSH key to your github account
  2. Submit your SSH key to Bioconductor

See further instructions at

https://bioconductor.org/developers/how-to/git/

for working with this repository. See especially

https://bioconductor.org/developers/how-to/git/new-package-workflow/ https://bioconductor.org/developers/how-to/git/sync-existing-repositories/

to keep your GitHub and Bioconductor repositories in sync.

Your package will be included in the next nigthly 'devel' build (check-out from git at about 6 pm Eastern; build completion around 2pm Eastern the next day) at

https://bioconductor.org/checkResults/

(Builds sometimes fail, so ensure that the date stamps on the main landing page are consistent with the addition of your package). Once the package builds successfully, you package will be available for download in the 'Devel' version of Bioconductor using BiocManager::install("hdxmsqc"). The package 'landing page' will be created at

https://bioconductor.org/packages/hdxmsqc

If you have any questions, please contact the bioc-devel mailing list (https://stat.ethz.ch/mailman/listinfo/bioc-devel); this issue will not be monitored further.