Open samWieczorek opened 3 months ago
Hi @samWieczorek
Thanks for submitting your package. We are taking a quick look at it and you will hear back from us soon.
The DESCRIPTION file for this package is:
Package: omXplore
Type: Package
Title: Vizualization tools for 'omics' datasets with R
Version: 0.99.1
Authors@R:
c(person(given = "Samuel",
family = "Wieczorek",
email = "samuel.wieczorek@cea.fr",
role = c("aut","cre"),
comment = c(ORCID="0000-0002-5016-1203")),
person(given = "Thomas",
family ="Burger",
email = "thomas.burger@cea.fr",
role = c("aut")),
person(given = "Enora",
family = "Fremy",
email = "enora.fremy@cea.fr",
role = c("ctb"))
)
Description: This package contains a collection of functions (written as
shiny modules) for the visualisation and the statistical analysis of omics
data. These plots can be displayed individually or embedded in a global
Shiny module.
Additionaly, it is possible to integrate third party modules to the main
interface of the package omXplore.
License: Artistic-2.0
Depends:
R (>= 4.3.0), methods
Imports:
shiny,
MSnbase,
PSMatch,
SummarizedExperiment,
MultiAssayExperiment,
shinyBS,
shinyjs,
shinyjqui,
DT,
RColorBrewer,
gplots,
highcharter,
visNetwork,
tibble,
grDevices,
stats,
utils,
htmlwidgets,
vioplot,
graphics,
FactoMineR,
dendextend,
dplyr,
factoextra,
tidyr
Suggests:
knitr,
rmarkdown,
BiocStyle,
testthat,
Matrix,
graph
biocViews:
Software,
ShinyApps,
MassSpectrometry,
DataRepresentation,
GUI,
QualityControl
NeedsCompilation: no
Collate:
'Infos_adjacencyMatrix.R'
'Prostar_1x.R'
'convert_to_mae.R'
'doc-data.R'
'external_apps_examples.R'
'get_pep_prot_CC.R'
'mae_accessors.R'
'metacell_utils.R'
'mod_colorLegend.R'
'mod_explore_graphs.R'
'modules.R'
'omXplore_cc.R'
'omXplore_corrmatrix.R'
'omXplore_density.R'
'omXplore_format_DT.R'
'omXplore_heatmap.R'
'omXplore_intensity.R'
'omXplore_pca.R'
'omXplore_plots_tracking.R'
'omXplore_tabExplorer.R'
'omXplore_variance.R'
'omXplore_view_dataset.R'
'palette.R'
'plot_boxplot.R'
'plot_heatmap.R'
'plot_pca.R'
'plot_violin.R'
'utils.R'
'zzz.R'
RoxygenNote: 7.3.1
Packaged: 2017-10-13 11:13:04 UTC; sw175264
Encoding: UTF-8
LazyData: false
URL: https://github.com/prostarproteomics/omXplore, https://prostarproteomics.github.io/omXplore/
BugReports: https://github.com/prostarproteomics/omXplore/issues
Roxygen: list(markdown = TRUE)
VignetteBuilder: knitr
[ ] You have many additional non standard directories and listings from a base level package. Can this be cleaned up and pared down to just package code and necessities and additional material moved to a different branch?
[ ] What are the files in inst/md
should these be moved to standard
vignettes?
[ ] There is a single image file in inst/www
is it needed or can it be condensed
someplace else?
[ ] How is the data in inst/extdata
used? There is no documentation on its
creation. Please provide relavent informatoni in inst/script
on how this data
was generated and any source/licensing information.
[ ] Is the doc directory needed for pkgdown?
[ ] In the vignette can you please explain and compare how this package differs from already existing visualiztion packages for omics data that exist in Bioconductor.
[ ] Please be advised when I build the package I get the following
R CMD build omXplore
* checking for file 'omXplore/DESCRIPTION' ... OK
* preparing 'omXplore':
* checking DESCRIPTION meta-information ... OK
* installing the package to build vignettes
* creating vignettes ... OK
* checking for LF line-endings in source and make files and shell scripts
* checking for empty or unneeded directories
* looking to see if a 'data/datalist' file should be added
* building 'omXplore_0.99.1.tar.gz'
Warning in utils::tar(filepath, pkgname, compression = compression, compression_level = 9L, :
storing paths of more than 100 bytes is not portable:
'omXplore/docs/deps/bootstrap-5.3.1/fonts/memQYaGs126MiZpBA-UFUIcVXSCEkx2cmqvXlWq8tWZ0Pw86hd0Rk0ZjaVQ.woff'
Warning in utils::tar(filepath, pkgname, compression = compression, compression_level = 9L, :
storing paths of more than 100 bytes is not portable:
'omXplore/docs/deps/bootstrap-5.3.1/fonts/memQYaGs126MiZpBA-UFUIcVXSCEkx2cmqvXlWq8tWZ0Pw86hd0Rk5hkWVAexg.woff'
Warning in utils::tar(filepath, pkgname, compression = compression, compression_level = 9L, :
storing paths of more than 100 bytes is not portable:
'omXplore/docs/deps/bootstrap-5.3.1/fonts/memQYaGs126MiZpBA-UFUIcVXSCEkx2cmqvXlWq8tWZ0Pw86hd0Rk5hkaVQ.woff'
Warning in utils::tar(filepath, pkgname, compression = compression, compression_level = 9L, :
storing paths of more than 100 bytes is not portable:
'omXplore/docs/deps/bootstrap-5.3.1/fonts/memQYaGs126MiZpBA-UFUIcVXSCEkx2cmqvXlWq8tWZ0Pw86hd0Rk8ZkWVAexg.woff'
Warning in utils::tar(filepath, pkgname, compression = compression, compression_level = 9L, :
storing paths of more than 100 bytes is not portable:
'omXplore/docs/deps/bootstrap-5.3.1/fonts/memQYaGs126MiZpBA-UFUIcVXSCEkx2cmqvXlWq8tWZ0Pw86hd0Rk8ZkaVQ.woff'
Warning in utils::tar(filepath, pkgname, compression = compression, compression_level = 9L, :
storing paths of more than 100 bytes is not portable:
'omXplore/docs/deps/bootstrap-5.3.1/fonts/memQYaGs126MiZpBA-UFUIcVXSCEkx2cmqvXlWq8tWZ0Pw86hd0Rk_RkaVQ.woff'
Warning in utils::tar(filepath, pkgname, compression = compression, compression_level = 9L, :
storing paths of more than 100 bytes is not portable:
'omXplore/docs/deps/bootstrap-5.3.1/fonts/memQYaGs126MiZpBA-UFUIcVXSCEkx2cmqvXlWq8tWZ0Pw86hd0RkxhjaVQ.woff'
Warning in utils::tar(filepath, pkgname, compression = compression, compression_level = 9L, :
storing paths of more than 100 bytes is not portable:
'omXplore/docs/deps/bootstrap-5.3.1/fonts/memQYaGs126MiZpBA-UFUIcVXSCEkx2cmqvXlWq8tWZ0Pw86hd0RkyFjWVAexg.woff'
Warning in utils::tar(filepath, pkgname, compression = compression, compression_level = 9L, :
storing paths of more than 100 bytes is not portable:
'omXplore/docs/deps/bootstrap-5.3.1/fonts/memQYaGs126MiZpBA-UFUIcVXSCEkx2cmqvXlWq8tWZ0Pw86hd0RkyFjaVQ.woff'
Warning in utils::tar(filepath, pkgname, compression = compression, compression_level = 9L, :
storing paths of more than 100 bytes is not portable:
'omXplore/docs/deps/bootstrap-5.3.1/fonts/memSYaGs126MiZpBA-UvWbX2vVnXBbObj2OVZyOOSr4dVJWUgsg-1x4gaVQ.woff'
Warning in utils::tar(filepath, pkgname, compression = compression, compression_level = 9L, :
storing paths of more than 100 bytes is not portable:
'omXplore/docs/deps/bootstrap-5.3.1/fonts/memSYaGs126MiZpBA-UvWbX2vVnXBbObj2OVZyOOSr4dVJWUgsg-1y4k.woff'
Warning in utils::tar(filepath, pkgname, compression = compression, compression_level = 9L, :
storing paths of more than 100 bytes is not portable:
'omXplore/docs/deps/bootstrap-5.3.1/fonts/memSYaGs126MiZpBA-UvWbX2vVnXBbObj2OVZyOOSr4dVJWUgsgH1y4k.woff'
Warning in utils::tar(filepath, pkgname, compression = compression, compression_level = 9L, :
storing paths of more than 100 bytes is not portable:
'omXplore/docs/deps/bootstrap-5.3.1/fonts/memSYaGs126MiZpBA-UvWbX2vVnXBbObj2OVZyOOSr4dVJWUgshZ1y4k.woff'
Warning in utils::tar(filepath, pkgname, compression = compression, compression_level = 9L, :
storing paths of more than 100 bytes is not portable:
'omXplore/docs/deps/bootstrap-5.3.1/fonts/memSYaGs126MiZpBA-UvWbX2vVnXBbObj2OVZyOOSr4dVJWUgsiH0B4gaVQ.woff'
Warning in utils::tar(filepath, pkgname, compression = compression, compression_level = 9L, :
storing paths of more than 100 bytes is not portable:
'omXplore/docs/deps/bootstrap-5.3.1/fonts/memSYaGs126MiZpBA-UvWbX2vVnXBbObj2OVZyOOSr4dVJWUgsiH0C4k.woff'
Warning in utils::tar(filepath, pkgname, compression = compression, compression_level = 9L, :
storing paths of more than 100 bytes is not portable:
'omXplore/docs/deps/bootstrap-5.3.1/fonts/memSYaGs126MiZpBA-UvWbX2vVnXBbObj2OVZyOOSr4dVJWUgsjZ0B4gaVQ.woff'
Warning in utils::tar(filepath, pkgname, compression = compression, compression_level = 9L, :
storing paths of more than 100 bytes is not portable:
'omXplore/docs/deps/bootstrap-5.3.1/fonts/memSYaGs126MiZpBA-UvWbX2vVnXBbObj2OVZyOOSr4dVJWUgsjZ0C4k.woff'
Warning in utils::tar(filepath, pkgname, compression = compression, compression_level = 9L, :
storing paths of more than 100 bytes is not portable:
'omXplore/docs/deps/bootstrap-5.3.1/fonts/memSYaGs126MiZpBA-UvWbX2vVnXBbObj2OVZyOOSr4dVJWUgsjr0C4k.woff'
R CMD check
R CMD check omXplore_0.99.1.tar.gz
Tarballs are only required to store paths of up to 100 bytes and cannot store those of more than 256 bytes, with restrictions including to 100 bytes for the final component. See section 'Package structure' in the 'Writing R Extensions' manual.
Status: 3 NOTEs See '/home/lorikern/PkgReview/PreReview/omXplore.Rcheck/00check.log' for details.
I have cleand and update my package omXplore with your advices
many additional non standard directories and listings from a base level package. Can this be cleaned up and pared down to just package code and necessities and additional material moved to a different branch?
unnecessary directories and listings have been deleted
What are the files in inst/md should these be moved to standard vignettes?
Not necessary => deleted
There is a single image file in inst/www is it needed or can it be condensed someplace else?
Not necessary => deleted
How is the data in inst/extdata used? There is no documentation on its creation. Please provide relavent informatoni in inst/script on how this data was generated and any source/licensing information.
The two *.png files have been moved to inst/images
Is the doc directory needed for pkgdown?
Yes but I moved it in the gh-pages branch of omXplore
In the vignette can you please explain and compare how this package differs from already existing visualiztion packages for omics data that exist in Bioconductor.
Done (in Introduction and Features section)
Hope that these updates are sufficient. Please let me know if I have to do anything else
I'm still seeing a doc directory and _pkgdown.yml in the main branch rather than in gh-pages as indicated when I do a fresh git clone ?
Do not know what happened. Must be ok now.
Your package has been added to git.bioconductor.org to continue the pre-review process. A build report will be posted shortly. Please fix any ERROR and WARNING in the build report before a reviewer is assigned or provide a justification on why you feel the ERROR or WARNING should be granted an exception.
IMPORTANT: Please read this documentation for setting up remotes to push to git.bioconductor.org. All changes should be pushed to git.bioconductor.org moving forward. It is required to push a version bump to git.bioconductor.org to trigger a new build report.
Bioconductor utilized your github ssh-keys for git.bioconductor.org access. To manage keys and future access you may want to active your Bioconductor Git Credentials Account
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Single Package Builder.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
The following are build products from R CMD build on the Single Package Builder: Linux (Ubuntu 22.04.3 LTS): omXplore_0.99.2.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/omXplore
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 053cd207de0758b2c5fce050415a701a47fe3356
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Single Package Builder.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
The following are build products from R CMD build on the Single Package Builder: Linux (Ubuntu 22.04.3 LTS): omXplore_0.99.3.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/omXplore
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: a4f9d992d4b454a6b26c42a8517087e4def6d80b
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Single Package Builder.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
The following are build products from R CMD build on the Single Package Builder: Linux (Ubuntu 22.04.3 LTS): omXplore_0.99.4.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/omXplore
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 68962fab00d0652729293bf056ec9205dbd385f7
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Single Package Builder.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
The following are build products from R CMD build on the Single Package Builder: Linux (Ubuntu 22.04.3 LTS): omXplore_0.99.5.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/omXplore
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: a756c91d30a20129edd5d764f9b097aefb28cace
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Single Package Builder.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details.
The following are build products from R CMD build on the Single Package Builder: Linux (Ubuntu 22.04.3 LTS): omXplore_0.99.6.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/omXplore
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
A reviewer has been assigned to your package for an indepth review. Please respond accordingly to any further comments from the reviewer.
Is this really ready to go?
plot_violin.R:#' @param conds xxx
plot_violin.R:#' @param subset xxx
plot_violin.R:#' @param pal.name xxx
Prostar_1x.R:#' @title xxxx
Prostar_1x.R:#' @description xxx
utils.R:#' @title xxx
utils.R:#' @description xxx
utils.R:#' @title xxx
utils.R:#' @description xxx
utils.R:#' @return A `character(1)` with the name of the package or xxx
utils.R:#' @param width xxx
utils.R:#' @param height xxx
utils.R:#' xxxx
utils.R:#' xxxx
Received a valid push on git.bioconductor.org; starting a build for commit id: 59dbd4625f43a16f3de5cd833225b5997bc370cb
Oupss, sorry. I have forgotten some comments. Fixed
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Single Package Builder.
On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
The following are build products from R CMD build on the Single Package Builder: Linux (Ubuntu 22.04.3 LTS): omXplore_0.99.7.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/omXplore
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: ad6ba1e094c1d00c8302deb256ca3b716c2a0dfe
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Single Package Builder.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details.
The following are build products from R CMD build on the Single Package Builder: Linux (Ubuntu 22.04.3 LTS): omXplore_0.99.8.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/omXplore
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor
Confirm the following by editing each check box to '[x]'
[x ] I understand that by submitting my package to Bioconductor, the package source and all review commentary are visible to the general public.
[x ] I have read the Bioconductor Package Submission instructions. My package is consistent with the Bioconductor Package Guidelines.
[x ] I understand Bioconductor Package Naming Policy and acknowledge Bioconductor may retain use of package name.
[x ] I understand that a minimum requirement for package acceptance is to pass R CMD check and R CMD BiocCheck with no ERROR or WARNINGS. Passing these checks does not result in automatic acceptance. The package will then undergo a formal review and recommendations for acceptance regarding other Bioconductor standards will be addressed.
[x ] My package addresses statistical or bioinformatic issues related to the analysis and comprehension of high throughput genomic data.
[x ] I am committed to the long-term maintenance of my package. This includes monitoring the support site for issues that users may have, subscribing to the bioc-devel mailing list to stay aware of developments in the Bioconductor community, responding promptly to requests for updates from the Core team in response to changes in R or underlying software.
[x ] I am familiar with the Bioconductor code of conduct and agree to abide by it.
I am familiar with the essential aspects of Bioconductor software management, including:
For questions/help about the submission process, including questions about the output of the automatic reports generated by the SPB (Single Package Builder), please use the #package-submission channel of our Community Slack. Follow the link on the home page of the Bioconductor website to sign up.