Bioconductor / Contributions

Contribute Packages to Bioconductor
131 stars 33 forks source link

crupR submission #3413

Open akbariomgba opened 1 month ago

akbariomgba commented 1 month ago

Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor

Confirm the following by editing each check box to '[x]'

I am familiar with the essential aspects of Bioconductor software management, including:

For questions/help about the submission process, including questions about the output of the automatic reports generated by the SPB (Single Package Builder), please use the #package-submission channel of our Community Slack. Follow the link on the home page of the Bioconductor website to sign up.

bioc-issue-bot commented 1 month ago

Hi @akbariomgba

Thanks for submitting your package. We are taking a quick look at it and you will hear back from us soon.

The DESCRIPTION file for this package is:

Package: crupR
Type: Package
Title: an R package to predict condition-specific enhancers from ChIP-seq data
Version: 0.99.0
Authors@R: c(
   person("Persia", "Akbari Omgba", email = "omgba@molgen.mpg.de", role = c("cre")),
   person("Verena", "Laupert", email = "verena.laupert@bayer.com", role = c("aut")),
   person("Martin", "Vingron", email = "vingron@molgen.ppg.com", role = c("aut")))
Description: An R package offers a workflow to predict condition-specific enhancers from ChIP-seq data.
    The prediction of regulatory units is done in four main Steps:
    Step 1 is the normalization of the ChIP-seq counts.
    Step 2 is the actual prediction of active enhancers bin-wise on the whole genome.
    Step 3 is the condition-specific clustering of the putative active enhancers.
    Step 4 is the search for possible target genes of the condition-specific clusters using RNA-seq counts.
License: GPL-3
Encoding: UTF-8
LazyData: false
Imports: 
    BSgenome.Mmusculus.UCSC.mm10,
    BSgenome.Mmusculus.UCSC.mm9,
    BSgenome.Hsapiens.UCSC.hg19,
    BSgenome.Hsapiens.UCSC.hg38,
    bamsignals,
    Rsamtools,
    GenomicRanges,
    preprocessCore,
    randomForest,
    rtracklayer,
    GenomeInfoDb,
    S4Vectors,
    parallel,
    ggplot2,
    matrixStats,
    dplyr,
    IRanges,
    GenomicAlignments,
    GenomicFeatures,
    TxDb.Mmusculus.UCSC.mm10.knownGene,
    TxDb.Mmusculus.UCSC.mm9.knownGene,
    TxDb.Hsapiens.UCSC.hg19.knownGene,
    TxDb.Hsapiens.UCSC.hg38.knownGene,
    BSgenome,
    reshape2,
    magrittr,
    stats,
    utils,
    grDevices
Depends:
    R (>= 4.2.0)
Suggests: testthat, BiocStyle, knitr, rmarkdown
biocViews:
    DifferentialPeakCalling,
    GeneTarget,
    FunctionalPrediction,
    HistoneModification,
    PeakDetection
BiocType: Software
URL: https://github.com/akbariomgba/crupR
RoxygenNote: 7.2.3
VignetteBuilder: knitr
lshep commented 1 month ago

I currently cannot build the package

R CMD build crupR 
* checking for file 'crupR/DESCRIPTION' ... OK
* preparing 'crupR':
* checking DESCRIPTION meta-information ... OK
* installing the package to build vignettes
* creating vignettes ... ERROR
--- re-building ‘crupR-vignette.Rmd’ using rmarkdown

Quitting from lines  at lines 167-168 [unnamed-chunk-11] (crupR-vignette.Rmd)
Error: processing vignette 'crupR-vignette.Rmd' failed with diagnostics:
object 'C_pKS2' not found
--- failed re-building ‘crupR-vignette.Rmd’

SUMMARY: processing the following file failed:
  ‘crupR-vignette.Rmd’

Error: Vignette re-building failed.
Execution halted
akbariomgba commented 1 month ago

Hello, When I am trying to build the package it runs w/o any errors, so I have trouble finding the bug. Could you please provide your session info or other information about your environment such that I can replicate it?

lshep commented 1 month ago
R CMD build crupR 
* checking for file 'crupR/DESCRIPTION' ... OK
* preparing 'crupR':
* checking DESCRIPTION meta-information ... OK
* installing the package to build vignettes
* creating vignettes ... ERROR
--- re-building ‘crupR-vignette.Rmd’ using rmarkdown

Quitting from lines 167-168 [unnamed-chunk-11] (crupR-vignette.Rmd)
Error: processing vignette 'crupR-vignette.Rmd' failed with diagnostics:
object 'C_pKS2' not found
--- failed re-building ‘crupR-vignette.Rmd’

SUMMARY: processing the following file failed:
  ‘crupR-vignette.Rmd’

Error: Vignette re-building failed.
Execution halted

My sessionInfo()

Bioconductor version 3.20 (BiocManager 1.30.23), R 4.4.0 Patched (2024-04-30
  r86503)
> sessionInfo()
R version 4.4.0 Patched (2024-04-30 r86503)
Platform: x86_64-pc-linux-gnu
Running under: Ubuntu 22.04.4 LTS

Matrix products: default
BLAS:   /home/lorikern/R-Installs/bin/R-4-4-branch/lib/libRblas.so 
LAPACK: /usr/lib/x86_64-linux-gnu/lapack/liblapack.so.3.10.0

locale:
 [1] LC_CTYPE=en_US.UTF-8       LC_NUMERIC=C              
 [3] LC_TIME=en_US.UTF-8        LC_COLLATE=en_US.UTF-8    
 [5] LC_MONETARY=en_US.UTF-8    LC_MESSAGES=en_US.UTF-8   
 [7] LC_PAPER=en_US.UTF-8       LC_NAME=C                 
 [9] LC_ADDRESS=C               LC_TELEPHONE=C            
[11] LC_MEASUREMENT=en_US.UTF-8 LC_IDENTIFICATION=C       

time zone: America/New_York
tzcode source: system (glibc)

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base     

other attached packages:
[1] praise_1.0.0        BiocManager_1.30.23

loaded via a namespace (and not attached):
[1] compiler_4.4.0
akbariomgba commented 1 month ago

Thank you for the session info. I was able to reproduce the bug and fixed it. The repo has been updated.

I apologize for the inconvenience.

bioc-issue-bot commented 1 month ago

Your package has been added to git.bioconductor.org to continue the pre-review process. A build report will be posted shortly. Please fix any ERROR and WARNING in the build report before a reviewer is assigned or provide a justification on why you feel the ERROR or WARNING should be granted an exception.

IMPORTANT: Please read this documentation for setting up remotes to push to git.bioconductor.org. All changes should be pushed to git.bioconductor.org moving forward. It is required to push a version bump to git.bioconductor.org to trigger a new build report.

Bioconductor utilized your github ssh-keys for git.bioconductor.org access. To manage keys and future access you may want to active your Bioconductor Git Credentials Account

bioc-issue-bot commented 1 month ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Single Package Builder.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details.

The following are build products from R CMD build on the Single Package Builder: Linux (Ubuntu 22.04.3 LTS): crupR_0.99.0.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/crupR to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 4 weeks ago

A reviewer has been assigned to your package for an indepth review. Please respond accordingly to any further comments from the reviewer.

PeteHaitch commented 2 weeks ago

Hi @akbariomgba,

I tried building crupR locally (MacBook Air M1 with 16 GB RAM, full session info below) and hit the following error when building the vignette:

R_ENVIRON_USER=~/.Renviron.bioc R CMD build .
* checking for file ‘./DESCRIPTION’ ... OK
* preparing ‘crupR’:
* checking DESCRIPTION meta-information ... OK
* installing the package to build vignettes
* creating vignettes ... ERROR
--- re-building ‘crupR-vignette.Rmd’ using rmarkdown

Quitting from lines 123-125 [run-getEnhancers] (crupR-vignette.Rmd)
Error: processing vignette 'crupR-vignette.Rmd' failed with diagnostics:
vector memory limit of 16.0 Gb reached, see mem.maxVSize()
--- failed re-building ‘crupR-vignette.Rmd’

SUMMARY: processing the following file failed:
  ‘crupR-vignette.Rmd’

Error: Vignette re-building failed.
Execution halted

The same error occurs if I install the package (without vignettes) and then step through the vignette code.

What systems have you built and tested the package on?


Session info

> sessionInfo()
R version 4.4.0 (2024-04-24)
Platform: aarch64-apple-darwin20
Running under: macOS Sonoma 14.5

Matrix products: default
BLAS:   /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/libBLAS.dylib 
LAPACK: /Library/Frameworks/R.framework/Versions/4.4-arm64/Resources/lib/libRlapack.dylib;  LAPACK version 3.12.0

locale:
[1] en_US.UTF-8/en_US.UTF-8/en_US.UTF-8/C/en_US.UTF-8/en_US.UTF-8

time zone: Australia/Melbourne
tzcode source: internal

attached base packages:
[1] stats     graphics  grDevices datasets  utils     methods   base     

other attached packages:
[1] crupR_0.99.0

loaded via a namespace (and not attached):
 [1] tidyselect_1.2.1                          BSgenome.Mmusculus.UCSC.mm9_1.4.0        
 [3] dplyr_1.1.4                               blob_1.2.4                               
 [5] Biostrings_2.73.1                         bitops_1.0-7                             
 [7] fastmap_1.2.0                             RCurl_1.98-1.14                          
 [9] GenomicAlignments_1.41.0                  bamsignals_1.37.0                        
[11] XML_3.99-0.16.1                           lifecycle_1.0.4                          
[13] KEGGREST_1.45.0                           TxDb.Hsapiens.UCSC.hg38.knownGene_3.18.0 
[15] RSQLite_2.3.7                             magrittr_2.0.3                           
[17] compiler_4.4.0                            rlang_1.1.4                              
[19] tools_4.4.0                               utf8_1.2.4                               
[21] yaml_2.3.8                                BSgenome.Hsapiens.UCSC.hg38_1.4.5        
[23] rtracklayer_1.65.0                        S4Arrays_1.5.1                           
[25] bit_4.0.5                                 curl_5.2.1                               
[27] DelayedArray_0.31.1                       plyr_1.8.9                               
[29] abind_1.4-5                               BiocParallel_1.39.0                      
[31] BiocGenerics_0.51.0                       grid_4.4.0                               
[33] stats4_4.4.0                              preprocessCore_1.67.0                    
[35] fansi_1.0.6                               colorspace_2.1-0                         
[37] ggplot2_3.5.1                             scales_1.3.0                             
[39] SummarizedExperiment_1.35.0               cli_3.6.2                                
[41] crayon_1.5.2                              generics_0.1.3                           
[43] httr_1.4.7                                reshape2_1.4.4                           
[45] rjson_0.2.21                              DBI_1.2.3                                
[47] cachem_1.1.0                              stringr_1.5.1                            
[49] zlibbioc_1.51.1                           parallel_4.4.0                           
[51] AnnotationDbi_1.67.0                      BiocManager_1.30.23                      
[53] XVector_0.45.0                            restfulr_0.0.15                          
[55] matrixStats_1.3.0                         vctrs_0.6.5                              
[57] Matrix_1.7-0                              jsonlite_1.8.8                           
[59] IRanges_2.39.0                            S4Vectors_0.43.0                         
[61] bit64_4.0.5                               GenomicFeatures_1.57.0                   
[63] glue_1.7.0                                codetools_0.2-20                         
[65] BSgenome.Mmusculus.UCSC.mm10_1.4.3        stringi_1.8.4                            
[67] TxDb.Mmusculus.UCSC.mm10.knownGene_3.10.0 gtable_0.3.5                             
[69] GenomeInfoDb_1.41.1                       BiocIO_1.15.0                            
[71] GenomicRanges_1.57.0                      UCSC.utils_1.1.0                         
[73] munsell_0.5.1                             tibble_3.2.1                             
[75] pillar_1.9.0                              randomForest_4.7-1.1                     
[77] BSgenome.Hsapiens.UCSC.hg19_1.4.3         GenomeInfoDbData_1.2.12                  
[79] BSgenome_1.73.0                           R6_2.5.1                                 
[81] lattice_0.22-6                            Biobase_2.65.0                           
[83] png_0.1-8                                 Rsamtools_2.21.0                         
[85] memoise_2.0.1                             TxDb.Hsapiens.UCSC.hg19.knownGene_3.2.2  
[87] TxDb.Mmusculus.UCSC.mm9.knownGene_3.2.2   renv_1.0.7                               
[89] Rcpp_1.0.12                               SparseArray_1.5.7                        
[91] MatrixGenerics_1.17.0                     pkgconfig_2.0.3 
akbariomgba commented 2 weeks ago

Hi @PeteHaitch ,

I have built and tested the package on linux. I'll try to use a VM to get to the root of the issue.

PeteHaitch commented 2 weeks ago

FYI I've narrowed it down to the line https://github.com/akbariomgba/crupR/blob/a1d30b9825cc552b2ec951fe7f513ffb3335c83d/R/enhancerPrediction.R#L82.

I can try to help further debug the issue on my mac. Any idea what memory usage is required by this function (or others that might use a bit of RAM)?