Open nshen7 opened 5 months ago
Hi @nshen7
Thanks for submitting your package. We are taking a quick look at it and you will hear back from us soon.
The DESCRIPTION file for this package is:
Package: vmrseq
Type: Package
Title: Probabilistic Modeling of Single-cell Methylation Heterogeneity
Version: 0.99.0
Authors@R: person("Ning", "Shen", email = "ning.shen.wk@gmail.com",role = c("aut", "cre"))
Description: High-throughput single-cell measurements of DNA methylation allows studying inter-cellular epigenetic heterogeneity, but this task faces the challenges of sparsity and noise. We present vmrseq, a statistical method that overcomes these challenges and identifies variably methylated regions accurately and robustly.
License: MIT + file LICENSE
Encoding: UTF-8
LazyData: true
RoxygenNote: 7.2.3
biocViews: Software, ImmunoOncology, DNAMethylation, Epigenetics, SingleCell,
Sequencing, WholeGenome
Depends:
R (>= 3.5.0)
Imports:
bumphunter,
dplyr,
BiocParallel,
DelayedArray,
GenomicRanges,
ggplot2,
methods,
tidyr,
locfit,
gamlss.dist,
recommenderlab,
HDF5Array,
data.table,
SummarizedExperiment,
IRanges,
S4Vectors
Suggests:
knitr,
rmarkdown,
testthat (>= 3.0.0)
Config/testthat/edition: 3
VignetteBuilder: knitr
URL: https://github.com/nshen7/vmrseq
BugReports: https://github.com/nshen7/vmrseq/issues
I'm getting the following ERROR when running R CMD check ?
* checking files in 'vignettes' ... OK
* checking examples ... ERROR
Running examples in 'vmrseq-Ex.R' failed
The error most likely occurred in:
> ### Name: HDF5NAdrop2matrix
> ### Title: Coerce a NA-dropped HDF5 matrix back to regular matrix form
> ### where NAs are not dropped to 0.
> ### Aliases: HDF5NAdrop2matrix
>
> ### ** Examples
>
> # load example data
> toy.se <- HDF5Array::loadHDF5SummarizedExperiment(system.file("extdata", "toy", package = "vmrseq"))
>
> # run the function
> HDF5NAdrop2matrix(assays(toy.se)$M_mat)
Error in assays(toy.se) : could not find function "assays"
Calls: HDF5NAdrop2matrix ... <Anonymous> -> is -> as -> .class1 -> as -> .class1
Execution halted
* checking for unstated dependencies in 'tests' ... OK
* checking tests ...
Running ‘testthat.R’
OK
* checking for unstated dependencies in vignettes ... OK
* checking package vignettes ... OK
Could you also please remove the doc directory. These files should be generated interactively when the package is built.
Hi @lshep, I have addressed your comments. Many thanks for reviewing my package!
Your package has been added to git.bioconductor.org to continue the pre-review process. A build report will be posted shortly. Please fix any ERROR and WARNING in the build report before a reviewer is assigned or provide a justification on why you feel the ERROR or WARNING should be granted an exception.
IMPORTANT: Please read this documentation for setting up remotes to push to git.bioconductor.org. All changes should be pushed to git.bioconductor.org moving forward. It is required to push a version bump to git.bioconductor.org to trigger a new build report.
Bioconductor utilized your github ssh-keys for git.bioconductor.org access. To manage keys and future access you may want to active your Bioconductor Git Credentials Account
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Single Package Builder.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
The following are build products from R CMD build on the Single Package Builder: macOS 12.7.1 Monterey: vmrseq_0.99.0.tar.gz Linux (Ubuntu 22.04.3 LTS): vmrseq_0.99.0.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/vmrseq
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: c53eda552ad868b73c1d4808f4995c9c7f25c8e7
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Single Package Builder.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details.
The following are build products from R CMD build on the Single Package Builder: macOS 12.7.1 Monterey: vmrseq_0.99.1.tar.gz Linux (Ubuntu 22.04.3 LTS): vmrseq_0.99.1.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/vmrseq
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
A reviewer has been assigned to your package for an indepth review. Please respond accordingly to any further comments from the reviewer.
@nshen7 - Thank you for submitting to Bioconductor. Please see the initial review of the package below. The required changes must be made while the suggested changes do not have to be (though we strongly encourage them). Comment back here with updates that have been made and when the package is ready for a re-review.
Best, Kayla
Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor
Confirm the following by editing each check box to '[x]'
[x] I understand that by submitting my package to Bioconductor, the package source and all review commentary are visible to the general public.
[x] I have read the Bioconductor Package Submission instructions. My package is consistent with the Bioconductor Package Guidelines.
[x] I understand Bioconductor Package Naming Policy and acknowledge Bioconductor may retain use of package name.
[x] I understand that a minimum requirement for package acceptance is to pass R CMD check and R CMD BiocCheck with no ERROR or WARNINGS. Passing these checks does not result in automatic acceptance. The package will then undergo a formal review and recommendations for acceptance regarding other Bioconductor standards will be addressed.
[x] My package addresses statistical or bioinformatic issues related to the analysis and comprehension of high throughput genomic data.
[x] I am committed to the long-term maintenance of my package. This includes monitoring the support site for issues that users may have, subscribing to the bioc-devel mailing list to stay aware of developments in the Bioconductor community, responding promptly to requests for updates from the Core team in response to changes in R or underlying software.
[x] I am familiar with the Bioconductor code of conduct and agree to abide by it.
I am familiar with the essential aspects of Bioconductor software management, including:
For questions/help about the submission process, including questions about the output of the automatic reports generated by the SPB (Single Package Builder), please use the #package-submission channel of our Community Slack. Follow the link on the home page of the Bioconductor website to sign up.