Bioconductor / Contributions

Contribute Packages to Bioconductor
134 stars 33 forks source link

HiCParser #3498

Open emaigne opened 2 months ago

emaigne commented 2 months ago

This package is a parser to import HiC data into R, from several formats. Most of functions are extracted from our Bioconductor Package HiCDOC (already published). But this package can be cumbersome to install. Our goal is to split the actual HiCDOC package in two : one package to parse the data (a "light" package, that could be used in other packages to import Hi-C data) and a future HiCDOC package, without the definitions of parser functions.

Confirm the following by editing each check box to '[x]'

I am familiar with the essential aspects of Bioconductor software management, including:

For questions/help about the submission process, including questions about the output of the automatic reports generated by the SPB (Single Package Builder), please use the #package-submission channel of our Community Slack. Follow the link on the home page of the Bioconductor website to sign up.

bioc-issue-bot commented 2 months ago

Hi @emaigne

Thanks for submitting your package. We are taking a quick look at it and you will hear back from us soon.

The DESCRIPTION file for this package is:

Package: HiCParser
Type: Package
Title: Parser for HiC data in R
Date: 2024-07-10
Version: 0.99.0
URL: https://github.com/emaigne/HiCParser
BugReports: https://github.com/emaigne/HiCParser/issues
Authors@R: c(
    person("Zytnicki", "Matthias", email = "matthias.zytnicki@inrae.fr", role = c("aut")),
    person("Maigné", "Élise", email = "elise.maigne@inrae.fr", role = c("aut", "cre")))
Description: 
    This package is a parser to import HiC data into R.
    It accepts several type of data: tabular files, Cooler `.cool` or 
    `.mcool` files, Juicer `.hic` files or HiC-Pro `.matrix` and `.bed` files.
    The HiC data can be several files, for several replicates and conditions.
    The data is formated in an InteractionSet object.
License: LGPL
Encoding: UTF-8
Roxygen: list(markdown = TRUE)
RoxygenNote: 7.3.2
LazyData: true
biocViews: 
    Software, HiC, DataImport
Imports: 
    data.table,
    InteractionSet,
    GenomicRanges,
    SummarizedExperiment,
    Rcpp (>= 1.0.12),
    S4Vectors,
    gtools,
    pbapply,
    BiocGenerics,
    GenomeInfoDb
LinkingTo: Rcpp
Suggests: 
    rhdf5,
    BiocStyle,
    knitr,
    RefManageR,
    rmarkdown,
    sessioninfo,
    testthat (>= 3.0.0)
Config/testthat/edition: 3
VignetteBuilder: knitr
bioc-issue-bot commented 2 months ago

Your package has been added to git.bioconductor.org to continue the pre-review process. A build report will be posted shortly. Please fix any ERROR and WARNING in the build report before a reviewer is assigned or provide a justification on why you feel the ERROR or WARNING should be granted an exception.

IMPORTANT: Please read this documentation for setting up remotes to push to git.bioconductor.org. All changes should be pushed to git.bioconductor.org moving forward. It is required to push a version bump to git.bioconductor.org to trigger a new build report.

Bioconductor utilized your github ssh-keys for git.bioconductor.org access. To manage keys and future access you may want to active your Bioconductor Git Credentials Account

bioc-issue-bot commented 2 months ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Single Package Builder.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Single Package Builder: macOS 12.7.1 Monterey: HiCParser_0.99.0.tar.gz Linux (Ubuntu 22.04.3 LTS): HiCParser_0.99.0.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/HiCParser to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 2 months ago

A reviewer has been assigned to your package for an indepth review. Please respond accordingly to any further comments from the reviewer.

bioc-issue-bot commented 1 month ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 81efa05e470db94ed81bc21cb2a3cc65ce21b677

bioc-issue-bot commented 1 month ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Single Package Builder.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details.

The following are build products from R CMD build on the Single Package Builder: Linux (Ubuntu 22.04.3 LTS): HiCParser_0.99.1.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/HiCParser to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

emaigne commented 3 weeks ago

Hi @Kayla-Morrell, I hope it's okay for me to follow up on this issue. I corrected the errors a month ago and haven't received any updates since. I'm not sure if I'm supposed to notify you after making the changes? Thanks Elise

Kayla-Morrell commented 1 week ago

@emaigne - Sorry for the delay on a review but thank you for submitting to Bioconductor. Please see the initial review of the package below. The required changes must be made while the suggested changes do not have to be (though we strongly encourage them). Comment back here with updates that have been made and when the package is ready for a re-review.

DESCRIPTION

Data

Vignette

R code

Best, Kayla