Open thsadiq opened 1 month ago
Hi @thsadiq
Thanks for submitting your package. We are taking a quick look at it and you will hear back from us soon.
The DESCRIPTION file for this package is:
Package: scoup
Version: 0.99.0
Date: 2024-07-31
License: GPL (>= 2)
Authors@R: c(person("Hassan", "Sadiq", role=c("aut","cre","cph"),
email="hassan.t.sadiq@gmail.com",
comment=c(ORCID="0000-0003-0192-7134")))
Description: An elaborate population genetics framework that facilitates
straightforward simulation of codon genetic sequences
subjected to different degrees and/or patterns of Darwinian
selection. The evolutionary framework was built upon the
fitness landscape paradigm of Sewall Wright, as popularised
by the mutation-selection model of Halpern and Bruno. This
enabled realistic evolutionary settings of living organisms
to be included seamlessly. For example, an
Ornstein-Uhlenbeck algorithm inspired fitness update
approach is incorporated herein. Otherwise complex
biological processes, such as the effect of the interplay
between genetic drift and mutation on diversifying selection,
may now be investigated with minimal effort.
Frequency-dependent and deterministic selection coefficients
update techniques are also available.
Depends: R (>= 4.4.1), Matrix
Suggests: BiocManager, BiocStyle, bookdown, htmltools, knitr, yaml
VignetteBuilder: knitr
biocViews: Alignment, Classification, ComparativeGenomics, Genetics,
MathematicalBiology, ResearchField, Software, StatisticalMethod,
WorkflowStep
Title: Codon Simulator with Darwinian Selection Modelled as an OU Process
Contact: <hassan.t.sadiq@gmail.com>
URL: https://github.com/thsadiq/scoup
BugReports: https://github.com/thsadiq/scoup/issues
Packaged: 2024-07-31 23:59:59 UTC; hassan
Repository: Bioconductor
Please don't default write to a users working directory. The default should write to a tempdir()
and not getwd()
, this should also likely be set as the default argument value in the function definition. see seqWriter.R where this occurs.
Your package has been added to git.bioconductor.org to continue the pre-review process. A build report will be posted shortly. Please fix any ERROR and WARNING in the build report before a reviewer is assigned or provide a justification on why you feel the ERROR or WARNING should be granted an exception.
IMPORTANT: Please read this documentation for setting up remotes to push to git.bioconductor.org. All changes should be pushed to git.bioconductor.org moving forward. It is required to push a version bump to git.bioconductor.org to trigger a new build report.
Bioconductor utilized your github ssh-keys for git.bioconductor.org access. To manage keys and future access you may want to active your Bioconductor Git Credentials Account
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Single Package Builder.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
The following are build products from R CMD build on the Single Package Builder: macOS 12.7.1 Monterey: scoup_0.99.0.tar.gz Linux (Ubuntu 22.04.3 LTS): scoup_0.99.0.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/scoup
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: dc4f00c0e98288fd3e94025f2bdb77e35aefbd01
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Single Package Builder.
On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
The following are build products from R CMD build on the Single Package Builder: macOS 12.7.1 Monterey: scoup_0.99.1.tar.gz Linux (Ubuntu 22.04.3 LTS): scoup_0.99.1.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/scoup
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 871aefce14a7756fa020a64b55b56c91c634dbd2
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Single Package Builder.
On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
The following are build products from R CMD build on the Single Package Builder: macOS 12.7.1 Monterey: scoup_0.99.2.tar.gz Linux (Ubuntu 22.04.3 LTS): scoup_0.99.2.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/scoup
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: ce30946951bc48fb311931e33dcb5468c6bbcd04
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Single Package Builder.
On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
The following are build products from R CMD build on the Single Package Builder: macOS 12.7.1 Monterey: scoup_0.99.3.tar.gz Linux (Ubuntu 22.04.3 LTS): scoup_0.99.3.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/scoup
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: ccc11170446b828e1b07245266ba87f160ba49dd
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Single Package Builder.
On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
The following are build products from R CMD build on the Single Package Builder: macOS 12.7.1 Monterey: scoup_0.99.4.tar.gz Linux (Ubuntu 22.04.3 LTS): scoup_0.99.4.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/scoup
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 95238abf2181fc22eb89373aa6f229476bdae347
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Single Package Builder.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
The following are build products from R CMD build on the Single Package Builder: Linux (Ubuntu 22.04.3 LTS): scoup_0.99.5.tar.gz macOS 12.7.1 Monterey: scoup_0.99.5.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/scoup
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 1863c5a30ec837a94d207346faeb0783aa72d475
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Single Package Builder.
On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
The following are build products from R CMD build on the Single Package Builder: macOS 12.7.1 Monterey: scoup_0.99.6.tar.gz Linux (Ubuntu 22.04.3 LTS): scoup_0.99.6.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/scoup
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Thanks for the feedback @lshep
tempdir()
as advised.Received a valid push on git.bioconductor.org; starting a build for commit id: a0b5df7c280483ad9dc4173f86a1d0b7492ac471
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Single Package Builder.
On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
The following are build products from R CMD build on the Single Package Builder: macOS 12.7.1 Monterey: scoup_0.99.7.tar.gz Linux (Ubuntu 22.04.3 LTS): scoup_0.99.7.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/scoup
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 90d9b937e5b57b48dca54d4758b2fa3283b4a75e
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Single Package Builder.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details.
The following are build products from R CMD build on the Single Package Builder: macOS 12.7.1 Monterey: scoup_0.99.8.tar.gz Linux (Ubuntu 22.04.3 LTS): scoup_0.99.8.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/scoup
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 81fa894d2eef9ec912a0938418b10e399f591eed
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Single Package Builder.
On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
The following are build products from R CMD build on the Single Package Builder: ERROR before build products produced.
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/scoup
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 445da8c7733a2c8d85403f18575fe7445489084a
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Single Package Builder.
On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
The following are build products from R CMD build on the Single Package Builder: ERROR before build products produced.
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/scoup
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 0d9cb65db3a1c0b1b125c39fca426edbf61e1ed9
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Single Package Builder.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details.
The following are build products from R CMD build on the Single Package Builder: macOS 12.7.1 Monterey: scoup_0.99.11.tar.gz Linux (Ubuntu 22.04.3 LTS): scoup_0.99.11.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/scoup
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: a42260e7c40982d8c563c7e0c4f179a15605cfa7
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Single Package Builder.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details.
The following are build products from R CMD build on the Single Package Builder: macOS 12.7.1 Monterey: scoup_0.99.12.tar.gz Linux (Ubuntu 22.04.3 LTS): scoup_0.99.12.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/scoup
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
A reviewer has been assigned to your package for an indepth review. Please respond accordingly to any further comments from the reviewer.
Thanks @lshep for the progress update. Dear @jianhong I look forward to your feedback.
Dear @jianhong While I await your feedback, based on your previous reviews, I wish to address two issues that I believe might be of concern.
First, use of loops rather than vectorization functions such as apply
, lapply
and sapply
.
Second, absent unit tests for many of the exported functions.
Looking forward to the feedback from your meticulous review.
Thank you for submitting your package to Bioconductor. The package passed check and build. It is in pretty good shape. However there are several things need to be fixed. Please try to answer the comments line by line when you are ready for a second review. Code: Note: please consider; Important: must be addressed.
for
loops present, try to replace them by *apply
funcitons.file.path
to replace paste
is.character/numeric/integer/logical
to replace is(, "character/numeric/integer/logical")
nsynVar
should be non-negative!")'nsynVar
should be non-negative!")'drop=FALSE
to avoid the reduction of dimension for matrices and arrays. Ignore this if using datatable.codonNuc
nonsynonymID
and synonymIDand
into functions?message
to provide the message information.
writeLines
in seqMerger
writeLines(paste0("Simulated sequence was written to file: ",seqFile))
# print( biTree(16,0.01, "{foreground}"))
in biTree.R
.alignsim
.aaGamma
, and aaGauss
nsynVar
should be non-negative!")nsynVar
should be non-negative!")aaSCupdate.discrete
, and alignsim.ou
alignsim.discrete
, alignsim.omega
, and alignsim.ou
seqDframe
, seqMerger
, and seqWriter
sitesim.discrete
, sitesim.omega
, and sitesim.ou
sitesim.omega
, and wUpdate
BiocStyle
?
Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor
Confirm the following by editing each check box to '[x]'
[x] I understand that by submitting my package to Bioconductor, the package source and all review commentary are visible to the general public.
[x] I have read the Bioconductor Package Submission instructions. My package is consistent with the Bioconductor Package Guidelines.
[x] I understand Bioconductor Package Naming Policy and acknowledge Bioconductor may retain use of package name.
[x] I understand that a minimum requirement for package acceptance is to pass R CMD check and R CMD BiocCheck with no ERROR or WARNINGS. Passing these checks does not result in automatic acceptance. The package will then undergo a formal review and recommendations for acceptance regarding other Bioconductor standards will be addressed.
[x] My package addresses statistical or bioinformatic issues related to the analysis and comprehension of high throughput genomic data.
[x] I am committed to the long-term maintenance of my package. This includes monitoring the support site for issues that users may have, subscribing to the bioc-devel mailing list to stay aware of developments in the Bioconductor community, responding promptly to requests for updates from the Core team in response to changes in R or underlying software.
[x] I am familiar with the Bioconductor code of conduct and agree to abide by it.
I am familiar with the essential aspects of Bioconductor software management, including:
For questions/help about the submission process, including questions about the output of the automatic reports generated by the SPB (Single Package Builder), please use the #package-submission channel of our Community Slack. Follow the link on the home page of the Bioconductor website to sign up.