Bioconductor / Contributions

Contribute Packages to Bioconductor
135 stars 33 forks source link

DeconvoBuddies #3503

Open lahuuki opened 3 months ago

lahuuki commented 3 months ago

Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor

Confirm the following by editing each check box to '[x]'

I am familiar with the essential aspects of Bioconductor software management, including:

For questions/help about the submission process, including questions about the output of the automatic reports generated by the SPB (Single Package Builder), please use the #package-submission channel of our Community Slack. Follow the link on the home page of the Bioconductor website to sign up.

bioc-issue-bot commented 3 months ago

Hi @lahuuki

Thanks for submitting your package. We are taking a quick look at it and you will hear back from us soon.

The DESCRIPTION file for this package is:

Package: DeconvoBuddies
Title: Helper Functions for LIBD Deconvolution
Version: 0.99.0
Date: 2021-09-29
Authors@R: 
    person(given = "Lousie",
 family = "Huuki-Myers",
 role = c("aut", "cre"),
 email = "lahuuki@gmail.com",
 comment = c(ORCID = "0000-0001-5148-3602"))
Description: Funtions helpful for LIBD deconvolution project. Includes tools for marker finding with mean ratio, expression plotting, and plotting deconvolution results. Working to include DLPFC datasets.
License: Artistic-2.0
URL: https://github.com/lahuuki/DeconvoBuddies
BugReports: https://support.bioconductor.org/t/DeconvoBuddies
biocViews: Software, SingleCell, RNASeq, GeneExpression, Transcriptomics
Encoding: UTF-8
LazyData: true
Roxygen: list(markdown = TRUE)
RoxygenNote: 7.3.2
Imports:
    SingleCellExperiment,
    reshape2,
    purrr,
    stringr,
    dplyr,
    scran,
    rafalib,
    ggplot2,
    matrixStats,
    S4Vectors,
    SummarizedExperiment,
    tibble,
    RColorBrewer,
    grDevices,
    BiocFileCache,
    ExperimentHub,
    AnnotationHub,
    methods,
    spatialLIBD,
    stats,
    graphics,
    utils
Suggests: 
    knitr,
    covr,
    testthat (>= 3.0.0),
    rmarkdown,
    tidyr,
    BiocStyle,
    RefManageR,
    sessioninfo,
    tidyverse,
    BisqueRNA,
    HDF5Array,
    Biobase
Config/testthat/edition: 3
Depends: 
    R (>= 2.10)
VignetteBuilder: knitr
lcolladotor commented 3 months ago

PS This will be a package where both Louise and I will ultimately need Git push permissions on BioC. Thanks in advance!

Similar to #3501

lshep commented 3 months ago

We normally only allow data to be stored on trusted servers and not on dropbox; I see it is programmed to only use dropbox if data is not in ExperimentHub however this package has not yet submitted data to experimenthub. Is the plan to submit the data ? We should probably proceed with that step before advancing farther

lahuuki commented 3 months ago

Hi Lori, We are planning on adding this data to ExperimentHub, we are waiting for publication of the associated paper (we are currently under review). Thanks! -Louise

On Mon, Aug 12, 2024 at 1:06 PM lshep @.***> wrote:

We normally only allow data to be stored on trusted servers and not on dropbox; I see it is programmed to only use dropbox if data is not in ExperimentHub however this package has not yet submitted data to experimenthub. Is the plan to submit the data ? We should probably proceed with that step before advancing farther

— Reply to this email directly, view it on GitHub https://github.com/Bioconductor/Contributions/issues/3503#issuecomment-2284519071, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIXRUENWHJTME3XNGK7WBMDZRDTRLAVCNFSM6AAAAABME3FDAKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBUGUYTSMBXGE . You are receiving this because you were mentioned.Message ID: @.***>

lcolladotor commented 3 months ago

Hi @lshep,

I also edited the help page to fetch_deconvo_data() to highlight what Louise mentioned above https://research.libd.org/DeconvoBuddies/reference/fetch_deconvo_data.html#details-1.

Best, Leo

lshep commented 2 months ago

This really goes against our policy of not having things in Dropbox but we'll move it forward into the next stage. FWIW I get an ERROR when trying to R CMD check. I'll move this forward anyways but something to be aware of and it will have to be cleaned up if it appears on our builders

* checking examples ... ERROR
Running examples in 'DeconvoBuddies-Ex.R' failed
The error most likely occurred in:

> ### Name: est_prop
> ### Title: Test Estimated Cell Type Proportions
> ### Aliases: est_prop
> ### Keywords: datasets
> 
> ### ** Examples
> 
> ## R Note that the `rowSums(est_prop)` is equal to 1,
> ## with a small error tolerance.
> summary(rowSums(est_prop) - 1)
     Min.   1st Qu.    Median      Mean   3rd Qu.      Max. 
-1.11e-16  0.00e+00  0.00e+00 -1.11e-18  0.00e+00  0.00e+00 
> 
> ## You can check this yourself with:
> testthat::expect_equal(rowSums(est_prop), rep(1, 100), ignore_attr = TRUE)
Error: rowSums(est_prop) not equal to rep(1, 100).
names for target but not for current
Execution halted
* checking for unstated dependencies in 'tests' ... OK
* checking tests ...
bioc-issue-bot commented 2 months ago

Your package has been added to git.bioconductor.org to continue the pre-review process. A build report will be posted shortly. Please fix any ERROR and WARNING in the build report before a reviewer is assigned or provide a justification on why you feel the ERROR or WARNING should be granted an exception.

IMPORTANT: Please read this documentation for setting up remotes to push to git.bioconductor.org. All changes should be pushed to git.bioconductor.org moving forward. It is required to push a version bump to git.bioconductor.org to trigger a new build report.

Bioconductor utilized your github ssh-keys for git.bioconductor.org access. To manage keys and future access you may want to active your Bioconductor Git Credentials Account

bioc-issue-bot commented 2 months ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Single Package Builder.

On one or more platforms, the build results were: "skipped, ERROR, TIMEOUT". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Single Package Builder: ERROR before build products produced.

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/DeconvoBuddies to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

lshep commented 1 month ago

The package was Timing out on our system and when I tried locally I was getting an ERROR. Can you please investigate before we assign a reviewer?

lcolladotor commented 1 month ago

Hi Lori,

Based on a recent successful GHA run on winOS, I think that this timeout / error might get resolved once Louise sync's the GitHub files with Bioconductor's git server (we just revisited the instructions for doing this; though if I could also get access to BioC's git server for this package, I'll be able to help directly if needed).

% git push upstream
FATAL: W any packages/DeconvoBuddies l.collado-torres DENIED by fallthru
(or you mis-spelled the reponame)
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

% git remote -v
origin  git@github.com:LieberInstitute/DeconvoBuddies.git (fetch)
origin  git@github.com:LieberInstitute/DeconvoBuddies.git (push)
upstream    git@git.bioconductor.org:packages/DeconvoBuddies.git (fetch)
upstream    git@git.bioconductor.org:packages/DeconvoBuddies.git (push)

Louise will test things on SBP by bumping the version number to 0.99.1.

Best, Leo

lshep commented 1 month ago

@lcolladotor you should now have access as well

bioc-issue-bot commented 1 month ago

Received a valid push on git.bioconductor.org; starting a build for commit id: eca461aca3c0023bb8499284c5bb7c9867b248c0

bioc-issue-bot commented 1 month ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Single Package Builder.

On one or more platforms, the build results were: "skipped, TIMEOUT". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Single Package Builder: ERROR before build products produced.

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/DeconvoBuddies to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

lcolladotor commented 1 month ago

Hi,

Just for context at today's LIBD rstats club session we discussed options for reducing the R CMD build time on this package (and well other packages in general). The recording is available at https://youtu.be/YAeUsKGUmtM. The portion about DeconvoBuddies starts at 27:10.

Best, Leo

bioc-issue-bot commented 1 month ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 86cd1a0727a04704d34910eab338ccd1e8df26d8

bioc-issue-bot commented 1 month ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Single Package Builder.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Single Package Builder: Linux (Ubuntu 24.04.1 LTS): DeconvoBuddies_0.99.2.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/DeconvoBuddies to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 1 month ago

Received a valid push on git.bioconductor.org; starting a build for commit id: d10a2af1a8f11960573f935e6262c31642112a61

bioc-issue-bot commented 1 month ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Single Package Builder.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Single Package Builder: Linux (Ubuntu 24.04.1 LTS): DeconvoBuddies_0.99.4.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/DeconvoBuddies to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 1 month ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 49e7f85cccc1be0c16d417db001aadf315acc81a

bioc-issue-bot commented 1 month ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Single Package Builder.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Single Package Builder: Linux (Ubuntu 24.04.1 LTS): DeconvoBuddies_0.99.5.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/DeconvoBuddies to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 1 month ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 7a42139af7e5b629983f09ad8dd56d25daa651bf

bioc-issue-bot commented 1 month ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Single Package Builder.

On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Single Package Builder: Linux (Ubuntu 24.04.1 LTS): DeconvoBuddies_0.99.6.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/DeconvoBuddies to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

lcolladotor commented 1 month ago

This one https://github.com/Bioconductor/Contributions/issues/3503#issuecomment-2437778885 seems like a false alarm for a warning, no?

===============================

 BiocCheckGitClone('DeconvoBuddies')

===============================

 BiocCheck v1.41.17 results 
 0 ERRORS |  0 WARNINGS |  0 NOTES
===============================

 R CMD CHECK

===============================

* DONE

Status: 1 NOTE
===============================

 BiocCheck('DeconvoBuddies_0.99.6.tar.gz')

===============================

 BiocCheck v1.41.17 results 
 0 ERRORS |  0 WARNINGS |  7 NOTES
bioc-issue-bot commented 1 month ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 3a8e30d6cf5372fff2a46d6e21121c3640f432b8

bioc-issue-bot commented 1 month ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Single Package Builder.

On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Single Package Builder: Linux (Ubuntu 24.04.1 LTS): DeconvoBuddies_0.99.7.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/DeconvoBuddies to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 1 month ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 87e346f88975ae86c4560ab46d8969720f1f3994

bioc-issue-bot commented 1 month ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Single Package Builder.

On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Single Package Builder: Linux (Ubuntu 24.04.1 LTS): DeconvoBuddies_0.99.8.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/DeconvoBuddies to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

lahuuki commented 1 month ago

Hi @lshep, I have worked to resolve the errors in the single package builder, its now only throwing WARNING. However when I take a look at the build report I only see Notes and no Warnings recorded, so I am not sure how to address the problem. Could you advise on how to identify/resolve the source of the warning? Thanks!

BiocCheck v1.43.0 results 0 ERRORS | 0 WARNINGS | 5 NOTES

lshep commented 3 weeks ago

yes there is a bug in the SPB for keeping a warning tag; it can be ignored for now

lcolladotor commented 3 weeks ago

Thanks for the confirmation Lori!

Best, Leo

bioc-issue-bot commented 4 days ago

A reviewer has been assigned to your package for an indepth review. Please respond accordingly to any further comments from the reviewer.

lshep commented 4 days ago

Is there an update on the data being made available in Hubs? It really is against Bioconductor policy to let data be retrieved from a Dropbox.