Bioconductor / Contributions

Contribute Packages to Bioconductor
133 stars 33 forks source link

TMSig #3526

Open TylerSagendorf opened 3 weeks ago

TylerSagendorf commented 3 weeks ago

Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor

Confirm the following by editing each check box to '[x]'

I am familiar with the essential aspects of Bioconductor software management, including:

For questions/help about the submission process, including questions about the output of the automatic reports generated by the SPB (Single Package Builder), please use the #package-submission channel of our Community Slack. Follow the link on the home page of the Bioconductor website to sign up.

bioc-issue-bot commented 3 weeks ago

Hi @TylerSagendorf

Thanks for submitting your package. We are taking a quick look at it and you will hear back from us soon.

The DESCRIPTION file for this package is:

Package: TMSig
Type: Package
Title: Tools for Molecular Signatures
Version: 0.99.0
Date: 2024-08-23
Authors@R: 
    c(
      person(given = "Tyler", family = "Sagendorf", 
   email = "tyler.sagendorf@pnnl.gov",
   comment = c(ORCID = "0000-0003-1552-4870"),
   role = c("aut", "cre")),
      person(given = "Di", family = "Wu", role = "ctb"),
      person(given = "Gordon", family = "Smyth", role = "ctb")
    )
Description: The TMSig package contains tools to prepare, analyze, and visualize
    named lists of sets, with an emphasis on molecular signatures (such as gene
    or kinase sets). It includes fast, memory efficient functions to construct
    sparse incidence and similarity matrices and filter, cluster, invert, and 
    decompose sets. Additionally, bubble heatmaps can be created to visualize 
    the results of any differential or molecular signatures analysis.
License: GPL (>= 3)
URL: https://github.com/EMSL-Computing/TMSig
BugReports: https://github.com/EMSL-Computing/TMSig/issues
Encoding: UTF-8
RoxygenNote: 7.3.2
Roxygen: list(markdown = TRUE)
VignetteBuilder: knitr
biocViews: Clustering, GeneSetEnrichment, GraphAndNetwork, Pathways, Visualization
Depends:
    R (>= 4.4.0),
    limma
Imports:
    circlize,
    ComplexHeatmap,
    data.table,
    grDevices,
    grid,
    lifecycle,
    Matrix,
    stats,
    utils
Suggests: 
    BiocStyle,
    knitr,
    rmarkdown,
    testthat (>= 3.0.0)
Config/testthat/edition: 3
lshep commented 1 week ago

Please include an inst/script/ directory that has a file that can be code, psuedo code, or text but that describes how the data in inst/extdata was generated. minimally containing source/licensing information. A user should be able to get an idea of how to recreate the data if necessary.

Given this package seems to be working with geneSets. It will be necessary to also include functionality to the common Bioconductor classes for gene sets by also making functions compatible with BiocSet::BiocSet or the GSEABase::GeneSet or likely more appropriate GSEABase::GetSetCollection. See https://contributions.bioconductor.org/important-bioconductor-package-development-features.html#commonclass

TylerSagendorf commented 1 week ago

@lshep I will get this taken care of. Since this doesn't have the pre-review tag, should I make these changes to the existing TMSig repo under EMSL-Computing?

TylerSagendorf commented 1 week ago

Functions sparseIncidence, filterSets, and invertSets have been converted to S4 generics to support objects of class GeneSet and GeneSetCollection from GSEABase. I have also added a .txt file to inst/script/ that explains how c5.go.v2023.2.Hs.symbols.gmt.gz was generated.

lshep commented 5 days ago

thank you. we will take a re-evaluation soon.