Bioconductor / Contributions

Contribute Packages to Bioconductor
135 stars 33 forks source link

jazzPanda #3538

Open MelodyJIN-Y opened 2 months ago

MelodyJIN-Y commented 2 months ago

Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor

Confirm the following by editing each check box to '[x]'

I am familiar with the essential aspects of Bioconductor software management, including:

For questions/help about the submission process, including questions about the output of the automatic reports generated by the SPB (Single Package Builder), please use the #package-submission channel of our Community Slack. Follow the link on the home page of the Bioconductor website to sign up.

bioc-issue-bot commented 2 months ago

Hi @MelodyJIN-Y

Thanks for submitting your package. We are taking a quick look at it and you will hear back from us soon.

The DESCRIPTION file for this package is:

Package: jazzPanda
Type: Package
Title: Finding spatially relevant marker genes in image based spatial transcriptomics data 
Version: 0.99.0
Date: 2024-07-25
Authors@R: 
  c(person(given = "Melody",
 family = "Jin",
 role = c("aut", "cre"),
 email = "jin.m@wehi.edu.au",
 comment=c(ORCID="0000-0002-2222-0958"))
    )
LazyData: FALSE
Depends: R (>= 4.4.0)
Imports: spatstat.geom, dplyr, glmnet, caret, foreach, stats, magrittr, doParallel, BiocParallel
VignetteBuilder: knitr
Suggests: 
    BiocStyle,
    knitr,
    rmarkdown,
    spatstat,
    Seurat,
    statmod,
    corrplot,
    ggplot2,
    ggraph,
    ggrepel,
    gridExtra,
    reshape2,
    igraph,
    jsonlite,
    vdiffr,
    patchwork,
    ggpubr,
    tidyr,
    data.table,
    testthat (>= 3.0.0)
Description: This package contains the function to find marker genes for image-based spatial transcriptomics data. There are functions to create spatial vectors from the cell and transcript coordiantes, which are passed as inputs to find marker genes. Marker genes are detected for every cluster by two approaches. The first approach is by permtuation testing, which is implmented in parallel for finding marker genes for one sample study. The other approach is to build a linear model for every gene. This approach can account for multiple samples and backgound noise. 
License: GPL-3 + file LICENSE
URL: https://github.com/phipsonlab/jazzPanda, https://bhuvad.github.io/jazzPanda/
BugReports: https://github.com/phipsonlab/jazzPanda/issues
biocViews: Spatial, GeneExpression, DifferentialExpression, StatisticalMethod, Transcriptomics
RoxygenNote: 7.3.2
Encoding: UTF-8
Config/testthat/edition: 3
lshep commented 2 months ago

Packages are generally expected to use standard Bioconductor class objects. Please expand to use standard class objects like SpatialExperiment or SingleCellExperiment. For What Its Worth you might also check out the Experiment Data Package TENxXeniumData that already provides Xenium data in such a standard class object.

lshep commented 1 month ago

May we expect updates soon?

MelodyJIN-Y commented 1 month ago

Hi, I am overseas and will make updates in 2 weeks. Apologies for the delay.

bioc-issue-bot commented 2 weeks ago

This issue is being closed because there has been no progress for an extended period of time. You may reopen the issue when you have the time to actively participate in the review / submission process. Please also keep in mind that a package accepted to Bioconductor requires a commitment on your part to ongoing maintenance.

Thank you for your interest in Bioconductor.

MelodyJIN-Y commented 2 weeks ago

Hi, Thank you for your comments, and I apologize for the delay in updates.

lshep commented 1 week ago

Your package should take a SingleCellExperiment/SpatialExperiment class directly; it should not be flattened to a list and then used to create a Seurat object. Seurat objects are not valid Bioconductor class objects. You certainly can keep the interaction with Seurat but you should also make the package directly accept the standard Bioconductor class object (and ideally be endomorphic to return the same class object as output as input)

MelodyJIN-Y commented 1 week ago

Hi,

Thank you for your feedback. We have updated our package to accept SingleCellExperiment/SpatialExperiment/SpatialFeatureExperiment classes directly as input. This change aligns with Bioconductor standards and should improve user experience