Bioconductor / Contributions

Contribute Packages to Bioconductor
135 stars 33 forks source link

MOSClip #3560

Closed anna-bortolato closed 3 weeks ago

anna-bortolato commented 1 month ago

Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor

Confirm the following by editing each check box to '[x]'

I am familiar with the essential aspects of Bioconductor software management, including:

For questions/help about the submission process, including questions about the output of the automatic reports generated by the SPB (Single Package Builder), please use the #package-submission channel of our Community Slack. Follow the link on the home page of the Bioconductor website to sign up.

bioc-issue-bot commented 1 month ago

Hi @anna-bortolato

Thanks for submitting your package. We are taking a quick look at it and you will hear back from us soon.

The DESCRIPTION file for this package is:

Package: MOSClip
Title: Multi Omics Survival Clip
Version: 0.99.0
Depends: R (>= 4.4.0)
Authors@R: c(
   person(given = "Paolo", family = "Martini", role = c("aut", "cre"),
email = "paolo.martini@unibs.it",
comment = c(ORCID = "0000-0002-0146-1031")),
   person(given = "Anna", family = "Bortolato", role = c("aut"),
 email = "anna.bortolato@unipd.it",
 comment = c(ORCID = "0009-0009-9327-6084")),
   person(given = "Anna", family = "Tanada", role = c("aut"),
 email = "annacarolinaemi.delimatanada@phd.unipd.it",
 comment = c(ORCID = "0000-0003-3224-0538")),
   person(given = "Enrica", family = "Calura", role = c("aut"),
email = "enrica.calura@unipd.it",
comment = c(ORCID = "0000-0001-8463-2432")),
   person(given = "Stefania", family = "Pirrotta", role = c("aut"),
email = "stefania.pirrotta@phd.unipd.it",
comment = c(ORCID = "0009-0004-0030-217X")),
   person(given = "Federico", family = "Agostinis", role = c("aut"),
email = "federico.agostinis@outlook.com")
   )
Description: Allows to combine multiple omics dimension to perform pathway survival or two-class analysis. There are two main mode: pathway tests and module tests. The latter method allows the user to dig inside the pathways itself.
License: AGPL-3
Imports: MultiAssayExperiment, methods, survminer, graph,
  graphite, AnnotationDbi, checkmate, ggplot2, gridExtra, igraph,
  pheatmap, survival, RColorBrewer, SuperExactTest,
  reshape, NbClust, S4Vectors, grDevices, graphics, stats, utils, 
  ComplexHeatmap, FactoMineR, circlize, corpcor, coxrobust,
  elasticnet, gRbase, ggplotify, qpgraph, org.Hs.eg.db, Matrix
Suggests: RUnit, BiocGenerics, MASS, BiocStyle, knitr, EDASeq, rmarkdown, kableExtra, testthat (>= 3.0.0)
Encoding: UTF-8
LazyData: false
biocViews: Software, StatisticalMethod, GraphAndNetwork, Survival, Regression, DimensionReduction, Pathways, Reactome
BugReports: https://github.com/cavei/MOSClip/
URL: https://github.com/cavei/MOSClip
Roxygen: list(markdown = TRUE)
RoxygenNote: 7.3.2
VignetteBuilder: knitr
bioc-issue-bot commented 1 month ago

Your package has been added to git.bioconductor.org to continue the pre-review process. A build report will be posted shortly. Please fix any ERROR and WARNING in the build report before a reviewer is assigned or provide a justification on why you feel the ERROR or WARNING should be granted an exception.

IMPORTANT: Please read this documentation for setting up remotes to push to git.bioconductor.org. All changes should be pushed to git.bioconductor.org moving forward. It is required to push a version bump to git.bioconductor.org to trigger a new build report.

Bioconductor utilized your github ssh-keys for git.bioconductor.org access. To manage keys and future access you may want to active your Bioconductor Git Credentials Account

bioc-issue-bot commented 1 month ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Single Package Builder.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Single Package Builder: Linux (Ubuntu 24.04.1 LTS): MOSClip_0.99.0.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/MOSClip to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 1 month ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 9df33be0c8b40cac16d75d2f144ed76d024a9237

bioc-issue-bot commented 1 month ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Single Package Builder.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details.

The following are build products from R CMD build on the Single Package Builder: Linux (Ubuntu 24.04.1 LTS): MOSClip_0.99.1.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/MOSClip to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 1 month ago

A reviewer has been assigned to your package for an indepth review. Please respond accordingly to any further comments from the reviewer.

bioc-issue-bot commented 1 month ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 4de1fc058a33332b7fb47c6a05368c5de2f368aa

bioc-issue-bot commented 1 month ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Single Package Builder.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details.

The following are build products from R CMD build on the Single Package Builder: Linux (Ubuntu 24.04.1 LTS): MOSClip_0.99.2.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/MOSClip to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 1 month ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 5e54b2ee2943789cbcee9c58384319ff612ea2df

bioc-issue-bot commented 1 month ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Single Package Builder.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details.

The following are build products from R CMD build on the Single Package Builder: Linux (Ubuntu 24.04.1 LTS): MOSClip_0.99.3.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/MOSClip to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 1 month ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 6bf20f24533ba505a8b62cf6e30bc5133c8a9c2a

bioc-issue-bot commented 1 month ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Single Package Builder.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details.

The following are build products from R CMD build on the Single Package Builder: Linux (Ubuntu 24.04.1 LTS): MOSClip_0.99.4.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/MOSClip to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

Kayla-Morrell commented 4 weeks ago

@anna-bortolato - Thank you for submitting to Bioconductor. Please see the initial review of the package below. The required changes must be made while the suggested changes do not have to be (though we strongly encourage them). Comment back here with updates that have been made and when the package is ready for a re-review.

General package development

NEWS

R code

Best, Kayla

bioc-issue-bot commented 4 weeks ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 44913b780acf22dd45fead92c06d612790d316cf

bioc-issue-bot commented 4 weeks ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Single Package Builder.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details.

The following are build products from R CMD build on the Single Package Builder: Linux (Ubuntu 24.04.1 LTS): MOSClip_0.99.5.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/MOSClip to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

anna-bortolato commented 4 weeks ago

Dear @Kayla-Morrell, Thank you for your reply. We made some changes to accomplish some of your requests.

General package development

We added instructions for installation from Bioconductor in the README.md file.

NEWS

We included a NEWS file in the package.

R code

This suppressWarnings is used to suppress a warning generated by a function for plotting (plotFrequencies). The warning is "Vectorized input to element_text() is not officially supported. ℹ Results may be unexpected or may change in future versions of ggplot2". We are aware of this warning and we will monitor the behavior of the function with future versions of ggplot2. At the moment this warning is not affecting the final output of the function and we think it could be annoying for the user; for this reason, we would like to keep the suppressWarnings in the code.

We used styler R package to indent lines. At the moment, only 72 lines, that correspond to the 1% of the code and are mainly in the vignette, are not correctly indented.

Let us know if it is ok, thank you

Anna

Kayla-Morrell commented 3 weeks ago

@anna-bortolato - Thank you for making the necessary changes and/or providing clarification on the other notes. I have reviewed everything and it all looks good. I'm more than happy to accept the package.

Best, Kayla

bioc-issue-bot commented 3 weeks ago

Your package has been accepted. It will be added to the Bioconductor nightly builds.

Thank you for contributing to Bioconductor!

Reviewers for Bioconductor packages are volunteers from the Bioconductor community. If you are interested in becoming a Bioconductor package reviewer, please see Reviewers Expectations.

lshep commented 3 weeks ago

The default branch of your GitHub repository has been added to Bioconductor's git repository as branch devel.

To use the git.bioconductor.org repository, we need an 'ssh' key to associate with your github user name. If your GitHub account already has ssh public keys (https://github.com/anna-bortolato.keys is not empty), then no further steps are required. Otherwise, do the following:

  1. Add an SSH key to your github account
  2. Submit your SSH key to Bioconductor

See further instructions at

https://bioconductor.org/developers/how-to/git/

for working with this repository. See especially

https://bioconductor.org/developers/how-to/git/new-package-workflow/ https://bioconductor.org/developers/how-to/git/sync-existing-repositories/

to keep your GitHub and Bioconductor repositories in sync.

Your package will be included in the next nigthly 'devel' build (check-out from git at about 6 pm Eastern; build completion around 2pm Eastern the next day) at

https://bioconductor.org/checkResults/

(Builds sometimes fail, so ensure that the date stamps on the main landing page are consistent with the addition of your package). Once the package builds successfully, you package will be available for download in the 'Devel' version of Bioconductor using BiocManager::install("MOSClip"). The package 'landing page' will be created at

https://bioconductor.org/packages/MOSClip

If you have any questions, please contact the bioc-devel mailing list (https://stat.ethz.ch/mailman/listinfo/bioc-devel); this issue will not be monitored further.