Bioconductor / Contributions

Contribute Packages to Bioconductor
135 stars 33 forks source link

(inactive) PloidyPeaks #3567

Closed MicroStatsLab closed 2 weeks ago

MicroStatsLab commented 2 months ago

Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor

Confirm the following by editing each check box to '[x]'

I am familiar with the essential aspects of Bioconductor software management, including:

For questions/help about the submission process, including questions about the output of the automatic reports generated by the SPB (Single Package Builder), please use the #package-submission channel of our Community Slack. Follow the link on the home page of the Bioconductor website to sign up.

bioc-issue-bot commented 2 months ago

Hi @MicroStatsLab

Thanks for submitting your package. We are taking a quick look at it and you will hear back from us soon.

The DESCRIPTION file for this package is:

Package: PloidyPeaks
Title: Peak Detection Algorithm For Flow Cytometry Data
Version: 0.99.0
Authors@R: c(
    person("Margot", "Henry", email="margothenry@live.com", role = c("aut", "cre")),
    person("Aleeza", "Gerstein", email="aleeza.gerstein@umanitoba.ca", role=c("aut", "ths")),
    person("Maxime", "Turgeon", email="turgeon.maxime@gmail.com", role="ctb"),
    person("Caitlin", "Kostna", email="microstatslab@gmail.com", role="ctb"),
    person("Leanne", "Von Giese", role="ctb"))
Description: PloidyPeaks is a package to quantify population-level genome size variation from flow cytometry data without requiring user input.
    The package uses peak detection algorithms and flow cytometry population definitions to quantify sub-populations.
    The workflow is separated into three parts: 1) gating and 2) peak detection, 3) dataset output.
    Built-in visualizations options are included throughout.
biocViews: FlowCytometry, PeakDetection, Visualization
Imports: AzureRMR,
    AzureStor,
    BiocFileCache,
    cowplot,
    data.table,
    dplyr,
    flowCore,
    flowTime,
    ggcyto,
    ggplot2,
    gridExtra,
    here,
    htmltools,
    kableExtra,
    magrittr,
    moments,
    patchwork,
    purrr,
    scorepeak,
    sqldf,
    tcltk,
    tidyr,
    tidyverse,
    tools,
    vctrs,
    xpectr,
    zoo
License: GPL-3
Encoding: UTF-8
Roxygen: list(markdown = TRUE)
RoxygenNote: 7.2.1
Suggests: 
    rmarkdown,
    knitr,
    testthat
VignetteBuilder: knitr
bioc-issue-bot commented 2 months ago

Your package has been added to git.bioconductor.org to continue the pre-review process. A build report will be posted shortly. Please fix any ERROR and WARNING in the build report before a reviewer is assigned or provide a justification on why you feel the ERROR or WARNING should be granted an exception.

IMPORTANT: Please read this documentation for setting up remotes to push to git.bioconductor.org. All changes should be pushed to git.bioconductor.org moving forward. It is required to push a version bump to git.bioconductor.org to trigger a new build report.

Bioconductor utilized your github ssh-keys for git.bioconductor.org access. To manage keys and future access you may want to active your Bioconductor Git Credentials Account

bioc-issue-bot commented 2 months ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Single Package Builder.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Single Package Builder: Linux (Ubuntu 24.04.1 LTS): PloidyPeaks_0.99.0.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/PloidyPeaks to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

MicroStatsLab commented 1 month ago

Hi,

I'm working through making some changes to address the errors during the build process. I cannot seem to replicate the error that appeared in the R CMD Check with the rectGateFlowSet() function. I'm wondering if you run these tests with the internet or not. The examples in my functions rely on an internet connection to download the data that is needed. Any information would be appreciated so I know how to adjust my functions and to avoid future errors.

Thanks, Caitlin

On Tue, Sep 24, 2024 at 11:18 AM bioc-issue-bot @.***> wrote:

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Single Package Builder.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report http://bioconductor.org/spb_reports/PloidyPeaks_buildreport_20240924121758.html for more details.

The following are build products from R CMD build on the Single Package Builder: Linux (Ubuntu 24.04.1 LTS): PloidyPeaks_0.99.0.tar.gz https://bioconductor.org/spb_reports/PloidyPeaks_0.99.0.tar.gz

Links above active for 21 days.

— Reply to this email directly, view it on GitHub https://github.com/Bioconductor/Contributions/issues/3567#issuecomment-2371749686, or unsubscribe https://github.com/notifications/unsubscribe-auth/BKPRQESPKARFDTTEBYSLAGDZYGGE3AVCNFSM6AAAAABOOVJVTWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZRG42DSNRYGY . You are receiving this because you were mentioned.Message ID: @.***>

lshep commented 1 month ago

I also cannot reproduce. I will kick off a new build manually to see if it clears up. But yes there is internet when running the builds

bioc-issue-bot commented 1 month ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Single Package Builder.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Single Package Builder: Linux (Ubuntu 24.04.1 LTS): PloidyPeaks_0.99.0.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/PloidyPeaks to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

MicroStatsLab commented 1 month ago

Hi,

Thanks for manually running the build report. It seems that the error is still there for rectGateFlowSet(). Do you have any suggestions on how to fix it? I can't seem to reproduce the error.

As well, I saw that one of the errors is that we're not subscribed to the BiocDevel mailing list. I can assure you that @.*** is subscribed. I've been receiving Bioconductor emails at that address for a while now.

I know there are still other errors, however, I'm not going to push those changes until I can solve everything in one push.

Thanks, Caitlin

On Mon, Sep 30, 2024 at 7:28 AM bioc-issue-bot @.***> wrote:

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Single Package Builder.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report http://bioconductor.org/spb_reports/PloidyPeaks_buildreport_20240930082816.html for more details.

The following are build products from R CMD build on the Single Package Builder: Linux (Ubuntu 24.04.1 LTS): PloidyPeaks_0.99.0.tar.gz https://bioconductor.org/spb_reports/PloidyPeaks_0.99.0.tar.gz

Links above active for 21 days.

— Reply to this email directly, view it on GitHub https://github.com/Bioconductor/Contributions/issues/3567#issuecomment-2383051016, or unsubscribe https://github.com/notifications/unsubscribe-auth/BKPRQES5C3RNM36WLOPFWBDZZE7XRAVCNFSM6AAAAABOOVJVTWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBTGA2TCMBRGY . You are receiving this because you were mentioned.Message ID: @.***>

lshep commented 1 month ago

I just checked and the listed maintainer email margothenry@live.com does not appear to be registered on bioc-devel@r-project.org. I'm not sure off hand what could be going on with the file recognition but will try to investigate further in the next few days.

MicroStatsLab commented 1 month ago

The maintainer should now be this email address @.***). Where do I have to change that?

And thank you for investigating. I'll ensure to have all other changes ready to push when we figure out the file issue.

On Mon, Sep 30, 2024 at 9:35 AM lshep @.***> wrote:

I just checked and the listed maintainer email @. does not appear to be registered on @. I'm not sure off hand what could be going on with the file recognition but will try to investigate further in the next few days.

— Reply to this email directly, view it on GitHub https://github.com/Bioconductor/Contributions/issues/3567#issuecomment-2383388758, or unsubscribe https://github.com/notifications/unsubscribe-auth/BKPRQEUBPMV7H5UNYVLXO43ZZFOSVAVCNFSM6AAAAABOOVJVTWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBTGM4DQNZVHA . You are receiving this because you were mentioned.Message ID: @.***>

lshep commented 1 month ago

There seems to be a PloidyPeaks-Ex.timings that gets copied/created in the raw_data folder. I'm not sure why this file would get created here even if it was the last example to run. @jwokaty / @hpages any ideas on this one?

lshep commented 1 month ago

@MicroStatsLab the email is hidden for privacy when you type so I don't know what you are comparing too but the DESCRIPTION maintainer (as designated with the 'cre') is checked for mailing list and support site.

We are still investigating my comment above which is causing the ERROR on the builder

jwokaty commented 1 month ago

@MicroStatsLab I'm able to produce the error on my laptop by adding the --timing check on the binary: R CMD check --timings PloidyPeaks_0.99.0.tar.gz. When running R CMD check, I see messages that the working directory is being changed. I wonder if that's how PloidyPeaks-Ex.timings gets in raw_data. It might be better to avoid changing the working directory to prevent side effects even if it's not the cause. I would defer to @lshep for advice. Maybe @MicroStatsLab you can use this to troubleshoot?

MicroStatsLab commented 1 month ago

Hi,

No worries on the other issue. I can adjust the 'cre' to be our lab email address.

Keep me posted, Caitlin

On Mon, Oct 7, 2024 at 9:47 AM lshep @.***> wrote:

@MicroStatsLab https://github.com/MicroStatsLab the email is hidden for privacy when you type so I don't know what you are comparing too but the DESCRIPTION maintainer (as designated with the 'cre') is checked for mailing list and support site.

We are still investigating my comment above which is causing the ERROR on the builder

— Reply to this email directly, view it on GitHub https://github.com/Bioconductor/Contributions/issues/3567#issuecomment-2397143126, or unsubscribe https://github.com/notifications/unsubscribe-auth/BKPRQEWBBJ5WBDLEXVRJNFLZ2KNJJAVCNFSM6AAAAABOOVJVTWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJXGE2DGMJSGY . You are receiving this because you were mentioned.Message ID: @.***>

lshep commented 1 month ago

@MicroStatsLab Just wanted to make sure you saw @jwokaty comment above about the issue going on. perhaps copying needed files to a user specified (and in the cases of vignette/examples) temporary directory might be a better approach. Perhaps tracking what the working directory is before changing directory with a getwd and resetting at the end might also help

MicroStatsLab commented 1 month ago

Hi,

I did see the note but haven't had any time this week to look into it. I'll see if I can fix it this weekend. I appreciate the help with it!

Caitlin

On Fri, Oct 11, 2024 at 9:00 AM lshep @.***> wrote:

@MicroStatsLab https://github.com/MicroStatsLab Just wanted to make sure you saw @jwokaty https://github.com/jwokaty comment above about the issue going on. perhaps copying needed files to a user specified (and in the cases of vignette/examples) temporary directory might be a better approach. Perhaps tracking what the working directory is before changing directory with a getwd and resetting at the end might also help

— Reply to this email directly, view it on GitHub https://github.com/Bioconductor/Contributions/issues/3567#issuecomment-2407478724, or unsubscribe https://github.com/notifications/unsubscribe-auth/BKPRQEU2436XLX2WP2ZPBBLZ27KXBAVCNFSM6AAAAABOOVJVTWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBXGQ3TQNZSGQ . You are receiving this because you were mentioned.Message ID: @.***>

bioc-issue-bot commented 2 weeks ago

This issue is being closed because there has been no progress for an extended period of time. You may reopen the issue when you have the time to actively participate in the review / submission process. Please also keep in mind that a package accepted to Bioconductor requires a commitment on your part to ongoing maintenance.

Thank you for your interest in Bioconductor.