Bioconductor / Contributions

Contribute Packages to Bioconductor
134 stars 33 forks source link

zFPKM #385

Closed ronammar closed 7 years ago

ronammar commented 7 years ago

Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor

Confirm the following by editing each check box to '[x]'

I am familiar with the essential aspects of Bioconductor software management, including:

For help with submitting your package, please subscribe and post questions to the bioc-devel mailing list.

bioc-issue-bot commented 7 years ago

Hi @ronammar

Thanks for submitting your package. We are taking a quick look at it and you will hear back from us soon.

The DESCRIPTION file for this package is:

Package: zFPKM
Title: A suite of functions to facilitate zFPKM transformations
Version: 0.99.0
Authors@R: 
    c(
      person("Ron", "Ammar", role = c("aut", "cre"), email = "ron.ammar@bms.com"),
      person("John", "Thompson", role = "aut", email = "john.thompson@bms.com")
    )
Description: Perform the zFPKM transform on RNA-seq FPKM data. This algorithm
    is based on the publication by Hart et al., 2013 (Pubmed ID 24215113). Reference
    recommends using zFPKM > -3 to select expressed genes. Validated with encode
    open/closed chromosome data. Works well for gene level data using FPKM or TPM.
    Does not appear to calibrate well for transcript level data.
License: GPL-3 | file LICENSE
URL: https://github.com/ronammar/zFPKM/
BugReports: https://github.com/ronammar/zFPKM/issues
Imports: checkmate, dplyr, ggplot2, tidyr
Suggests: knitr
VignetteBuilder: knitr
biocViews: RNASeq, FeatureExtraction, Software, GeneExpression
LazyData: true
RoxygenNote: 6.0.1
bioc-issue-bot commented 7 years ago

Your package has been approved for building. Your package is now submitted to our queue.

IMPORTANT: Please read the instructions for setting up a push hook on your repository, or further changes to your repository will NOT trigger a new build.

bioc-issue-bot commented 7 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the following build report for more details:

http://bioconductor.org/spb_reports/zFPKM_buildreport_20170531105035.html

mtmorgan commented 7 years ago

The vignette isn't really acceptable; it should illustrate how the package integrates into typical Bioconductor work flows. Use of standard Bioconductor data representations facilitates interoperability between packages, reproducibility (e.g., tracking 'metadata' about samples and experiments) and utility. So it's amazing that you don't have any Bioconductor dependencies, e.g., GenomicRanges for representing genomic coordinates, SummarizedExperiment for representing RNASeq count data, rtracklayer and tximport for import / export of standard precursors to the analysis that you enable.

ronammar commented 7 years ago

Hi @mtmorgan, thanks for the feedback. Can you point me to a vignette that integrates well so I can use it as an example?

mtmorgan commented 7 years ago

tximport for instance.

bioc-issue-bot commented 7 years ago

Received a valid push; starting a build. Commits are:

16c8710 Updating vignette, using GSE96106 and GEOquery 2ad07a3 Due to noise profiles, reverting back to gse94802 9b3f670 Updated vignette with sample zFPKM usage eb6c7b0 Incremented version

bioc-issue-bot commented 7 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the following build report for more details:

http://bioconductor.org/spb_reports/zFPKM_buildreport_20170531135457.html

bioc-issue-bot commented 7 years ago

Received a valid push; starting a build. Commits are:

ad5cb35 Bumped version

bioc-issue-bot commented 7 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the following build report for more details:

http://bioconductor.org/spb_reports/zFPKM_buildreport_20170531135954.html

ronammar commented 7 years ago

Hi, why am I getting the following error on only 2/3 platforms? I confirmed my subscription to the bioc-devel mailing list.

* Checking for bioc-devel mailing list subscription...
    * ERROR: Maintainer must subscribe to the bioc-devel mailing list.
      Subscribe here: https://stat.ethz.ch/mailman/listinfo/bioc-devel
mtmorgan commented 7 years ago

I don't see your email address (from the DESCRIPTION) file in the bioc-devel mailing list. When you subscribed, the mailman software sends a confirmation that you need to respond to. This often ends up in spam folders.

ronammar commented 7 years ago

Apologies - I think the confirmation I received was from BioC support. However, I've now signed up for the bioc-devel mailing list twice today and haven't received a confirmation email in my inbox or junk mail.

Do I have to indicate "yes" under "Would you like to receive list mail batched in a daily digest?" Can my subscription request be confirmed by the list moderator?

mtmorgan commented 7 years ago

I now see your subscription on the mailing list. It's tagged as indicating that the user (you) have chosen not to receive email. I'm not sure if this is mailman's way of saying you haven't responded to the acknowledgement or that you have actually configured your account this way?

ronammar commented 7 years ago

Corporate mail filtering released "junk" mail it in a weird way. That was my attempt to turn mail on. Anyway, I've confirmed membership.

How can I rerun the automated build without pushing now?

bioc-issue-bot commented 7 years ago

Received a valid push; starting a build. Commits are:

c4dbe9b Version bump 0.99.3

bioc-issue-bot commented 7 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "WARNINGS, skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the following build report for more details:

http://bioconductor.org/spb_reports/zFPKM_buildreport_20170601090120.html

ronammar commented 7 years ago

Ok I've got an error on Linux: Fatal error: cannot create 'R_TempDir' Is this a permissions issue or a full /tmp directory issue (as suggested on SO)? Advice?

Also, the warnings on OS X and Windows pertain to an existing inst/doc path. How should I resolve this?

Thanks!

mtmorgan commented 7 years ago

Yeah the linux problem is on our end.The content of your 'inst/doc' directory are actually generated by the R CMD build step, and should not be in your git repository.

bioc-issue-bot commented 7 years ago

Received a valid push; starting a build. Commits are:

3e3bd76 Forgot to version bump. v0.99.4

bioc-issue-bot commented 7 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the following build report for more details:

http://bioconductor.org/spb_reports/zFPKM_buildreport_20170601095521.html

ronammar commented 7 years ago

The sole error that remains is the Linux system issue with temp directories. How should I proceed?

mtmorgan commented 7 years ago

Wait for the formal review from @LiNk-NY

LiNk-NY commented 7 years ago

Thank you @mtmorgan for generous input and follow-up on Ron's package.

Ron, @ronammar Thank you for submitting to Bioconductor. Although you've made changes to the vignette, it does not seem complete since it doesn't make use of the Bioconductor infrastructure already available.

A few preliminary points:

Regards, Marcel

ronammar commented 7 years ago

Thanks @LiNk-NY for your valuable feedback, and @mtmorgan for all your help so far!

I have done my best to address your points:

bioc-issue-bot commented 7 years ago

Received a valid push; starting a build. Commits are:

133eb14 Switched workflow to SummarizedExperiment 5b0fa0a Bumped version, added Depends d3e6255 Separate functions for calc and plotting. Updated ... bd41edf Adding new man files

bioc-issue-bot commented 7 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the following build report for more details:

http://bioconductor.org/spb_reports/zFPKM_buildreport_20170601215701.html

bioc-issue-bot commented 7 years ago

Received a valid push; starting a build. Commits are:

30eaf93 forgot version bump

bioc-issue-bot commented 7 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the following build report for more details:

http://bioconductor.org/spb_reports/zFPKM_buildreport_20170601220502.html

bioc-issue-bot commented 7 years ago

Received a valid push; starting a build. Commits are:

9a7ae58 Updated vignette. Works locally, but crashes in au...

bioc-issue-bot commented 7 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "skipped, ERROR, WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the following build report for more details:

http://bioconductor.org/spb_reports/zFPKM_buildreport_20170601221329.html

bioc-issue-bot commented 7 years ago

Received a valid push; starting a build. Commits are:

70a6866 As per autobuild, updated to depends 3.4.0

bioc-issue-bot commented 7 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the following build report for more details:

http://bioconductor.org/spb_reports/zFPKM_buildreport_20170601221821.html

bioc-issue-bot commented 7 years ago

Received a valid push; starting a build. Commits are:

a14a7f6 Uncertain why GEOquery keeps failing to connect to...

bioc-issue-bot commented 7 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the following build report for more details:

http://bioconductor.org/spb_reports/zFPKM_buildreport_20170601222300.html

ronammar commented 7 years ago

For some reason, the Bioconductor package GEOquery periodically and unexpectedly yields errors connecting to NCBI. Aside from this error, the builds appear to be working. I've contacted the package maintainer for help. Thoughts?

ronammar commented 7 years ago

Hi- any thoughts on next steps to progress with this submission? I think the package is building correctly, but GEOquery is crashing, causing my package build to have errors unexpectedly. Should I bundle .rds with the vignette to circumvent this potential error?

LiNk-NY commented 7 years ago

Hi Ron, @ronammar Yes, you can do that. Create a subset of the dataset from GEOquery and add it to your vignette examples.

I will have a second look at this soon. Thanks.

Regards, Marcel

bioc-issue-bot commented 7 years ago

Received a valid push; starting a build. Commits are:

938026b Circumventing GEOquery failure using .rds

bioc-issue-bot commented 7 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the following build report for more details:

http://bioconductor.org/spb_reports/zFPKM_buildreport_20170605130403.html

ronammar commented 7 years ago

Thanks @LiNk-NY, I followed your suggestion, and bundled a .rds file with the vignette.

ronammar commented 7 years ago

Hi @LiNk-NY, is there anything else that came up during review? Thanks!

LiNk-NY commented 7 years ago

Hi Ron, @ronammar Sorry for the delay. I will get to your package soon.

Regards, Marcel

LiNk-NY commented 7 years ago

Hi Ron, @ronammar

It doesn't seem like you are using SummarizedExperiment as you have stated previously. Have you rolled back to a previous commit?

I don't see SummarizedExperiment in the DESCRIPTION file.

Regards, Marcel

bioc-issue-bot commented 7 years ago

Received a valid push; starting a build. Commits are:

7bfb90e Updated with SummarizedExperiment

bioc-issue-bot commented 7 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the following build report for more details:

http://bioconductor.org/spb_reports/zFPKM_buildreport_20170628153903.html

bioc-issue-bot commented 7 years ago

Received a valid push; starting a build. Commits are:

dda6dbc Added SummarizedExperiment to Namespace file

bioc-issue-bot commented 7 years ago

Received a valid push; starting a build. Commits are:

c91992b Updated documentation

bioc-issue-bot commented 7 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the following build report for more details:

http://bioconductor.org/spb_reports/zFPKM_buildreport_20170628154618.html

bioc-issue-bot commented 7 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the following build report for more details:

http://bioconductor.org/spb_reports/zFPKM_buildreport_20170628154830.html