Closed ronammar closed 7 years ago
Hi @ronammar
Thanks for submitting your package. We are taking a quick look at it and you will hear back from us soon.
The DESCRIPTION file for this package is:
Package: zFPKM
Title: A suite of functions to facilitate zFPKM transformations
Version: 0.99.0
Authors@R:
c(
person("Ron", "Ammar", role = c("aut", "cre"), email = "ron.ammar@bms.com"),
person("John", "Thompson", role = "aut", email = "john.thompson@bms.com")
)
Description: Perform the zFPKM transform on RNA-seq FPKM data. This algorithm
is based on the publication by Hart et al., 2013 (Pubmed ID 24215113). Reference
recommends using zFPKM > -3 to select expressed genes. Validated with encode
open/closed chromosome data. Works well for gene level data using FPKM or TPM.
Does not appear to calibrate well for transcript level data.
License: GPL-3 | file LICENSE
URL: https://github.com/ronammar/zFPKM/
BugReports: https://github.com/ronammar/zFPKM/issues
Imports: checkmate, dplyr, ggplot2, tidyr
Suggests: knitr
VignetteBuilder: knitr
biocViews: RNASeq, FeatureExtraction, Software, GeneExpression
LazyData: true
RoxygenNote: 6.0.1
Your package has been approved for building. Your package is now submitted to our queue.
IMPORTANT: Please read the instructions for setting up a push hook on your repository, or further changes to your repository will NOT trigger a new build.
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the following build report for more details:
http://bioconductor.org/spb_reports/zFPKM_buildreport_20170531105035.html
The vignette isn't really acceptable; it should illustrate how the package integrates into typical Bioconductor work flows. Use of standard Bioconductor data representations facilitates interoperability between packages, reproducibility (e.g., tracking 'metadata' about samples and experiments) and utility. So it's amazing that you don't have any Bioconductor dependencies, e.g., GenomicRanges for representing genomic coordinates, SummarizedExperiment for representing RNASeq count data, rtracklayer and tximport for import / export of standard precursors to the analysis that you enable.
Hi @mtmorgan, thanks for the feedback. Can you point me to a vignette that integrates well so I can use it as an example?
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the following build report for more details:
http://bioconductor.org/spb_reports/zFPKM_buildreport_20170531135457.html
Received a valid push; starting a build. Commits are:
ad5cb35 Bumped version
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the following build report for more details:
http://bioconductor.org/spb_reports/zFPKM_buildreport_20170531135954.html
Hi, why am I getting the following error on only 2/3 platforms? I confirmed my subscription to the bioc-devel mailing list.
* Checking for bioc-devel mailing list subscription...
* ERROR: Maintainer must subscribe to the bioc-devel mailing list.
Subscribe here: https://stat.ethz.ch/mailman/listinfo/bioc-devel
I don't see your email address (from the DESCRIPTION) file in the bioc-devel mailing list. When you subscribed, the mailman software sends a confirmation that you need to respond to. This often ends up in spam folders.
Apologies - I think the confirmation I received was from BioC support. However, I've now signed up for the bioc-devel mailing list twice today and haven't received a confirmation email in my inbox or junk mail.
Do I have to indicate "yes" under "Would you like to receive list mail batched in a daily digest?" Can my subscription request be confirmed by the list moderator?
I now see your subscription on the mailing list. It's tagged as indicating that the user (you) have chosen not to receive email. I'm not sure if this is mailman's way of saying you haven't responded to the acknowledgement or that you have actually configured your account this way?
Corporate mail filtering released "junk" mail it in a weird way. That was my attempt to turn mail on. Anyway, I've confirmed membership.
How can I rerun the automated build without pushing now?
Received a valid push; starting a build. Commits are:
c4dbe9b Version bump 0.99.3
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "WARNINGS, skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the following build report for more details:
http://bioconductor.org/spb_reports/zFPKM_buildreport_20170601090120.html
Ok I've got an error on Linux: Fatal error: cannot create 'R_TempDir'
Is this a permissions issue or a full /tmp
directory issue (as suggested on SO)? Advice?
Also, the warnings on OS X and Windows pertain to an existing inst/doc
path. How should I resolve this?
Thanks!
Yeah the linux problem is on our end.The content of your 'inst/doc' directory are actually generated by the R CMD build step, and should not be in your git repository.
Received a valid push; starting a build. Commits are:
3e3bd76 Forgot to version bump. v0.99.4
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the following build report for more details:
http://bioconductor.org/spb_reports/zFPKM_buildreport_20170601095521.html
The sole error that remains is the Linux system issue with temp directories. How should I proceed?
Wait for the formal review from @LiNk-NY
Thank you @mtmorgan for generous input and follow-up on Ron's package.
Ron, @ronammar Thank you for submitting to Bioconductor. Although you've made changes to the vignette, it does not seem complete since it doesn't make use of the Bioconductor infrastructure already available.
A few preliminary points:
SummarizedExperiment
to represent your RNAseq count data. If you are also working with ranged data, strongly consider using the GenomicRanges
package.dplyr
will not be required. R (>= 3.4.0)
in the Depends
field in the DESCRIPTION
file.Regards, Marcel
Thanks @LiNk-NY for your valuable feedback, and @mtmorgan for all your help so far!
I have done my best to address your points:
SummarizedExperiment
's where neededdplyr
except where group-wise operations are required, and these do not substitute the Bioconductor infrastructure.zFPKMPlot()
and the main function now has the same name as the package, zFPKM()
.Depends: R (>= 3.3.3)
instead?Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the following build report for more details:
http://bioconductor.org/spb_reports/zFPKM_buildreport_20170601215701.html
Received a valid push; starting a build. Commits are:
30eaf93 forgot version bump
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the following build report for more details:
http://bioconductor.org/spb_reports/zFPKM_buildreport_20170601220502.html
Received a valid push; starting a build. Commits are:
9a7ae58 Updated vignette. Works locally, but crashes in au...
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "skipped, ERROR, WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the following build report for more details:
http://bioconductor.org/spb_reports/zFPKM_buildreport_20170601221329.html
Received a valid push; starting a build. Commits are:
70a6866 As per autobuild, updated to depends 3.4.0
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the following build report for more details:
http://bioconductor.org/spb_reports/zFPKM_buildreport_20170601221821.html
Received a valid push; starting a build. Commits are:
a14a7f6 Uncertain why GEOquery keeps failing to connect to...
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the following build report for more details:
http://bioconductor.org/spb_reports/zFPKM_buildreport_20170601222300.html
For some reason, the Bioconductor package GEOquery
periodically and unexpectedly yields errors connecting to NCBI. Aside from this error, the builds appear to be working. I've contacted the package maintainer for help. Thoughts?
Hi- any thoughts on next steps to progress with this submission? I think the package is building correctly, but GEOquery
is crashing, causing my package build to have errors unexpectedly. Should I bundle .rds with the vignette to circumvent this potential error?
Hi Ron, @ronammar
Yes, you can do that.
Create a subset of the dataset from GEOquery
and add it to your vignette examples.
I will have a second look at this soon. Thanks.
Regards, Marcel
Received a valid push; starting a build. Commits are:
938026b Circumventing GEOquery failure using .rds
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
Congratulations! The package built without errors or warnings on all platforms.
Please see the following build report for more details:
http://bioconductor.org/spb_reports/zFPKM_buildreport_20170605130403.html
Thanks @LiNk-NY, I followed your suggestion, and bundled a .rds file with the vignette.
Hi @LiNk-NY, is there anything else that came up during review? Thanks!
Hi Ron, @ronammar Sorry for the delay. I will get to your package soon.
Regards, Marcel
Hi Ron, @ronammar
It doesn't seem like you are using SummarizedExperiment
as you have stated previously. Have you rolled
back to a previous commit?
I don't see SummarizedExperiment
in the DESCRIPTION
file.
Regards, Marcel
Received a valid push; starting a build. Commits are:
7bfb90e Updated with SummarizedExperiment
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the following build report for more details:
http://bioconductor.org/spb_reports/zFPKM_buildreport_20170628153903.html
Received a valid push; starting a build. Commits are:
dda6dbc Added SummarizedExperiment to Namespace file
Received a valid push; starting a build. Commits are:
c91992b Updated documentation
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the following build report for more details:
http://bioconductor.org/spb_reports/zFPKM_buildreport_20170628154618.html
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the following build report for more details:
http://bioconductor.org/spb_reports/zFPKM_buildreport_20170628154830.html
Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor
Confirm the following by editing each check box to '[x]'
[x] I understand that by submitting my package to Bioconductor, the package source and all review commentary are visible to the general public.
[x] I have read the Bioconductor Package Submission instructions. My package is consistent with the Bioconductor Package Guidelines.
[x] I understand that a minimum requirement for package acceptance is to pass R CMD check and R CMD BiocCheck with no ERROR or WARNINGS. Passing these checks does not result in automatic acceptance. The package will then undergo a formal review and recommendations for acceptance regarding other Bioconductor standards will be addressed.
[x] My package addresses statistical or bioinformatic issues related to the analysis and comprehension of high throughput genomic data.
[x] I am committed to the long-term maintenance of my package. This includes monitoring the support site for issues that users may have, subscribing to the bioc-devel mailing list to stay aware of developments in the Bioconductor community, responding promptly to requests for updates from the Core team in response to changes in R or underlying software.
I am familiar with the essential aspects of Bioconductor software management, including:
For help with submitting your package, please subscribe and post questions to the bioc-devel mailing list.