Bioconductor / Contributions

Contribute Packages to Bioconductor
134 stars 33 forks source link

cytolib #445

Closed mikejiang closed 7 years ago

mikejiang commented 7 years ago

Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor

Confirm the following by editing each check box to '[x]'

I am familiar with the essential aspects of Bioconductor software management, including:

For help with submitting your package, please subscribe and post questions to the bioc-devel mailing list.

bioc-issue-bot commented 7 years ago

Hi @mikejiang

Thanks for submitting your package. We are taking a quick look at it and you will hear back from us soon.

The DESCRIPTION file for this package is:

Package: cytolib
Type: Package
Title: C++ infrastructure for representing and interacting with the gated cytometry
Version: 0.99.0
Date: 2011-06-10
Author: Greg Finak, Mike Jiang
Maintainer: Greg Finak <gfinak@fhcrc.org>,Mike Jiang <wjiang2@fhcrc.org>
Description: This package provides the core data structure and API to represent and interact with the gated cytometry data.
License: Artistic-2.0
LazyLoad: yes
Collate:
    'zzz.R'
Depends:
    R (>= 3.4)
Suggests: knitr
biocViews: FlowCytometry, DataImport, Preprocessing, DataRepresentation
LinkingTo: BH(>= 1.62.0-1), RProtoBufLib
VignetteBuilder: knitr
SystemRequirements: xml2, GNU make, C++11
RoxygenNote: 6.0.1
bioc-issue-bot commented 7 years ago

Your package has been approved for building. Your package is now submitted to our queue.

IMPORTANT: Please read the instructions for setting up a push hook on your repository, or further changes to your repository will NOT trigger a new build.

bioc-issue-bot commented 7 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the following build report for more details:

http://bioconductor.org/spb_reports/cytolib_buildreport_20170807171131.html

mikejiang commented 7 years ago

This package contains the original c++ code from flowWorkspace, cytolib consists of the c++ data structure and its APIs as the infrastructural library for the entire flow cytometry tool chains. flowWorkspace mainly contains the R bindings to the cytolib and the xml parsing. The separation will make it easier to maintain both packages, so that the frequent enhancements and new features are added to flowWorkspace at R level without the unnecessary lengthy C++ re-compilation against those core c++ files.. On other hands, the new extension efforts can also be made directly to cytolib without introducing the unwanted heavy dependencies from flowWorkspace

bioc-issue-bot commented 7 years ago

Received a valid push; starting a build. Commits are:

5d8ef9d rm xml dependency a6d8d1d add getter and setter to the existing class for ea...

bioc-issue-bot commented 7 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the following build report for more details:

http://bioconductor.org/spb_reports/cytolib_buildreport_20170808145856.html

mikejiang commented 7 years ago

@LiNk-NY , I see this false positive error report again, hope it won' affect the process of review

ERROR: Maintainer must subscribe to the bioc-devel mailing list.
LiNk-NY commented 7 years ago

Hi Mike, @mikejiang If you are registered, then I will follow up with Lori (@lshep) about that error because it seems odd. Thanks for submitting your package to Bioconductor. It has been accepted.

Best regards, Marcel

bioc-issue-bot commented 7 years ago

Your package has been accepted. It will be added to the Bioconductor svn repository and nightly builds. Additional information will be sent to the maintainer email address in the next several days.

Thank you for contributing to Bioconductor!

mikejiang commented 7 years ago

@LiNk-NY , is the package still in the queue of bioc devel?Just wondering

LiNk-NY commented 7 years ago

Hi Mike, @mikejiang We are still working on adding the recently accepted packages to the git server. Please stay tuned to the bioc-devel mailing list. Regards, Marcel

mtmorgan commented 7 years ago

The master branch of your GitHub repository has been added to Bioconductor's git repository.

Your ssh public keys have been added from GitHub; you can access your Bioconductor repository using the corresponding private key(s); the command

ssh git@git.bioconductor.org

should include a line like

R W    packages/YOUR_PACKAGE_NAME

indicating read / write access is available.

See further instructions at

https://bioconductor.org/developers/how-to/git/

for working with this repository. See especially

https://bioconductor.org/developers/how-to/git/new-package-workflow/ https://bioconductor.org/developers/how-to/git/sync-existing-repositories/

to keep your GitHub and Bioconductor repositories in sync.

Your package will be included in the next nigthly 'devel' build (check-out from git at about 6 pm Eastern; build completion around 2pm Eastern the next day) at

https://bioconductor.org/checkResults/

(Builds sometimes fail, so ensure that the date stamps on the main landing page are consistent with the addition of your package). Once the package builds successfully, you package will be available for download in the 'Devel' version of Bioconductor using biocLite("YOUR_PACKAGE_NAME"). The package 'landing page' will be created at

https://bioconductor.org/packages/YOUR_PACKAGE_NAME

If you have any questions, please contact the bioc-devel mailing list (https://stat.ethz.ch/mailman/listinfo/bioc-devel); this issue will not be monitored further.