Closed IoannisVardaxis closed 6 years ago
Received a valid push; starting a build. Commits are:
62db6f7 Version update
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
@IoannisVardaxis Why do you have a sysdata.rda file in your R/
directory within your package?
@nturaga Because this is a list of data.frames and each data.frame contains coordinates of black listed regions based on the genome used. I use sysdata to remove input data which overlaps with those coordinates.
Hi,
You have warnings because of the way you are referencing your man pages. (https://cran.r-project.org/doc/manuals/r-release/R-exts.html#Cross_002dreferences).
I think the links are wrong, you want \code{\link[Rbowtie:Rbowtie]{bowtie}}
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Hi, I did as you suggested but I get the same warnings again.
Hi @IoannisVardaxis
Your package looks fine and is ready to be accepted. But the warnings are caused because you reference the wrong files.
\item{object}{An object of \code{\link[InteractionSet:GInteractions]{GInteractions}} class.}
is supposed to be
\item{object}{An object of \code{\link[InteractionSet:GInteractions-class]{GInteractions}} class.}
Take a look the GInteractions-class.Rd file in the InteractionSet package. That's the best way to reference these classes.
I will accept your package as soon as you fix this.
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
I made the changes but I still get error on windows. I will try to fix it in one of the following days.
Note I made a small modification to the Stage_3_PeakFinderSubFunctions such that it returns four more parameters which I am going to need on a later update after the package is accepted. So i also needed to update vignette and the data for documenting those four parameters. But the changes are not big.
@IoannisVardaxis Thanks. Once you are done fixing them, let me know.
Received a valid push; starting a build. Commits are:
3d42e46 Tring to fix the windows errors
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
b02ae72 Trying to fix the windows error for the Rbowtie
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details.
@nturaga now everything seems to be ok! Thank you for your help!
Your package has been accepted. It will be added to the Bioconductor Git repository and nightly builds. Additional information will be sent to the maintainer email address in the next several days.
Thank you for contributing to Bioconductor!
The master branch of your GitHub repository has been added to Bioconductor's git repository.
To use the git.bioconductor.org repository, we need an 'ssh' key to associate with your github user name. If your GitHub account already has ssh public keys (https://github.com/IoannisVardaxis.keys is not empty), then no further steps are required. Otherwise, do the following:
See further instructions at
https://bioconductor.org/developers/how-to/git/
for working with this repository. See especially
https://bioconductor.org/developers/how-to/git/new-package-workflow/ https://bioconductor.org/developers/how-to/git/sync-existing-repositories/
to keep your GitHub and Bioconductor repositories in sync.
Your package will be included in the next nigthly 'devel' build (check-out from git at about 6 pm Eastern; build completion around 2pm Eastern the next day) at
https://bioconductor.org/checkResults/
(Builds sometimes fail, so ensure that the date stamps on the main landing page are consistent with the addition of your package). Once the package builds successfully, you package will be available for download in the 'Devel' version of Bioconductor using biocLite(\"MACPET\")
. The package 'landing page' will be created at
https://bioconductor.org/packages/MACPET
If you have any questions, please contact the bioc-devel mailing list (https://stat.ethz.ch/mailman/listinfo/bioc-devel); this issue will not be monitored further.
Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor
Confirm the following by editing each check box to '[x]'
[x] I understand that by submitting my package to Bioconductor, the package source and all review commentary are visible to the general public.
[x] I have read the Bioconductor Package Submission instructions. My package is consistent with the Bioconductor Package Guidelines.
[x] I understand that a minimum requirement for package acceptance is to pass R CMD check and R CMD BiocCheck with no ERROR or WARNINGS. Passing these checks does not result in automatic acceptance. The package will then undergo a formal review and recommendations for acceptance regarding other Bioconductor standards will be addressed.
[x] My package addresses statistical or bioinformatic issues related to the analysis and comprehension of high throughput genomic data.
[x] I am committed to the long-term maintenance of my package. This includes monitoring the support site for issues that users may have, subscribing to the bioc-devel mailing list to stay aware of developments in the Bioconductor community, responding promptly to requests for updates from the Core team in response to changes in R or underlying software.
I am familiar with the essential aspects of Bioconductor software management, including:
For help with submitting your package, please subscribe and post questions to the bioc-devel mailing list.