Closed Jialab-UCR closed 6 years ago
Hi @Jialab-UCR
Thanks for submitting your package. We are taking a quick look at it and you will hear back from us soon.
The DESCRIPTION file for this package is:
Package: GDCRNATools
Title: GDCRNATools: an R/Bioconductor package for integrative analysis of lncRNA, mRNA, and miRNA data in GDC
Version: 0.99.0
Author: Ruidong Li,
Han Qu,
Shibo Wang,
Julong Wei,
Le Zhang,
Jianming Lu,
Zhenyu Jia
Maintainer: Ruidong Li <rli012@ucr.edu>,
Han Qu <hqu002@ucr.edu>
Description: This is an easy-to-use package for downloading, organizing, and integrative analyzing RNA expression
data in GDC with an emphasis on deciphering the lncRNA-mRNA related ceRNA regulatory network in cancer.
Three databases of lncRNA-miRNA interactions including spongeScan, starBase, and miRcode, as well as three
databases of mRNA-miRNA interactions including miRTarBase, starBase, and miRcode are incorporated into the
package for ceRNAs network construction. limma, edgeR, and DESeq2 can be used to identify differentially
expressed genes/miRNAs. Functional enrichment analyses including GO, KEGG, and DO can be performed based on
the clusterProfiler and DO packages. Both univariate CoxPH and KM survival analyses of multiple genes can be
implemented in the package. Besides some routine visualization functions such as volcano plot, bar plot, and
KM plot, a few simply shiny apps are developed to facilitate visualization of results on a local webpage.
Depends: R (>= 3.3.0)
License: Artistic-2.0
Encoding: UTF-8
LazyData: true
Imports: shiny,
jsonlite,
rjson,
XML,
limma,
edgeR,
DESeq2,
clusterProfiler,
DOSE,
org.Hs.eg.db,
biomaRt,
survival,
survminer,
pathview,
ggplot2,
gplots,
BiocParallel
Suggests: knitr,
testthat
VignetteBuilder: knitr
biocViews: GeneExpression, DifferentialExpression, GeneRegulation, GeneTarget,
NetworkInference, Survival, Visualization, GeneSetEnrichment,
NetworkEnrichment, Network, RNASeq, GO, KEGG
RoxygenNote: 6.0.1
NeedsCompilation: no
Packaged: 2017-11-16 09:35:10 UTC; biocbuild
Your package has been approved for building. Your package is now submitted to our queue.
IMPORTANT: Please read the instructions for setting up a push hook on your repository, or further changes to your repository will NOT trigger a new build.
Seems like there are a lot of opportunities for synergy with GenomicDataCommons @seandavi
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the following build report for more details:
http://bioconductor.org/spb_reports/GDCRNATools_buildreport_20171201205524.html
Received a valid push; starting a build. Commits are:
8ee5c62 version bump Updated R version dependency from 3....
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
Congratulations! The package built without errors or warnings on all platforms.
Please see the following build report for more details:
http://bioconductor.org/spb_reports/GDCRNATools_buildreport_20171202224827.html
Please remember to increment the version of your package to trigger a new build; I'll review the package one no version bump is required.
Received a valid push; starting a build. Commits are:
f9b637e version bump
@mtmorgan Hi Morgan, really appreciate your help. I have made a build. Thanks again~
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
Congratulations! The package built without errors or warnings on all platforms.
Please see the following build report for more details:
http://bioconductor.org/spb_reports/GDCRNATools_buildreport_20171210203547.html
Received a valid push; starting a build. Commits are:
103c7de version bump
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
Congratulations! The package built without errors or warnings on all platforms.
Please see the following build report for more details:
http://bioconductor.org/spb_reports/GDCRNATools_buildreport_20171217204223.html
Received a valid push; starting a build. Commits are:
19087f5 version bump
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "
Error code 414.
Message: Request-URI Too Long.
Error code explanation: 414 = URI is too long.. ". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself. Please see the following build report for more details: http://bioconductor.org/spb_reports/GDCRNATools_buildreport_20171217210546.html
Received a valid push; starting a build. Commits are:
be02ea5 Update DESCRIPTION
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
Congratulations! The package built without errors or warnings on all platforms.
Please see the following build report for more details:
http://bioconductor.org/spb_reports/GDCRNATools_buildreport_20171217212344.html
@mtmorgan Hi Martin, is it ready for me to make revisions on the package? Thanks
Sorry for the delay.
DESCRIPTION
Vignette
Please update the installation instructions to be those after acceptance in Bioconductor, i.e.,
source("https://bioconductor.org/biocLite.R")
biocLite("GDCRNATools")
Instead of downloading data to arbitrary locations on the user's computer, consider using BiocFileCache and in particular using this in the vignette, so that the builders only access the data periodically rather than each night. The code chunks can then be marked as eval=TRUE
. This is important because the code chunks marked eval = FALSE
frequently become out-of-date, e.g, from the vignette
gdcRNADownload(manifest = 'TCGA-PRAD/TCGA-PRAD.RNAseq.gdc_manifest.2017-11-23T14-40-52.txt',
directory = 'TCGA-PRAD/RNAseq')
##############################################################################
Pathview is an open source software package distributed under GNU General
Public License version 3 (GPLv3). Details of GPLv3 is available at
http://www.gnu.org/licenses/gpl-3.0.html. Particullary, users are required to
formally cite the original Pathview paper (not just mention it) in publications
or products. For details, do citation("pathview") within R.
The pathview downloads and uses KEGG data. Non-academic uses may require a KEGG
license agreement (details at http://www.kegg.jp/kegg/legal.html).
##############################################################################
>
+ trying URL 'https://gdc.cancer.gov/system/files/authenticated%20user/0/gdc-client_v1.3.0_Ubuntu14.04_x64.zip'
Content type 'application/zip' length 24647158 bytes (23.5 MB)
==================================================
downloaded 23.5 MB
arguments 'minimized' and 'invisible' are for Windows only
Error in file(file, "rt") : cannot open the connection
In addition: Warning message:
In file(file, "rt") :
cannot open file 'TCGA-PRAD/TCGA-PRAD.RNAseq.gdc_manifest.2017-11-23T14-40-52.txt': No such file or directory
Generally, the large number of eval = FALSE
chunks is not acceptable. Likely re-using already downloaded data (via BiocFileCache) and careful choice of data sets for analysis will make it possible to more completely evaluate code in the vignette.
Consider Suggest:ing and using RCy3 for cytoscape-based network visualization.
R
Is there an opporutnity to re-use functionality from the GenomicDataCommons package, rather than re-inventing the software?
Use message()
instead of cat()
to communicate with the user; consider one call to message()
rather than two or more, and consider that too much enthusiasm can be tiring, e.g, gdcCEAnalysis.R:68 (hmm, not sure where step 3 is done?)
message (
'Step 2/3: Correlation analysis done',
'\nStep 3/3: Regulation pattern analysis done'
)
gdcCEAnalysis.R:207 and throughput: use vapply()
rather than sapply()
, and seq_len()
or seq_along()
rather than 1:n
(to avoid problems when n = 0 or the argument is of length 0 (and sapply()
returns a list()
!)).
Consider an indentation style that provides constant amounts of indentation and allows for longer lines, e.g., gdcDEGVisulization.R:28
d <- data.frame(
geneClass = c('Up','Down'),
geneNums = c(up, down),
Regulation = factor(
c('Up-regulated','Down-regulated'),
levels=c('Up-regulated','Down-regulated')
)
)
Received a valid push; starting a build. Commits are:
2778d08 Update DESCRIPTION
Received a valid push; starting a build. Commits are:
4adea79 Version bump
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
982de7b revision
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
0d4ad7d Update DESCRIPTION
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
1b906f6 revision
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
59d2fb2 version bump
Received a valid push; starting a build. Commits are:
4410915 Update DESCRIPTION
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details.
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details.
Hi @mtmorgan Thank you so much for your help on the improvement of the package. I have learned a lot. I have made some changes according to your suggestions:
Vignette
The installation instructions have been updated to:
source("https://bioconductor.org/biocLite.R")
biocLite("GDCRNATools")
The vignette has been re-designed. More chunks are changed to eval=TRUE
. Only those require long time or cost large memory are kept eval=FALSE
.
Because the edges and nodes files exported by the exportNetwork
function can be easily imported to Cytoscape, so I didn't use RCy3
for the network visualization. I do try it, but the output doesn't look good.
R
Really appreciate your suggestions of using GenomicDataCommons
package, which is an excellent package for accessing GDC data. I have modified the gdcRNADownload
and gdcClinicalDownload
functions in my package to use the API method in GenomicDataCommons as default method for data download.
All cat()
are replaced with message()
All sapply()
are replaced with vapply(),
and 1:n
are replaced with seq_len(n)
Multiples of 4 spaces are used for line indents. Long lines are shortened to < 80 characters.
Again, thanks a lot for your help.
Best, Ruidong
Your package has been accepted. It will be added to the Bioconductor Git repository and nightly builds. Additional information will be sent to the maintainer email address in the next several days.
Thank you for contributing to Bioconductor!
The master branch of your GitHub repository has been added to Bioconductor's git repository.
To use the git.bioconductor.org repository, we need an 'ssh' key to associate with your github user name. If your GitHub account already has ssh public keys (https://github.com/Jialab-UCR.keys is not empty), then no further steps are required. Otherwise, do the following:
See further instructions at
https://bioconductor.org/developers/how-to/git/
for working with this repository. See especially
https://bioconductor.org/developers/how-to/git/new-package-workflow/ https://bioconductor.org/developers/how-to/git/sync-existing-repositories/
to keep your GitHub and Bioconductor repositories in sync.
Your package will be included in the next nigthly 'devel' build (check-out from git at about 6 pm Eastern; build completion around 2pm Eastern the next day) at
https://bioconductor.org/checkResults/
(Builds sometimes fail, so ensure that the date stamps on the main landing page are consistent with the addition of your package). Once the package builds successfully, you package will be available for download in the 'Devel' version of Bioconductor using biocLite(\"GDCRNATools\")
. The package 'landing page' will be created at
https://bioconductor.org/packages/GDCRNATools
If you have any questions, please contact the bioc-devel mailing list (https://stat.ethz.ch/mailman/listinfo/bioc-devel); this issue will not be monitored further.
Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor
Confirm the following by editing each check box to '[x]'
[x] I understand that by submitting my package to Bioconductor, the package source and all review commentary are visible to the general public.
[x] I have read the Bioconductor Package Submission instructions. My package is consistent with the Bioconductor Package Guidelines.
[x] I understand that a minimum requirement for package acceptance is to pass R CMD check and R CMD BiocCheck with no ERROR or WARNINGS. Passing these checks does not result in automatic acceptance. The package will then undergo a formal review and recommendations for acceptance regarding other Bioconductor standards will be addressed.
[x] My package addresses statistical or bioinformatic issues related to the analysis and comprehension of high throughput genomic data.
[x] I am committed to the long-term maintenance of my package. This includes monitoring the support site for issues that users may have, subscribing to the bioc-devel mailing list to stay aware of developments in the Bioconductor community, responding promptly to requests for updates from the Core team in response to changes in R or underlying software.
I am familiar with the essential aspects of Bioconductor software management, including:
For help with submitting your package, please subscribe and post questions to the bioc-devel mailing list.