Bioconductor / Contributions

Contribute Packages to Bioconductor
134 stars 33 forks source link

ddPCRclust #575

Closed bgbrink closed 6 years ago

bgbrink commented 6 years ago

Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor

Confirm the following by editing each check box to '[x]'

I am familiar with the essential aspects of Bioconductor software management, including:

For help with submitting your package, please subscribe and post questions to the bioc-devel mailing list.

LiNk-NY commented 6 years ago

Please fix the errors and I will accept your package. Thanks.

bioc-issue-bot commented 6 years ago

Received a valid push; starting a build. Commits are:

69abd26 v0.99.14 examples fix

bioc-issue-bot commented 6 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "skipped, WARNINGS, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bgbrink commented 6 years ago

Hi Marcel, @LiNk-NY

thank you very much. I will definitely keep it in mind for future versions of ddPCRclust and, more importantly, for any other R packages that I might develop in the future. I definitely learned a lot during this review process.

Lastly, I cannot reproduce the error on Windows i386 architecture, cause we have no such machine available to us. Is it possible to mark somewhere that the package requires x64 to run? Otherwise I will set up a VM for debugging.

Thanks for your time!

LiNk-NY commented 6 years ago

Hi Benedikt, @bgbrink

We prefer that the package be supported on both Windows architectures. You can try using appveyor to check your package on the Windows platforms if it is easier.

Regards, Marcel

LiNk-NY commented 6 years ago

Please disregard the martini issue reference. It was a typo. Best, Marcel

bgbrink commented 6 years ago

Hi Marcel, @LiNk-NY

I set up a VM with Windows 10 and also followed your advice and built the package with appveyor (https://ci.appveyor.com/project/bgbrink/ddpcrclust). I can not reproduce the error in any case, all test run though just fine on both i386 and x64.

LiNk-NY commented 6 years ago

Hi Benedikt, @bgbrink

Thanks for looking into it and providing the link! I will mark your package as accepted. Thank you for your submission!

Best regards, Marcel

bioc-issue-bot commented 6 years ago

Your package has been accepted. It will be added to the Bioconductor Git repository and nightly builds. Additional information will be sent to the maintainer email address in the next several days.

Thank you for contributing to Bioconductor!

bgbrink commented 6 years ago

Hi Marcel, @LiNk-NY

thank you for this constructive review process. As promised, I just changed the license to Artistic-2.0. Thank you for your patience!

mtmorgan commented 6 years ago

The master branch of your GitHub repository has been added to Bioconductor's git repository.

To use the git.bioconductor.org repository, we need an 'ssh' key to associate with your github user name. If your GitHub account already has ssh public keys (https://github.com/bgbrink.keys is not empty), then no further steps are required. Otherwise, do the following:

  1. Add an SSH key to your github account
  2. Submit your SSH key to Bioconductor

See further instructions at

https://bioconductor.org/developers/how-to/git/

for working with this repository. See especially

https://bioconductor.org/developers/how-to/git/new-package-workflow/ https://bioconductor.org/developers/how-to/git/sync-existing-repositories/

to keep your GitHub and Bioconductor repositories in sync.

Your package will be included in the next nigthly 'devel' build (check-out from git at about 6 pm Eastern; build completion around 2pm Eastern the next day) at

https://bioconductor.org/checkResults/

(Builds sometimes fail, so ensure that the date stamps on the main landing page are consistent with the addition of your package). Once the package builds successfully, you package will be available for download in the 'Devel' version of Bioconductor using biocLite(\"ddPCRclust\"). The package 'landing page' will be created at

https://bioconductor.org/packages/ddPCRclust

If you have any questions, please contact the bioc-devel mailing list (https://stat.ethz.ch/mailman/listinfo/bioc-devel); this issue will not be monitored further.