Closed zhouzilu closed 6 years ago
Hi @zhouzilu
Thanks for submitting your package. We are taking a quick look at it and you will hear back from us soon.
The DESCRIPTION file for this package is:
Package: iCNV
Title: Integrated Copy Number Variation detection
Version: 0.0.2
Authors@R: c(person("Zilu", "Zhou", email = "zhouzilu@pennmedicine.upenn.edu", role = c("aut", "cre")),
person('Nancy','Zhang', email='nzh@wharton.upenn.edu'), role = c("aut"))
Author: Zilu Zhou, Nancy Zhang
Maintainer: Zilu Zhou <zhouzilu@pennmedicine.upenn.edu>
Description: Integrative copy number variation (CNV) detection from multiple platform and experimental design.
Depends: R (>= 3.3.1)
License: GPL-2
Encoding: UTF-8
LazyData: true
RoxygenNote: 6.0.1
Imports:
fields,
ggplot2,
truncnorm,
tidyr,
data.table,
dplyr
Suggests: knitr,
rmarkdown
VignetteBuilder: knitr
biocViews: ExomeSeq, WholeGenome, SNP, CopyNumberVariation, HiddenMarkovModel
Before being added to our moderation and review queue, your package needs to be updated to (a) interoperate with existing Bioconductor sequence-related packages, e.g., GenomicRanges, Summarized Experiment and (b) have a 'real' vignette with evaluated code chunks, rather than a static vignette with 'pictures of code'.
Please update your package in this way, and post a short comment indicating that it is now ready to be reviewed to this issue, mentioning @mtmorgan .
@mtmorgan Hi Martin, Thank you for the review. I actually had a few questions regarding to your comments.
Thanks
These are not review comments, but rather 'pre-review', before a review is possible.
Usually interoperability involves adding Bioconductor packages to the Depends: or Imports: fields of the DESCRIPTION file, coupled with appropriate use of Bioconductor data structures particularly as argument or return values to the functions that your package defines. Use of Bioconductor structures inside a package is at the discretion of a package author.
Usually vignettes are based on realistic but trimmed-down data (e.g., part of a chromosome) that does fit into the package guidelines for space and size, or that re-uses an existing 'ExperimentData' package; it is sometimes appropriate to also submit a new ExperimentData package or ExperimentHub resource (there is a vignette in the ExperimentHub package describing how resources can be contributed).
Thank you. I will modify my github site and will let you know.
Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor
Confirm the following by editing each check box to '[x]'
[x] I understand that by submitting my package to Bioconductor, the package source and all review commentary are visible to the general public.
[x] I have read the Bioconductor Package Submission instructions. My package is consistent with the Bioconductor Package Guidelines.
[ x] I understand that a minimum requirement for package acceptance is to pass R CMD check and R CMD BiocCheck with no ERROR or WARNINGS. Passing these checks does not result in automatic acceptance. The package will then undergo a formal review and recommendations for acceptance regarding other Bioconductor standards will be addressed.
[ x] My package addresses statistical or bioinformatic issues related to the analysis and comprehension of high throughput genomic data.
[ x] I am committed to the long-term maintenance of my package. This includes monitoring the support site for issues that users may have, subscribing to the bioc-devel mailing list to stay aware of developments in the Bioconductor community, responding promptly to requests for updates from the Core team in response to changes in R or underlying software.
I am familiar with the essential aspects of Bioconductor software management, including:
For help with submitting your package, please subscribe and post questions to the bioc-devel mailing list.