search

Bioconductor / Contributions

Contribute Packages to Bioconductor
135 stars 33 forks source link

iCNV #654

Closed zhouzilu closed 6 years ago

zhouzilu commented 6 years ago

Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor

Confirm the following by editing each check box to '[x]'

I am familiar with the essential aspects of Bioconductor software management, including:

For help with submitting your package, please subscribe and post questions to the bioc-devel mailing list.

bioc-issue-bot commented 6 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 6 years ago

Received a valid push; starting a build. Commits are:

01deeed update rlang

bioc-issue-bot commented 6 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 6 years ago

Received a valid push; starting a build. Commits are:

aba33f0 fix bug in visualization2 version bump

bioc-issue-bot commented 6 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

zhouzilu commented 6 years ago

Hi Qian @Liubuntu ,

I have finished. Please take a look at them.

Thank you again! Zilu

Liubuntu commented 6 years ago

Hi @zhouzilu

Thanks for making the changes. 2 questions:

Also please make sure all your data inside "inst/extdata" and "data/" are used in your package and remove anything that is not needed.

Cheers, Qian

zhouzilu commented 6 years ago

Hi Qian @Liubuntu Thank you so much for your comment! Regarding the first question, now I understand why this is necessary after reading your comments again. I am on it. About second question, you are absolutely right!

For the data in inst/extdata and data/, they are all important files for vignette and example files. I have to keep it that way.

I will bump the version and reply to you once everything is finished.

Zilu

bioc-issue-bot commented 6 years ago

Received a valid push; starting a build. Commits are:

538c6cf Update Bioconductor - Add parameter type - get_...

bioc-issue-bot commented 6 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

zhouzilu commented 6 years ago

@Liubuntu I have add default parameter type if there isn't any default value (except couple complex list). Please let me know what to do to proceed.

Liubuntu commented 6 years ago

Hi @zhouzilu ,

You package is accepted. Thanks for your contribution to Bioconductor and efforts in addressing technical review issues. Wish you success in your future career.

Cheers! Qian

bioc-issue-bot commented 6 years ago

Your package has been accepted. It will be added to the Bioconductor Git repository and nightly builds. Additional information will be posed to this issue in the next several days.

Thank you for contributing to Bioconductor!

zhouzilu commented 6 years ago

Hi Qian, @Liubuntu

Thank you so much! It was nice working with you. Good luck to you, too.

Zilu

mtmorgan commented 6 years ago

The master branch of your GitHub repository has been added to Bioconductor's git repository.

To use the git.bioconductor.org repository, we need an 'ssh' key to associate with your github user name. If your GitHub account already has ssh public keys (https://github.com/zhouzilu.keys is not empty), then no further steps are required. Otherwise, do the following:

  1. Add an SSH key to your github account
  2. Submit your SSH key to Bioconductor

See further instructions at

https://bioconductor.org/developers/how-to/git/

for working with this repository. See especially

https://bioconductor.org/developers/how-to/git/new-package-workflow/ https://bioconductor.org/developers/how-to/git/sync-existing-repositories/

to keep your GitHub and Bioconductor repositories in sync.

Your package will be included in the next nigthly 'devel' build (check-out from git at about 6 pm Eastern; build completion around 2pm Eastern the next day) at

https://bioconductor.org/checkResults/

(Builds sometimes fail, so ensure that the date stamps on the main landing page are consistent with the addition of your package). Once the package builds successfully, you package will be available for download in the 'Devel' version of Bioconductor using biocLite(\"iCNV\"). The package 'landing page' will be created at

https://bioconductor.org/packages/iCNV

If you have any questions, please contact the bioc-devel mailing list (https://stat.ethz.ch/mailman/listinfo/bioc-devel); this issue will not be monitored further.