Closed OscarBrock closed 7 years ago
Hi @OscarBrock
Thanks for submitting your package. We are taking a quick look at it and you will hear back from us soon.
The DESCRIPTION file for this package is:
Package: gCrisprTools
Type: Package
Title: Suite of Functions for Pooled Crispr Screen QC and Analysis
Version: 0.99.0
Date: 2016-07-19
Author: Russell Bainer, Dariusz Ratman, Pete Haverty, Steve Lianoglou
Maintainer: Russell Bainer <bainer.russell@gene.com>
Description: Set of tools for evaluating pooled high-throughput screening experiments,
typically employing CRISPR/Cas9 or shRNA expression cassettes. Contains methods for interrogating
library and cassette behavior within an experiment, identifying differentially abundant
cassettes, aggregating signals to identify candidate targets for empirical validation,
hypothesis testing, and comprehensive reporting.
License: Artistic-2.0
Imports:
Biobase,
limma,
RobustRankAggreg,
ggplot2,
parallel,
PANTHER.db,
BiocParallel
Suggests:
ExpressionPlot,
ExpressionCore,
edgeR,
knitr,
rmarkdown,
grid,
AnnotationDbi
RoxygenNote: 5.0.1
VignetteBuilder: knitr
biocViews:
Crispr,
PooledScreens,
ExperimentalDesign,
BiomedicalInformatics,
CellBiology,
FunctionalGenomics,
Pharmacogenomics,
Pharmacogenetics,
SystemsBiology,
DifferentialExpression,
GeneSetEnrichment,
Genetics,
MultipleComparison,
Normalization,
Preprocessing,
QualityControl,
RNASeq,
Regression,
Software,
Visualization
Your package has been approved for building. Your package is now submitted to our queue.
IMPORTANT: Please read the instructions for setting up a push hook on your repository, or further changes to your repository will NOT trigger a new build.
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the following build report for more details:
http://bioconductor.org/spb_reports/gCrisprTools_buildreport_20160719164608.html
We only start builds when the Version
field in the DESCRIPTION
file is incremented. For example, by changing
Version: 0.99.0
to
Version 0.99.1
If you did not intend to start a build, you don't need to
do anything. If you did want to start a build, increment
the Version:
field and try again.
We only start builds when the Version
field in the DESCRIPTION
file is incremented. For example, by changing
Version: 0.99.0
to
Version 0.99.1
If you did not intend to start a build, you don't need to
do anything. If you did want to start a build, increment
the Version:
field and try again.
Received a valid push; starting a build. Commits are:
a2f9d75 Update DESCRIPTION
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "skipped, ERROR, WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the following build report for more details:
http://bioconductor.org/spb_reports/gCrisprTools_buildreport_20160719172036.html
We only start builds when the Version
field in the DESCRIPTION
file is incremented. For example, by changing
Version: 0.99.0
to
Version 0.99.1
If you did not intend to start a build, you don't need to
do anything. If you did want to start a build, increment
the Version:
field and try again.
We only start builds when the Version
field in the DESCRIPTION
file is incremented. For example, by changing
Version: 0.99.0
to
Version 0.99.1
If you did not intend to start a build, you don't need to
do anything. If you did want to start a build, increment
the Version:
field and try again.
Received a valid push; starting a build. Commits are:
6026453 Update DESCRIPTION
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "skipped, ERROR, WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the following build report for more details:
http://bioconductor.org/spb_reports/gCrisprTools_buildreport_20160719180021.html
We only start builds when the Version
field in the DESCRIPTION
file is incremented. For example, by changing
Version: 0.99.0
to
Version 0.99.1
If you did not intend to start a build, you don't need to
do anything. If you did want to start a build, increment
the Version:
field and try again.
We only start builds when the Version
field in the DESCRIPTION
file is incremented. For example, by changing
Version: 0.99.0
to
Version 0.99.1
If you did not intend to start a build, you don't need to
do anything. If you did want to start a build, increment
the Version:
field and try again.
Received a valid push; starting a build. Commits are:
01f69a4 Update DESCRIPTION
It looks to me like something might be going on with the windows host? I got a check error on that host that I tried to work around, but it doesn't seem to have fixed things.
The error seems to suggest that I'm not able to load the org.Mm.eg.db library on that host, and unfortunately I don't have access to a windows machine to troubleshoot this issue. Can anyone suggest a fix? The code that is causing the error is:
org.pkg <- "org.Mm.eg.db"
if (!requireNamespace(org.pkg)) {
stop(org.pkg, " bioconductor package required for this species query")
}
Thanks,
-Russ
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the following build report for more details:
http://bioconductor.org/spb_reports/gCrisprTools_buildreport_20160719182106.html
org.Mm.eg.db
just happens to be loaded on the Mac and Linux build machines but it's not loaded on windows because you have not specified that it needs to be in the DESCRIPTION
file. The package should be in the Imports
, Depends
, or Suggests
field of that file (perhaps Suggests
, since you are using the package in an example).
Ah, thanks so much. Updating now. -R
We only start builds when the Version
field in the DESCRIPTION
file is incremented. For example, by changing
Version: 0.99.0
to
Version 0.99.1
If you did not intend to start a build, you don't need to
do anything. If you did want to start a build, increment
the Version:
field and try again.
Received a valid push; starting a build. Commits are:
00d5d22 Update DESCRIPTION
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the following build report for more details:
http://bioconductor.org/spb_reports/gCrisprTools_buildreport_20160719200855.html
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the following build report for more details:
http://bioconductor.org/spb_reports/gCrisprTools_buildreport_20160719221231.html
We only start builds when the Version
field in the DESCRIPTION
file is incremented. For example, by changing
Version: 0.99.0
to
Version 0.99.1
If you did not intend to start a build, you don't need to
do anything. If you did want to start a build, increment
the Version:
field and try again.
Hi, just wanted to be sure that everything is proceeding properly at this point- it's my first submission to Bioc.
I'm catching a warning in check for uncompressed data, which I think is unavoidable on my end for an unbuilt package... if I need to be doing something else, please let me know.
-R
Hello,
Thank you for letting me know. The last updated seemed to be a push without a version bump so I wasn't sure if you were still making changes. I will review your package and comment with any questions shortly.
Lori
Thanks!
Sorry, forgot the version bump. As I say, I'm new to this.
-R
On Tue, Jul 26, 2016 at 9:59 AM, lshep notifications@github.com wrote:
Hello, Thank you for letting me know. The last updated seemed to be a push without a version bump so I wasn't sure if you were still making changes. I will review your package and comment with any questions shortly.
Lori
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Bioconductor/Contributions/issues/67#issuecomment-235333916, or mute the thread https://github.com/notifications/unsubscribe-auth/AObUqXvwq362BIOQBUwAmk2weovC6A-Yks5qZj0NgaJpZM4JQJAZ .
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the following build report for more details:
http://bioconductor.org/spb_reports/gCrisprTools_buildreport_20160727100931.html
Thank you for your submission. Below are some suggestions and comments.
GENERAL: In general we like the built package tar to be under 4M. Have you compressed your data included in the package when saving it? (i.e save(object, file=filename, compress=TRUE))
NAMESPACE: Please consider adding the imports suggested from the build report to fix the no visible global function definition notes. Consider adding importFrom("grDevices", "colorRampPalette", "rgb") importFrom("graphics", "abline", "axis", "barplot", "layout", "legend", "lines", "mtext", "par", "plot", "points", "polygon", "segments") importFrom("stats", "density", "lm", "median", "na.omit", "p.adjust", "pbeta", "phyper", "predict", "pt", "smooth.spline") importFrom("utils", "capture.output", "getFromNamespace")
Also consider fixing the no visible binding for global variables. See ?globalVariables
in an R session
R CODE: You should not need "::" . These librarys are listed in the DESCRIPTION depends and are imported so there is no need for the "::" , you can call the functions directly.
MAN:
\code{edgeR::calcNormFactors}
, consider changing to \link[edgeR::calcNormFactors]{calcNormFactors}
. VIGNETTE: gCrisprTools_Vignette.Rmd
source("https://bioconductor.org/biocLite.R")
biocLite("gCrisprTools")
DOCUMENTATION/VIGNETTE:
Generally vignettes are the documentation type in the vignette directory.
The gCrisprTools_packagedesign.pptx should probably be moved into inst/ directory (perhaps inst/scripts) as well as Mageck&_gCrisprTools.html. Could you make your Crispr_example_workflow.R a vignette too? Else it should also be moved to the inst directory. Also for the workflow.R, again you should remove the "::" as the functions will be available after the library(package) invocation.
Cheers, Lori
Thanks very much for your helpful and timely comments. Please see the newer version in the repository.
-R
On Fri, Jul 29, 2016 at 4:45 AM, lshep notifications@github.com wrote:
Thank you for your submission. Below are some suggestions and comments.
GENERAL: In general we like the built package tar to be under 4M. Have you compressed your data included in the package when saving it? (i.e save(object, file=filename, compress=TRUE))
NAMESPACE: Please consider adding the imports suggested from the build report to fix the no visible global function definition notes. Consider adding importFrom("grDevices", "colorRampPalette", "rgb") importFrom("graphics", "abline", "axis", "barplot", "layout", "legend", "lines", "mtext", "par", "plot", "points", "polygon", "segments") importFrom("stats", "density", "lm", "median", "na.omit", "p.adjust", "pbeta", "phyper", "predict", "pt", "smooth.spline") importFrom("utils", "capture.output", "getFromNamespace")
Also consider fixing the no visible binding for global variables. See ?globalVariables in an R session
R CODE: You should not need "::" . These librarys are listed in the DESCRIPTION depends and are imported so there is no need for the "::" , you can call the functions directly.
MAN:
- In examples, please use library(packageName) rather than packageName::function(). If you did a library call than there is no need for the "::"
- For Internal use only functions please add \keyword{internal} to the man page.
- Considering make links to the package functions including those from other packages when describing or referencing. An example, the item description for lib.size in ct.normalizeNTC.Rd, has \code{edgeR::calcNormFactors}, consider changing to \link[edgeR::calcNormFactors]{calcNormFactors}.
VIGNETTE: gCrisprTools_Vignette.Rmd
- Please add a table of contents
- There is a type on section 1.1 Ass = As
- Please remove "::", you shouldn't need these since you have the library calls.
- Please add an installation section
source("https://bioconductor.org/biocLite.R") biocLite("gCrisprTools")
DOCUMENTATION/VIGNETTE: Generally vignettes are the documentation type in the vignette directory.
The gCrisprTools_packagedesign.pptx should probably be moved into inst/ directory (perhaps inst/scripts) as well as Mageck&_gCrisprTools.html. Could you make your Crispr_example_workflow.R a vignette too? Else it should also be moved to the inst directory. Also for the workflow.R, again you should remove the "::" as the functions will be available after the library(package) invocation.
Cheers, Lori
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Bioconductor/Contributions/issues/67#issuecomment-236160275, or mute the thread https://github.com/notifications/unsubscribe-auth/AObUqWRSwtieYHoniDkbti7D_SrPAKmtks5qaefqgaJpZM4JQJAZ .
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "skipped, ERROR, WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the following build report for more details:
http://bioconductor.org/spb_reports/gCrisprTools_buildreport_20160801194606.html
In case it wasn't clear, I'm still catching an error on the windows machine. Please let me know if there is something I can do on my end to help with that.
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the following build report for more details:
http://bioconductor.org/spb_reports/gCrisprTools_buildreport_20160803101533.html
Hello,
As far as the windows ERROR: It seems like it is failing in the example in the man page for ct.generateResults . Does the code use any C code? It might be a bug there. If not, there may also be an issue with time out. It looks like the example (as well as some of the other examples) take a fairly long time to run. Is there any way to speed these up? See the elapsed time from the previous build that ran.
Thank you for making the other changes.
For the vignette Crispr_example_workflow.Rmd, Please remove "::" and call the functions directly.
Not sure what this error is either- some sort of failure while checking the CRAN repository?
-R
On Wed, Aug 3, 2016 at 7:49 AM, bioc-issue-bot notifications@github.com wrote:
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the following build report for more details:
http://bioconductor.org/spb_reports/gCrisprTools_buildreport_20160803101533.html
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Bioconductor/Contributions/issues/67#issuecomment-237248856, or mute the thread https://github.com/notifications/unsubscribe-auth/AObUqeO17h7ZjSmO2zsgNhUdJn3-E0Vpks5qcKqEgaJpZM4JQJAZ .
We are working on this new error to try to figure out why it is occurring.
Ah, I didn't realize that there was a timeoput. That function takes a little while to finish, I will modify the example code (and vignette) for the next commit.
-R
On Wed, Aug 3, 2016 at 10:56 AM, lshep notifications@github.com wrote:
We are working on this new error to try to figure out why it is occurring.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Bioconductor/Contributions/issues/67#issuecomment-237311308, or mute the thread https://github.com/notifications/unsubscribe-auth/AObUqc2aEWWUl75RbW0d3xi6z9cDUIy2ks5qcNZqgaJpZM4JQJAZ .
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the following build report for more details:
http://bioconductor.org/spb_reports/gCrisprTools_buildreport_20160804200702.html
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the following build report for more details:
http://bioconductor.org/spb_reports/gCrisprTools_buildreport_20160804233711.html
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the following build report for more details:
http://bioconductor.org/spb_reports/gCrisprTools_buildreport_20160810102357.html
Hello, I just wanted to check in on the progress with this. I think that the warnings are not avoidable, as they refer to resaving data during package build (which happens on your end).
Thanks in advance,
-R
On Wed, Aug 10, 2016 at 7:22 AM, bioc-issue-bot notifications@github.com wrote:
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the following build report for more details:
http://bioconductor.org/spb_reports/gCrisprTools_ buildreport_20160810102357.html
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Bioconductor/Contributions/issues/67#issuecomment-238882175, or mute the thread https://github.com/notifications/unsubscribe-auth/AObUqUMZisexqr3p2YlQx4IgsCIvTF6Vks5qed6rgaJpZM4JQJAZ .
They are avoidable. Run
R CMD build --resave-data gCrisprTools
This will create a tarball that has the data files compressed as small as possible. Untar this file and copy the data files in it over the ones in your git working copy, then recommit those, with a version bump.
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR, WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the following build report for more details:
http://bioconductor.org/spb_reports/gCrisprTools_buildreport_20160810153929.html
Hi, tried to make the specified update but now the build results are listed as ERROR, WARNINGS- the warnings appear to refer to notes and recommendations, and the ERROR doesn't seem to have any explanation. Could you suggest what else I need to do here?
-R
On Wed, Aug 10, 2016 at 12:38 PM, bioc-issue-bot notifications@github.com wrote:
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR, WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the following build report for more details:
http://bioconductor.org/spb_reports/gCrisprTools_ buildreport_20160810153929.html
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Bioconductor/Contributions/issues/67#issuecomment-238979827, or mute the thread https://github.com/notifications/unsubscribe-auth/AObUqbUd6nM056fBmdRQpIM34q4Qen6qks5qeiijgaJpZM4JQJAZ .
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR, WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the following build report for more details:
http://bioconductor.org/spb_reports/gCrisprTools_buildreport_20160810164720.html
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR, WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the following build report for more details:
http://bioconductor.org/spb_reports/gCrisprTools_buildreport_20160811081038.html
Hi, wanted to ping about this again- hopefully things are moving forward?
-R
On Thu, Aug 11, 2016 at 5:09 AM, bioc-issue-bot notifications@github.com wrote:
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR, WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the following build report for more details:
http://bioconductor.org/spb_reports/gCrisprTools_ buildreport_20160811081038.html
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Bioconductor/Contributions/issues/67#issuecomment-239143089, or mute the thread https://github.com/notifications/unsubscribe-auth/AObUqafLkE_gfaYU0FucQHcAb_XLgdQbks5qexDtgaJpZM4JQJAZ .
Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor
Confirm the following by editing each check box to '[x]'
I am familiar with the essential aspects of Bioconductor software management, including:
For help with submitting your package, please subscribe and post questions to the bioc-devel mailing list.