Bioconductor / Contributions

Contribute Packages to Bioconductor
134 stars 33 forks source link

A package written for mass-spec data with abundance-dependent missing and censored values #689

Closed ireneslzeng closed 6 years ago

ireneslzeng commented 6 years ago

Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor

Confirm the following by editing each check box to '[x]'

I am familiar with the essential aspects of Bioconductor software management, including:

For help with submitting your package, please subscribe and post questions to the bioc-devel mailing list.

bioc-issue-bot commented 6 years ago

Hi @ireneslzeng

Thanks for submitting your package. We are taking a quick look at it and you will hear back from us soon.

The DESCRIPTION file for this package is:

Package: mlmm
Type: Package
Title: Multilevel Model for Multivariate Responses with Missing Values
Version: 2.5.0
Date: 2018-1-2
Authors@R: c(person("Irene SL","Zeng",email="i.zeng@auckland.ac.nz", role = c("aut", "cre")),person("Thomas","Lumley",email="t.lumley@auckland.ac.nz",role="ctb"))
Description: To conduct Bayesian inference regression for responses with
    multilevel explanatory variables and missing values; It uses function from
    'Stan', a software to implement posterior sampling using Hamiltonian MC and
    its variation Non-U-Turn algorithms. It implements the posterior sampling of
    regression coefficients from the multilevel regression models. The package has
    two main functions to handle not-missing-at-random missing responses and left-
    censored with not-missing-at random responses. The purpose is to provide a
    similar format as the other R regression functions but using 'Stan' models.
Maintainer: Irene SL Zeng <i.zeng@auckland.ac.nz>
License: GPL-2
Depends:
    R (>= 3.5.0),
    Rcpp (>= 0.12.12),
    methods,
    stats
Imports:
    rstan (>= 2.16.2),
    rstantools (>= 1.3.0),
    MASS,
    Matrix,
    stats4,
    ggplot2
LinkingTo: StanHeaders (>= 2.16.0.1), rstan (>= 2.16.2), BH (>= 1.65.0.1), Rcpp
    (>= 0.12.12), RcppEigen (>= 0.3.3.3.0)
Suggests:
    testthat,
    knitr,
    rmarkdown
URL: https://doi.org/10.1101/153049
RoxygenNote: 6.0.1
biocViews: Bayesian,CopyNumberVariation,Classification,Regression,MassSpectrometry,Proteomics,Software
VignetteBuilder: knitr

Consider adding SSH keys to your GitHub account. SSH keys will are used to control access to accepted Bioconductor packages. See these instructions to add SSH keys to your GitHub account.

bioc-issue-bot commented 6 years ago

A reviewer has been assigned to your package Learn What to Expect during the review process.

IMPORTANT: Please read the instructions for setting up a push hook on your repository, or further changes to your repository will NOT trigger a new build.

bioc-issue-bot commented 6 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

Liubuntu commented 6 years ago

Hi @ireneslzeng ,

Thanks for your contribution to Bioconductor. Please see the build report to address all ERROR messages about:

Cheers, Qian

ireneslzeng commented 6 years ago

Thank you for the reviewing. I have registered on Bioc-devel mailing list and changed the version number accordingly. The files are all needed , I have used the r console window to edit all documents and reduce the length. There remains a small % of lines > 80 characters. I hope to have some technical reviews regarding to these notes.

Liubuntu commented 6 years ago

IMPORTANT: Please read the instructions for setting up a push hook on your repository, or further changes to your repository will NOT trigger a new build.

ireneslzeng commented 6 years ago

Thank you. I have added another push hook on the repository. Here is the link: https://github.com/ireneslzeng/mlmm/settings/hooks/25504212

Liubuntu commented 6 years ago

If you have done that already, please try bump your package version, and see if it could trigger an automatic build here. Otherwise, I couldn't get noticed with your commits. Thanks!

bioc-issue-bot commented 6 years ago

Received a valid push; starting a build. Commits are:

40d4c63 commit ddc5776 Merge branch 'master' of https://github.com/irenes...

bioc-issue-bot commented 6 years ago

Received a valid push; starting a build. Commits are:

40d4c63 commit ddc5776 Merge branch 'master' of https://github.com/irenes...

bioc-issue-bot commented 6 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "skipped, ERROR, WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 6 years ago

Received a valid push; starting a build. Commits are:

3119fb1 commit

bioc-issue-bot commented 6 years ago

Received a valid push; starting a build. Commits are:

3119fb1 commit

bioc-issue-bot commented 6 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

ireneslzeng commented 6 years ago

I read the report, it states okay for the first platform. The other two indicate "Git clones failed"., Please advise any solution, thank you.

bioc-issue-bot commented 6 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details.

Liubuntu commented 6 years ago

Hi @ireneslzeng ,

We have rebuilt your package manually. And it could build successfully. An Initial review will be given shortly. Thanks!

Cheers, Qian

ireneslzeng commented 6 years ago

Many thanks for your help and patience. Irene

Liubuntu commented 6 years ago

Hi @ireneslzeng ,

Thank for your contribution to Bioconductor. Here are some issues from the initial technical review. Please seek to address all/most of them. Comment back here with any questions or if you are ready for a second review, where some additional issues could be added.

DESCRIPTION

NAMESPACE

Vignette

MAN/

R/

setinitvalues=function(npred=npred, np=np, npred_miss=npred_miss,                                                                                                               
npred_sub=npred_sub, nmiss=nmiss, nsid=nsid)                                                                                                                                    

coding practices

cheers, Qian

Liubuntu commented 6 years ago

Hi @ireneslzeng ,

Please be aware that Bioconductor usually suggest package maintainers to reply with the technical review within ~2 weeks. Or at least show your efforts in addressing the review issues, e.g., make appropriate git commits, and bump package version to trigger the new build. Otherwise, if you feel that you are not available for a period of time to work further on your package, we will close the issue and you can open it later when you have more time for it. Thanks!

Best, Qian

ireneslzeng commented 6 years ago

Hi,@Liubuntu, Sorry about the lack of responses because I did not know if I can ask questions frequently in the issue list when all the review points are clear. Thank you for the reminding. I have been working on all the revisions according to your comments. I have been working through the notes on a daily basis and one of which I have discussed with rstan building team in the rstan forum. Now, I only need to have the vignette finalized today, and one note which is created after revision of the R program that I am not sure :grinning:
"Consider multiples of 4 spaces for line indents" in the .RD file , I can only change this in the roxygendised mlmc.R program, but the R program has been edited via emac and have the right format.

notes are like these: Checking formatting of DESCRIPTION, NAMESPACE, man pages, R source, and vignette source...

And the vignette dose not show the number even when I have used the number_sections: true statement for output Pdf_document. Could you please advise? Thank you! Irene

bioc-issue-bot commented 6 years ago

Received a valid push; starting a build. Commits are:

e561cc3 commit

bioc-issue-bot commented 6 years ago

Received a valid push; starting a build. Commits are:

e561cc3 commit

bioc-issue-bot commented 6 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 6 years ago

Received a valid push; starting a build. Commits are:

131912e commit

bioc-issue-bot commented 6 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details.

Liubuntu commented 6 years ago

Hi @ireneslzeng ,

Thanks for the update. So for the indentation, if you are using emacs, put cursor in the line which needs reformatting, simply hit the alt+q shortcut for a correct formatting with automatic indentations.

For the other question, try number_sections: true instead of number_section:, while these are not required. A table of content with toc: true is good enough.

Best, Qian

bioc-issue-bot commented 6 years ago

Received a valid push; starting a build. Commits are:

fa88aa9 commit

bioc-issue-bot commented 6 years ago

Received a valid push; starting a build. Commits are:

fa88aa9 commit

ireneslzeng commented 6 years ago

@Liubuntu Thank you for the responses. I have revised the .RMD file, Please let me know if the latest version is okay, Irene

bioc-issue-bot commented 6 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ABNORMAL". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

Liubuntu commented 6 years ago

Hi @ireneslzeng ,

Your package is not building correctly because of the vignette. There should be 4 spaces before each entry under Vignettes: >. Please correct it, bump version, and see if it could build successfully.

vignette: >
    %\VignetteIndexEntry{"Introduction of mlmm"}
    %\VignetteEngine{knitr::rmarkdown}
    %\VignetteEncoding{UTF-8}

Qian

bioc-issue-bot commented 6 years ago

Received a valid push; starting a build. Commits are:

b5aa99b commit

bioc-issue-bot commented 6 years ago

Received a valid push; starting a build. Commits are:

b5aa99b commit

bioc-issue-bot commented 6 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ABNORMAL". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 6 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ABNORMAL". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 6 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ABNORMAL". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 6 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ABNORMAL". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 6 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ABNORMAL". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 6 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ABNORMAL". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 6 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ABNORMAL". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

ireneslzeng commented 6 years ago

@Liubuntu I have changed the .RMD file, and can successfully output the html. I am not sure why the package can not be built in the platform. thank you, Irene

bioc-issue-bot commented 6 years ago

Received a valid push; starting a build. Commits are:

6c1abc2 commit

bioc-issue-bot commented 6 years ago

Received a valid push; starting a build. Commits are:

6c1abc2 commit

bioc-issue-bot commented 6 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

ireneslzeng commented 6 years ago

Hi, @Liubuntu The building reports show a similar message : Git clone Failed, but on different platforms this time. The successful platform has 0 error, warning or note. Could you please advise a solution or suggestion? Do I need to email to the bioconductor developer group?

bioc-issue-bot commented 6 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details.

Liubuntu commented 6 years ago

HI @ireneslzeng ,

We kicked off a manual build of you package, and it build successfully. It seems some problem with the github for the error. And it happens now and then. I will look at your package with the new updates very soon (you could expect a 2nd review within 2 weeks at most). Thanks.

Best, Qian

Liubuntu commented 6 years ago

Hi @ireneslzeng ,

Please see the 2nd review of your package. Let me know for any question. Thanks.

Vignette

R

Regards, Qian

ireneslzeng commented 6 years ago

@Liubuntu , Thank you for the review, I will change the vignette and add info for the default values in setinitialvalue.R Best,

Irene