Closed ireneslzeng closed 6 years ago
Hi @ireneslzeng
Thanks for submitting your package. We are taking a quick look at it and you will hear back from us soon.
The DESCRIPTION file for this package is:
Package: mlmm
Type: Package
Title: Multilevel Model for Multivariate Responses with Missing Values
Version: 2.5.0
Date: 2018-1-2
Authors@R: c(person("Irene SL","Zeng",email="i.zeng@auckland.ac.nz", role = c("aut", "cre")),person("Thomas","Lumley",email="t.lumley@auckland.ac.nz",role="ctb"))
Description: To conduct Bayesian inference regression for responses with
multilevel explanatory variables and missing values; It uses function from
'Stan', a software to implement posterior sampling using Hamiltonian MC and
its variation Non-U-Turn algorithms. It implements the posterior sampling of
regression coefficients from the multilevel regression models. The package has
two main functions to handle not-missing-at-random missing responses and left-
censored with not-missing-at random responses. The purpose is to provide a
similar format as the other R regression functions but using 'Stan' models.
Maintainer: Irene SL Zeng <i.zeng@auckland.ac.nz>
License: GPL-2
Depends:
R (>= 3.5.0),
Rcpp (>= 0.12.12),
methods,
stats
Imports:
rstan (>= 2.16.2),
rstantools (>= 1.3.0),
MASS,
Matrix,
stats4,
ggplot2
LinkingTo: StanHeaders (>= 2.16.0.1), rstan (>= 2.16.2), BH (>= 1.65.0.1), Rcpp
(>= 0.12.12), RcppEigen (>= 0.3.3.3.0)
Suggests:
testthat,
knitr,
rmarkdown
URL: https://doi.org/10.1101/153049
RoxygenNote: 6.0.1
biocViews: Bayesian,CopyNumberVariation,Classification,Regression,MassSpectrometry,Proteomics,Software
VignetteBuilder: knitr
Consider adding SSH keys to your GitHub account. SSH keys will are used to control access to accepted Bioconductor packages. See these instructions to add SSH keys to your GitHub account.
A reviewer has been assigned to your package Learn What to Expect during the review process.
IMPORTANT: Please read the instructions for setting up a push hook on your repository, or further changes to your repository will NOT trigger a new build.
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Hi @ireneslzeng ,
Thanks for your contribution to Bioconductor. Please see the build report to address all ERROR messages about:
to register on the Bioc-devel mailing list.
ERROR: Maintainer must subscribe to the bioc-devel mailing list.
Subscribe here: https://stat.ethz.ch/mailman/listinfo/bioc-devel
Please also seek to address most of the NOTE messages in the report.
License: GPL-2 | LICENCE
. Cheers, Qian
Thank you for the reviewing. I have registered on Bioc-devel mailing list and changed the version number accordingly. The files are all needed , I have used the r console window to edit all documents and reduce the length. There remains a small % of lines > 80 characters. I hope to have some technical reviews regarding to these notes.
IMPORTANT: Please read the instructions for setting up a push hook on your repository, or further changes to your repository will NOT trigger a new build.
Thank you. I have added another push hook on the repository. Here is the link: https://github.com/ireneslzeng/mlmm/settings/hooks/25504212
If you have done that already, please try bump your package version, and see if it could trigger an automatic build here. Otherwise, I couldn't get noticed with your commits. Thanks!
Received a valid push; starting a build. Commits are:
40d4c63 commit ddc5776 Merge branch 'master' of https://github.com/irenes...
Received a valid push; starting a build. Commits are:
40d4c63 commit ddc5776 Merge branch 'master' of https://github.com/irenes...
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "skipped, ERROR, WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
3119fb1 commit
Received a valid push; starting a build. Commits are:
3119fb1 commit
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
I read the report, it states okay for the first platform. The other two indicate "Git clones failed"., Please advise any solution, thank you.
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details.
Hi @ireneslzeng ,
We have rebuilt your package manually. And it could build successfully. An Initial review will be given shortly. Thanks!
Cheers, Qian
Many thanks for your help and patience. Irene
Hi @ireneslzeng ,
Thank for your contribution to Bioconductor. Here are some issues from the initial technical review. Please seek to address all/most of them. Comment back here with any questions or if you are ready for a second review, where some additional issues could be added.
date
field (not needed).License
: should usually just refer to one particular version (e.g., GPL-2)bugReport: https://github.com/ireneslzeng/mlmm/issues
field.Please add a table of contents for better organization. This could be easily specified in the header. check here: https://rmarkdown.rstudio.com/html_document_format.html.
Please add a Introduction
section in the beginning which serves as an abstract of a research paper. e.g., to introduce the objective, models, unique functions, key points \
that distinguish it from other similar packages of your package...
IMPORTANT: please add a section called Installation
after Introduction
, and show to users how to download and library this package as it is already available in Biocondu\
ctor. E.g., to use BiocInstaller
function for downloading. BiocInstaller::biocLite("mlmm")
You can also choose to add a subsection for installing the developmental ve\
rsion from github, e.g.,devtools::install_github("ireneslzeng/mlmm")
Please add in the end of the vignette a section of SessionInfo
for your vignette running environment. sessionInfo()
Add more descriptive contents for each section.
<-
instead of =
for assignment.setinitialvalues.R
. the arguments within the function definition could be only taking default values, as you used in mlmc.R
and mlmm.R
. npred
, np
... are not pred-d\
efined values here, right?setinitvalues=function(npred=npred, np=np, npred_miss=npred_miss,
npred_sub=npred_sub, nmiss=nmiss, nsid=nsid)
Alt+q
shortcut in your emacs session for automatic
indentation of correct length.Alt+q
in emacs.cheers, Qian
Hi @ireneslzeng ,
Please be aware that Bioconductor usually suggest package maintainers to reply with the technical review within ~2 weeks. Or at least show your efforts in addressing the review issues, e.g., make appropriate git commits, and bump package version to trigger the new build. Otherwise, if you feel that you are not available for a period of time to work further on your package, we will close the issue and you can open it later when you have more time for it. Thanks!
Best, Qian
Hi,@Liubuntu,
Sorry about the lack of responses because I did not know if I can ask questions frequently in the issue list when all the review points are clear. Thank you for the reminding.
I have been working on all the revisions according to your comments.
I have been working through the notes on a daily basis and one of which I have discussed with rstan building team in the rstan forum. Now, I only need to have the vignette finalized today, and one note which is created after revision of the R program that I am not sure :grinning:
"Consider multiples of 4 spaces for line indents" in the .RD file , I can only change this in the roxygendised mlmc.R program, but the R program has been edited via emac and have the right format.
notes are like these: Checking formatting of DESCRIPTION, NAMESPACE, man pages, R source, and vignette source...
And the vignette dose not show the number even when I have used the number_sections: true statement for output Pdf_document. Could you please advise? Thank you! Irene
Received a valid push; starting a build. Commits are:
e561cc3 commit
Received a valid push; starting a build. Commits are:
e561cc3 commit
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
131912e commit
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details.
Hi @ireneslzeng ,
Thanks for the update. So for the indentation, if you are using emacs, put cursor in the line which needs reformatting, simply hit the alt+q
shortcut for a correct formatting with automatic indentations.
For the other question, try number_sections: true
instead of number_section:
, while these are not required. A table of content with toc: true
is good enough.
Best, Qian
Received a valid push; starting a build. Commits are:
fa88aa9 commit
Received a valid push; starting a build. Commits are:
fa88aa9 commit
@Liubuntu Thank you for the responses. I have revised the .RMD file, Please let me know if the latest version is okay, Irene
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ABNORMAL". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Hi @ireneslzeng ,
Your package is not building correctly because of the vignette. There should be 4 spaces before each entry under Vignettes: >
. Please correct it, bump version, and see if it could build successfully.
vignette: >
%\VignetteIndexEntry{"Introduction of mlmm"}
%\VignetteEngine{knitr::rmarkdown}
%\VignetteEncoding{UTF-8}
Qian
Received a valid push; starting a build. Commits are:
b5aa99b commit
Received a valid push; starting a build. Commits are:
b5aa99b commit
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ABNORMAL". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ABNORMAL". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ABNORMAL". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ABNORMAL". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ABNORMAL". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ABNORMAL". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ABNORMAL". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
@Liubuntu I have changed the .RMD file, and can successfully output the html. I am not sure why the package can not be built in the platform. thank you, Irene
Received a valid push; starting a build. Commits are:
6c1abc2 commit
Received a valid push; starting a build. Commits are:
6c1abc2 commit
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Hi, @Liubuntu The building reports show a similar message : Git clone Failed, but on different platforms this time. The successful platform has 0 error, warning or note. Could you please advise a solution or suggestion? Do I need to email to the bioconductor developer group?
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details.
HI @ireneslzeng ,
We kicked off a manual build of you package, and it build successfully. It seems some problem with the github for the error. And it happens now and then. I will look at your package with the new updates very soon (you could expect a 2nd review within 2 weeks at most). Thanks.
Best, Qian
Hi @ireneslzeng ,
Please see the 2nd review of your package. Let me know for any question. Thanks.
...regression,
.setinitvalues=function(npred=npred, np=np, npred_miss=npred_miss,
npred_sub=npred_sub, nmiss=nmiss,nsid=nsid,
Regards, Qian
@Liubuntu , Thank you for the review, I will change the vignette and add info for the default values in setinitialvalue.R Best,
Irene
Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor
Confirm the following by editing each check box to '[x]'
[x ] I understand that by submitting my package to Bioconductor, the package source and all review commentary are visible to the general public.
[ x] I have read the Bioconductor Package Submission instructions. My package is consistent with the Bioconductor Package Guidelines.
[x ] I understand that a minimum requirement for package acceptance is to pass R CMD check and R CMD BiocCheck with no ERROR or WARNINGS. Passing these checks does not result in automatic acceptance. The package will then undergo a formal review and recommendations for acceptance regarding other Bioconductor standards will be addressed.
[ x] My package addresses statistical or bioinformatic issues related to the analysis and comprehension of high throughput genomic data.
[x ] I am committed to the long-term maintenance of my package. This includes monitoring the support site for issues that users may have, subscribing to the bioc-devel mailing list to stay aware of developments in the Bioconductor community, responding promptly to requests for updates from the Core team in response to changes in R or underlying software.
I am familiar with the essential aspects of Bioconductor software management, including:
For help with submitting your package, please subscribe and post questions to the bioc-devel mailing list.