Closed JokingHero closed 6 years ago
Hi @JokingHero
Thanks for submitting your package. We are taking a quick look at it and you will hear back from us soon.
The DESCRIPTION file for this package is:
Package: ORFik
Type: Package
Title: Open Reading Frames in Genomics
Version: 0.99.0
Authors@R: c(
person(given = "Kornel", family = "Labun", email = "kornellabun@gmail.com", role = c("aut", "cre", "cph")),
person(given = "Haakon", family = "Tjeldnes", email = "hauken_heyken@hotmail.com", role = c("aut", "dtc")),
person(given = "Katazyna", family = "Chyzynska", email = "katchyz@gmail.com", role = c("ctb", "dtc")),
person(given = "Evind", family = "Valen", email = "eivind.valen@gmail.com", role = c("ths", "fnd")) )
Description: Tools for manipulation of RiboSeq, RNASeq and CageSeq data. ORFik
is extremely fast through use of C, data.table and GenomicRanges. Package
allows to reassign starts of the transcripts with the use of CageSeq data,
automatic shifting of RiboSeq reads, finding of Open Reading Frames for the
whole genomes and many more.
biocViews: Software, Sequencing, RiboSeq, RNASeq, FunctionalGenomics, Coverage, Alignment, DataImport
License: MIT + file LICENSE
LazyData: TRUE
BugReports: https://github.com/JokingHero/ORFik/issues
URL: https://github.com/JokingHero/ORFik
Depends:
R (>= 3.5.0),
IRanges (>= 2.13.28),
GenomicRanges (>= 1.31.23),
GenomicAlignments (>= 1.15.13)
Imports:
S4Vectors (>= 0.17.39),
GenomeInfoDb (>= 1.15.5),
GenomicFeatures (>= 1.31.10),
rtracklayer (>= 1.39.9),
Rcpp (>= 0.12.16),
data.table (>= 1.10.4-3),
Biostrings (>= 2.47.12),
stats,
tools,
Rsamtools (>= 1.31.3)
RoxygenNote: 6.0.1
Suggests:
testthat,
rmarkdown,
knitr,
BiocStyle,
BSgenome,
BSgenome.Hsapiens.UCSC.hg19,
ggplot2 (>= 2.2.1)
LinkingTo: Rcpp
VignetteBuilder: knitr
Hi, I know we are late to the party, but we still hope you will still find the time to review us before the new Bioconductor release.
A reviewer has been assigned to your package Learn what to expect during the review process.
IMPORTANT: Please read the instructions for setting up a push hook on your repository, or further changes to your repository will NOT trigger a new build.
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
bdd4e3a subscribed with proper email to biocmailing list, ...
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Warning from function coverageByWindow:
It is similar to GenomicFeatures::coverageByTranscript.
It uses IRanges:::regroupBySupergroup, which is not exported from IRanges.
So I see four possible ways of fixing this:
We will try the first option first.
Thank you.
Ok, so we copied IRanges:::regroupBySupergroup to our package. Then changed it to be a bit faster, if regroupBySupergroup is exported in the future, we just delete our version.
Received a valid push; starting a build. Commits are:
eb06f28 fixed warning, added some docs (#32)
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
31ef40d switched is with is.grl (#33) * swithced is with ...
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details.
ok
ok
ok
ok
ok
* Checking library calls...
* NOTE: biocLite, install.packages, or update.packages found in R
files
utils.R: 126
utils.R: 128
utils.R: 130
seq_along
or seq_len
, instead of n:length()for (i in 2:length(L)) {
acums[i] <-acums[i-1] + acums[i]
}
ok
ok
Good package overall.
Ok, for the bioclite call inside the package, it is an unexported convenience function that basically installs packages from bioC, so you dont need to find the bioC URL all the time. I will delete this functions. Thank you.
Received a valid push; starting a build. Commits are:
4dea004 fixed some notes from check on bioc (#34) * fixed...
Will fix some warnings in vignette, then push again.
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
It's not great that you copied IRanges:::regroupBySupergroup()
. There is already a TODO to export that function, so maybe @hpages would be open to it. Also, if you've found a way to improve it, it would be great if you could contribute it to the infrastructure.
Yes, our hope was that it would be exported for 3.7, we are open for sugestions. The version we use is not suitable for IRanges, since it restricts input data classes. I think IRanges:::regroupBySupergroup() is good enough for export with some added docs, if you would like us to contribute with anything( like making a draft for docs) on that matter, let us know.
Received a valid push; starting a build. Commits are:
db5a258 fixed vignette and possible warning in cageReassig...
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
aa03959 fix doc for finMaxPeaks
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Hi @hpages
Here is the link to the gist with potential improvements to the GenomicFeatures::coverageByTranscript.
If you will accept those changes we will be very happy and we will not have to use IRanges:::regroupBySupergroup as we basically wrapped around GenomicFeatures::coverageByTranscript and created ORFik:::coverageByWindow
If not then please export IRanges:::regroupBySupergroup so that we don't have to copy this function.
Is there some sort of solution to the warnings that tokay2 shows for us? Example below:
Rd warning: C:/Users/pkgbuild/AppData/Local/Temp/RtmpkTe16y/R.INSTALL13b833e32206/ORFik/man/asTX.Rd:10: file link 'GRangesList' in package 'GenomicRanges' does not exist and so has been treated as a topic
One thing needs to be addressed: it is cpp compilation on Windows: It looks like windows does not like some of the header files in cpp, need to find a solution here: https://github.com/kaskr/adcomp/issues/233
Received a valid push; starting a build. Commits are:
6afadd8 tried to fix docs warning on windows, and compilat...
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
7ce6890 Remove assert (#38) * removed assert
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
474f68e removed import of assertion (#39) * removed impor...
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
1530552 Find cpp note (#40) * removed import of assertion...
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details.
Built clean version 0.99.10. All concerns in review from @nturaga fixed.
Received a valid push; starting a build. Commits are:
5b4ec76 Speed impro (#41) * first speed improvement, on c...
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "skipped, WARNINGS, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
What happend here. There are no .o files, and rproject have always been there.. Any idea ? I guess this is from the new R build on the test server ?
Hi, please issue another build by bumping the version.
I'm looking into the .o files - This is on our end - We implemented a new check for files and it is not working quite as expected - The ORFik.Rproj should be removed with git rm
as this should not be tracked - The rest can be ignored for now -
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "WARNINGS, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "WARNINGS, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
But now the project file is gone, so I can't start Rproject from folder anymore, how should we do this now ? git rm ORFik.Rproj result -> deleted: ORFik.Rproj
The the folder is not a R-package anymore ?
The .Rproj
file doesn't specify if an R folder is a package or not. These files are ‘extras’ that are put there by RStudio to help it manage your package building. You can just ignore these files, they are not part of ‘required’ R package anatomy.
http://bioconductor.org/developers/how-to/buildingPackagesForBioc/
Received a valid push; starting a build. Commits are:
7ccc066 More docs (#42) * speedup on orfScore and more do...
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
997dc15 tried to reduce check time (#43)
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
4f613a2 speedup for tests (#44)
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details.
Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor
Confirm the following by editing each check box to '[x]'
[ x ] I understand that by submitting my package to Bioconductor, the package source and all review commentary are visible to the general public.
[ x ] I have read the Bioconductor Package Submission instructions. My package is consistent with the Bioconductor Package Guidelines.
[ x ] I understand that a minimum requirement for package acceptance is to pass R CMD check and R CMD BiocCheck with no ERROR or WARNINGS. Passing these checks does not result in automatic acceptance. The package will then undergo a formal review and recommendations for acceptance regarding other Bioconductor standards will be addressed.
[ x ] My package addresses statistical or bioinformatic issues related to the analysis and comprehension of high throughput genomic data.
[ x ] I am committed to the long-term maintenance of my package. This includes monitoring the support site for issues that users may have, subscribing to the bioc-devel mailing list to stay aware of developments in the Bioconductor community, responding promptly to requests for updates from the Core team in response to changes in R or underlying software.
I am familiar with the essential aspects of Bioconductor software management, including:
For help with submitting your package, please subscribe and post questions to the bioc-devel mailing list.