Closed zhushijia closed 6 years ago
Hi @zhushijia
Thanks for submitting your package. We are taking a quick look at it and you will hear back from us soon.
The DESCRIPTION file for this package is:
Package: GIGSEA
Type: Package
Title: Genotype Imputed Gene Set Enrichment Analysis
Version: 0.99.0
Author: Shijia Zhu
Maintainer: Shijia Zhu <shijia.zhu@mssm.edu>
Description: We presented the Genotype-imputed Gene Set Enrichment Analysis (GIGSEA), a novel method
that uses GWAS-and-eQTL-imputed trait-associated differential gene expression to interrogate gene set
enrichment for the trait-associated SNPs. By incorporating eQTL from large gene expression studies,
e.g. GTEx, GIGSEA appropriately addresses such challenges for SNP enrichment as gene size, gene boundary,
SNP distal regulation, and multiple-marker regulation. The weighted linear regression model, taking as
weights both imputation accuracy and model completeness, was used to perform the enrichment test,
properly adjusting the bias due to redundancy in different gene sets. The permutation test, furthermore,
is used to evaluate the significance of enrichment, whose efficiency can be largely elevated by expressing
the computational intensive part in terms of large matrix operation. We have shown the appropriate type I
error rates for GIGSEA (<5%), and the preliminary results also demonstrate its good performance to uncover
the real signal.
License: LGPL-3
Encoding: UTF-8
LazyData: true
Depends: Matrix, MASS, locfdr, stats, utils
Suggests: knitr
VignetteBuilder: knitr
RoxygenNote: 6.0.1
NeedsCompilation: no
biocViews: GeneSetEnrichment,SNP,VariantAnnotation,GeneExpression,GeneRegulation,Regression,DifferentialExpression
A reviewer has been assigned to your package Learn what to expect during the review process.
IMPORTANT: Please read the instructions for setting up a push hook on your repository, or further changes to your repository will NOT trigger a new build.
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
4ec2775 modification for bioconductor
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR, WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
3a33da6 modification for bioconductor
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "skipped, ERROR, WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
1a9ff6d version
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
a8f824d modification for bioconductor
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
df4cd5b modification for bioconductor
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "skipped, ERROR, WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
80c31fd modification for bioconductor
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
17bc62e modification for bioconductor
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
caddd77 version dependency
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
014350f modification for bioconductor
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
431af20 modification for bioconductor
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
650e2c0 modification for bioconductor
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details.
Hi Shijia, @zhushijia Thank you for your submission. I will be reviewing your package later today. Best regards, Marcel
Hi Marcel,
Sounds great! Thank you very much for your help!
Best Shijia
Hi @zhushijia
I guess @LiNk-NY will give you some more formal feedback on code and
implementation practice, I rather took a look into your DESCRIPTION
file and
your vignette.
It seems as if you have implemented useful functionality for gene set analysis of GWAS data, but from your documentation / vignette it's currently hard to understand what you did exactly.
** Description
Resembles an Abstract of a scientific article. For a software package, you typically want that to be more compact and generally comprehensible. Good practice is a sentence on background, 1-2 sentences on what you have implemented, and a sentence how this integrates with existing functionality. A good example is the Description field here: http://bioconductor.org/packages/MultiAssayExperiment
** vignette building instructions are needed in yaml header of Rmd file
** Abstract: *** Many specific undefined terms, e.g.
*** Your grammar also indicates that you are having a manuscript somewhere but a reference is missing:
*** Appropriately addresses such challenges for SNP enrichment as gene size, gene boundary, and multiple-marker regulation? (Why is this challenging and how does it address that?)
** Quick start:
*** Linking
https://cloud.hakyimlab.org/static/img/PrediXcan-GWAS-Summary-PrediXcan.png
here would give some context and help users to understand what you are talking about.
*** It's not a good idea to comment the command in your quick start. That's
basically an eval=FALSE
chunk and undermines the reproducibility of your
vignette (see http://bioconductor.org/developers/package-guidelines/#vignettes).
In your case, I would also clearly separate functionality based on MetaXcan
(thus relying on external software) from your subsequent enrichment analysis,
and not combine this into one step.
*** I like the distinction between discrete and continuous gene sets and their representation in sparse matrices
*** User self-defined gene sets --> user-defined gene sets
*** Section 5.1: it's basically unclear what you do here. Again, do you have any manuscript here that you can refer to or can you refer to the literature for similar approaches? If not, explain in more detail what you do.
** link or include cited references in vignette
Hi @lgeistlinger
Thank you very much for your comments. All make sense. I will try to address. :-)
Best wishes Shijia
Hi Shijia Zhu, @zhushijia Thank you for your submission. Please see the review for GIGSEA below.
If you have any questions please post them here. Thanks! -Marcel
README.md
, DESCRIPTION
,
etc. This would make your files easier to maintain and review..DS_Store
files from the repository and add the name to the
.gitignore
file.*.Rproj
filewget
command for installing your
package. Let users make use of devtools
or remotes
for downloading and
installing GIGSEA
in the meantime.Depends
field.Imports
field and selectively import functions with
@importFrom
.dataframe
instead of
dataFrame
). Consider using the S4Vectors::DataFrame
as well.permutationMultipleLm
could be
permuteMultiLM
or something similar.GIGSEA
.BiocCheck
results and follow the recommendations for avoiding
sapply
etc.termCol
, is it an index the split vector?empiricalPval <- vector("numeric", nrow(shuffledPval))
verbose = FALSE
message()
instead of cat()
so these messages can be suppressed if
desired by the user.setwd
inside a function. If you have intermediate
files, you can create them in a tempdir()
. Minor:
<-
for assignmentvignette:
field in your RMarkdown document like this:vignette: >
%\VignetteEngine{knitr::rmarkdown}
%\VignetteIndexEntry{GIGSEA: Genotype Imputed Gene Set Enrichment Analysis}
%\VignetteEncoding{UTF-8}
Thanks Ludwig @lgeistlinger for the scientific content review! :+1:
Hi LiNk-NY @LiNk-NY
Thank you very much for the detailed comments. I will try my best to address them.
Best wishes Shijia
Please bump your package's version for another build in the BBS/SPB. Thanks, Marcel
Hi Shijia,
Please respond to the review and push your changes. Otherwise I will have to close the issue within 2 weeks.
Thank you for your attention.
Regards, Marcel
Hi Marcel,
I apologize for the late response. I was wrapping up the corresponding paper recently, and eventually submit it. I will address the comments and respond quickly.
Thank you so much for your patient help.
Best Wishes Shijia
On Fri, May 18, 2018 at 11:15 AM, Marcel Ramos notifications@github.com wrote:
Hi Shijia,
Please respond to the review and push your changes. Otherwise I will have to close the issue within 2 weeks.
Thank you for your attention.
Regards, Marcel
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Bioconductor/Contributions/issues/720#issuecomment-390239596, or mute the thread https://github.com/notifications/unsubscribe-auth/AFKtsZPEqbQRxEGQSn78j3kh7ceOSyH7ks5tzuWCgaJpZM4TPAoV .
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ABNORMAL". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ABNORMAL". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
5858742 version 3.5 0283790 Merge branch 'master' of https://github.com/zhushi...
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ABNORMAL". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
7d0b455 documents
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
6314303 documents
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
9017509 sapply to vapply
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
7d088d6 seq_len and seq_along
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "WARNINGS, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
f9c1db8 for 80L width
Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor
Confirm the following by editing each check box to '[x]'
[x] I understand that by submitting my package to Bioconductor, the package source and all review commentary are visible to the general public.
[x] I have read the Bioconductor Package Submission instructions. My package is consistent with the Bioconductor Package Guidelines.
[x] I understand that a minimum requirement for package acceptance is to pass R CMD check and R CMD BiocCheck with no ERROR or WARNINGS. Passing these checks does not result in automatic acceptance. The package will then undergo a formal review and recommendations for acceptance regarding other Bioconductor standards will be addressed.
[x] My package addresses statistical or bioinformatic issues related to the analysis and comprehension of high throughput genomic data.
[x] I am committed to the long-term maintenance of my package. This includes monitoring the support site for issues that users may have, subscribing to the bioc-devel mailing list to stay aware of developments in the Bioconductor community, responding promptly to requests for updates from the Core team in response to changes in R or underlying software.
I am familiar with the essential aspects of Bioconductor software management, including:
For help with submitting your package, please subscribe and post questions to the bioc-devel mailing list.