Bioconductor / Contributions

Contribute Packages to Bioconductor
134 stars 33 forks source link

CellTrails #743

Closed dcellwanger closed 6 years ago

dcellwanger commented 6 years ago

Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor

Confirm the following by editing each check box to '[x]'

I am familiar with the essential aspects of Bioconductor software management, including:

For help with submitting your package, please subscribe and post questions to the bioc-devel mailing list.

dcellwanger commented 6 years ago

@lshep We look forward to receiving your feedback. Since our package has been adapted as requested to be fully compatible with a SingleCellExperiment object, we hope that there won't be additional major design changes needed. The paper will be published tomorrow and we would like to avoid having another major user interface update during the next days/weeks.

bioc-issue-bot commented 6 years ago

Your package has been accepted. It will be added to the Bioconductor Git repository and nightly builds. Additional information will be posed to this issue in the next several days.

Thank you for contributing to Bioconductor!

dcellwanger commented 6 years ago

Thank you for your review and for accepting the package. We are excited about CellTrails being part of Bioconductor.

mtmorgan commented 6 years ago

The master branch of your GitHub repository has been added to Bioconductor's git repository.

To use the git.bioconductor.org repository, we need an 'ssh' key to associate with your github user name. If your GitHub account already has ssh public keys (https://github.com/dcellwanger.keys is not empty), then no further steps are required. Otherwise, do the following:

  1. Add an SSH key to your github account
  2. Submit your SSH key to Bioconductor

See further instructions at

https://bioconductor.org/developers/how-to/git/

for working with this repository. See especially

https://bioconductor.org/developers/how-to/git/new-package-workflow/ https://bioconductor.org/developers/how-to/git/sync-existing-repositories/

to keep your GitHub and Bioconductor repositories in sync.

Your package will be included in the next nigthly 'devel' build (check-out from git at about 6 pm Eastern; build completion around 2pm Eastern the next day) at

https://bioconductor.org/checkResults/

(Builds sometimes fail, so ensure that the date stamps on the main landing page are consistent with the addition of your package). Once the package builds successfully, you package will be available for download in the 'Devel' version of Bioconductor using biocLite(\"CellTrails\"). The package 'landing page' will be created at

https://bioconductor.org/packages/CellTrails

If you have any questions, please contact the bioc-devel mailing list (https://stat.ethz.ch/mailman/listinfo/bioc-devel); this issue will not be monitored further.

mtmorgan commented 6 years ago

Your git repository contained a doc/ directory. This directory is ignored by R during the build process, and anyway contains files that are larger than the maximum allowed in the Bioconductor git repository. For this reason I removed the directory before cloning to git.bioconductor.org. This may cause problems when synching with your github repository; if so please ask for help on the bioc-devel mailing list.