Bioconductor / Contributions

Contribute Packages to Bioconductor
135 stars 33 forks source link

HPAanalyze #757

Closed anhtr closed 6 years ago

anhtr commented 6 years ago

Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor

Confirm the following by editing each check box to '[x]'

I am familiar with the essential aspects of Bioconductor software management, including:

For help with submitting your package, please subscribe and post questions to the bioc-devel mailing list.

bioc-issue-bot commented 6 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details.

anhtr commented 6 years ago

Hello @vobencha,

Thank you for your patience. I have make changes to the package to address your concern. The changes are summarized in the NEWS file.

As for issue no. 10, I have combined the man file for hpaListParam() and hpaSubset(), but not hpaDownload() and hpaExport(). The reason was that hpaDownload() and hpaExport() did not share parameters, and it was actually recommended to not call hpaExport() directly on the output of hpaDownload(). The output would be too big for the exported .xlsx file to handle.

I am looking forward to technical review from @lgatto. Thank you very much. Anh Tran.

vobencha commented 6 years ago

I think @lgatto is currently unavailable to do a review so I'm going to approve the package. He may have time later in the year to give more feedback but for now we'll move forward.

bioc-issue-bot commented 6 years ago

Your package has been accepted. It will be added to the Bioconductor Git repository and nightly builds. Additional information will be posed to this issue in the next several days.

Thank you for contributing to Bioconductor!

anhtr commented 6 years ago

Thank you very much, @vobencha.

mtmorgan commented 6 years ago

The master branch of your GitHub repository has been added to Bioconductor's git repository.

To use the git.bioconductor.org repository, we need an 'ssh' key to associate with your github user name. If your GitHub account already has ssh public keys (https://github.com/trannhatanh89.keys is not empty), then no further steps are required. Otherwise, do the following:

  1. Add an SSH key to your github account
  2. Submit your SSH key to Bioconductor

See further instructions at

https://bioconductor.org/developers/how-to/git/

for working with this repository. See especially

https://bioconductor.org/developers/how-to/git/new-package-workflow/ https://bioconductor.org/developers/how-to/git/sync-existing-repositories/

to keep your GitHub and Bioconductor repositories in sync.

Your package will be included in the next nigthly 'devel' build (check-out from git at about 6 pm Eastern; build completion around 2pm Eastern the next day) at

https://bioconductor.org/checkResults/

(Builds sometimes fail, so ensure that the date stamps on the main landing page are consistent with the addition of your package). Once the package builds successfully, you package will be available for download in the 'Devel' version of Bioconductor using biocLite(\"HPAanalyze\"). The package 'landing page' will be created at

https://bioconductor.org/packages/HPAanalyze

If you have any questions, please contact the bioc-devel mailing list (https://stat.ethz.ch/mailman/listinfo/bioc-devel); this issue will not be monitored further.