Bioconductor / Contributions

Contribute Packages to Bioconductor
134 stars 33 forks source link

MetNet submission #766

Closed tnaake closed 6 years ago

tnaake commented 6 years ago

Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor

Confirm the following by editing each check box to '[x]'

I am familiar with the essential aspects of Bioconductor software management, including:

For help with submitting your package, please subscribe and post questions to the bioc-devel mailing list.

bioc-issue-bot commented 6 years ago

Hi @tnaake

Thanks for submitting your package. We are taking a quick look at it and you will hear back from us soon.

The DESCRIPTION file for this package is:

Package: MetNet
Type: Package
Title: Inferring metabolic networks from untargeted high-resolution mass spectrometry data
Version: 0.99.0
Date: 2018-06-06
Authors@R: c(person(given = "Thomas", family = "Naake",
    email = "thomasnaake@googlemail.com",
    role = c("aut","cre")))
Author: Thomas Naake <thomasnaake@googlemail.com>
Maintainer: Thomas Naake <thomasnaake@googlemail.com>
VignetteBuilder: knitr
Depends:
    R (>= 3.4.4),
    stats (>= 3.4.4)
Imports:
    bnlearn (>= 4.3),     
    methods (>= 3.4.4),
    mpmi (>= 0.42), 
    parallel (>= 3.4.4),
    parmigene (>= 1.0.2),
    ppcor (>= 1.1),
    psych (>= 1.7.8),
    rfPermute (>= 2.1.5),
    sna (>= 2.4),
    stabs (>= 0.6)    
Suggests:
    BiocGenerics,
    igraph (>= 1.1.2), 
    knitr (>= 1.11)    
biocViews: Metabolomics, MassSpectrometry, Network, Regression
Description: MetNet contains functionality to infer metabolic network topologies from 
  quantitative data and high-resolution mass/charge information. Using statistical models
  (including correlation, mutual information, regression and Bayes statistics) and 
  quantitative data (intensity values of features) adjacency matrices are inferred that 
  can be combined to a consensus matrix. Mass differences calculated between mass/charge 
  values of features will be matched against a data frame of supplied mass/charge 
  differences referring to transformations of enzymatic activities. In a third step, 
  the two matrices are combined to form a adjacency matrix inferred from both quantitative 
  and structure information. 
License: GPL-2
RoxygenNote: 6.0.1
bioc-issue-bot commented 6 years ago

A reviewer has been assigned to your package Learn what to expect during the review process.

IMPORTANT: Please read the instructions for setting up a push hook on your repository, or further changes to your repository will NOT trigger a new build.

mtmorgan commented 6 years ago

nturaga will review your package. Usually a vignettes/Makefile is not required or desired; it gets in the way of R's standard procedures for building vignettes during R CMD build.

bioc-issue-bot commented 6 years ago

Received a valid push; starting a build. Commits are:

4bbc6c9 bump version to 0.99.1

bioc-issue-bot commented 6 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 6 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "skipped, TIMEOUT, WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 6 years ago

Received a valid push; starting a build. Commits are:

0374c5a bump to version 0.99.

bioc-issue-bot commented 6 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 6 years ago

Received a valid push; starting a build. Commits are:

5484643 bump to version 0.99.3

bioc-issue-bot commented 6 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details.

nturaga commented 6 years ago

Hi @tnaake

Please make sure you have a clean build report before I review your package.

Follow the Bioconductor style guide as far as coding practices go, http://bioconductor.org/developers/how-to/coding-style/ and follow this guide on how to write robust code (http://bioconductor.org/developers/how-to/efficient-code/).

* Checking coding practice...
    * NOTE: Avoid 1:...; use seq_len() or seq_along() found in files:
      statistical.R (line 45, column 24)
      statistical.R (line 55, column 22)
      statistical.R (line 68, column 15)
      statistical.R (line 110, column 34)
      statistical.R (line 119, column 22)
      statistical.R (line 131, column 15)
      statistical.R (line 341, column 14)
      structural.R (line 100, column 15)
      structural.R (line 101, column 40)
bioc-issue-bot commented 6 years ago

Received a valid push; starting a build. Commits are:

8e59950 change 1:... to seq_len()

bioc-issue-bot commented 6 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details.

bioc-issue-bot commented 6 years ago

Received a valid push; starting a build. Commits are:

c6b2ad3 missed one 1:... , replace by seq_len

bioc-issue-bot commented 6 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 6 years ago

Received a valid push; starting a build. Commits are:

285a156 fix typo

bioc-issue-bot commented 6 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details.

bioc-issue-bot commented 6 years ago

Received a valid push; starting a build. Commits are:

9c879bf use camelcaps

bioc-issue-bot commented 6 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details.

bioc-issue-bot commented 6 years ago

Received a valid push; starting a build. Commits are:

3df68fd implement function rtCorrection

bioc-issue-bot commented 6 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details.

bioc-issue-bot commented 6 years ago

Received a valid push; starting a build. Commits are:

7776192 change 1:... to seq_len

bioc-issue-bot commented 6 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details.

bioc-issue-bot commented 6 years ago

Received a valid push; starting a build. Commits are:

9297739 bump to version 0.99.10 after speeding up createSt...

bioc-issue-bot commented 6 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details.

bioc-issue-bot commented 6 years ago

Received a valid push; starting a build. Commits are:

1d3dc39 bump version to 0.99.11, speed up rtCorrection

bioc-issue-bot commented 6 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details.

nturaga commented 6 years ago

MetNet Review

R CMD buld

ok

R CMD check

ok

NEWS

DESCRIPTION

NAMESPACE

man

vignette

R

bioc-issue-bot commented 6 years ago

Received a valid push; starting a build. Commits are:

e084899 fix bug in rtCorrection 0d59cae bump to version 0.99.12 after review of package by...

bioc-issue-bot commented 6 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 6 years ago

Received a valid push; starting a build. Commits are:

d3d5916 bump to version 0.99.13

bioc-issue-bot commented 6 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

tnaake commented 6 years ago

Dear @nturaga

I uploaded a new version of the package to the package builder system implementing all suggestion that you made. Many thanks for these suggestions. After uploading, an error occured in CHECK on Windows Server 2012 R2 Standard/x64 (at the level of test_statistical.R unit tests). Since I do not have access to a Windows-operating computer, I wanted to ask if there is a possibility somehow, to dig more into why the package fails at this step. Do you have any suggestions how I could check for this error?

Best wishes, tnaake

bioc-issue-bot commented 6 years ago

Received a valid push; starting a build. Commits are:

44d3131 bump version to 0.99.14

bioc-issue-bot commented 6 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ABNORMAL". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 6 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "WARNINGS, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

nturaga commented 6 years ago

Hi @tnaake,

I tried running your tests after you made the changes,

RUNIT TEST PROTOCOL -- Mon Jul 16 09:18:49 2018
***********************************************
Number of test functions: 4
Number of errors: 1
Number of failures: 1

1 Test Suite :
MetNet RUnit Tests - 4 test functions, 1 error, 1 failure
ERROR in /MetNet/inst/unitTests/test_statistical.R: Error while sourcing  
/MetNet/inst/unitTests/test_statistical.R : Error in get(fun, mode = "function", envir = parent.frame()) :
  object 'stabsel.matrix' of mode 'function' was not found
FAILURE in test_rtCorrection: Error in checkException(rtCorrection(struct_adj, mat_test, cbind(transformations[,  :
  Error not generated as expected

Test files with failing tests

   test_statistical.R
  /MetNet/inst/unitTests/test_statistical.R

   test_structural.R
     test_rtCorrection

Error in BiocGenerics:::testPackage("MetNet") :
  unit tests failed for package MetNet
bioc-issue-bot commented 6 years ago

Received a valid push; starting a build. Commits are:

34932c6 bump version to 0.99.15

bioc-issue-bot commented 6 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR, WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 6 years ago

Received a valid push; starting a build. Commits are:

087f0e2 bump version to 0.99.16

bioc-issue-bot commented 6 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

tnaake commented 6 years ago

Dear @nturaga ,

thanks for your message. I cannot somehow understand the message: ERROR in /MetNet/inst/unitTests/test_statistical.R: Error while sourcing
/MetNet/inst/unitTests/test_statistical.R : Error in get(fun, mode = "function", envir = parent.frame()) : object 'stabsel.matrix' of mode 'function' was not found

In my NAMESPACE, I am using importFrom(stabs,stabsel.matrix) which should load the stabsel.matrix function from stabs. Strangely, this seems not to be the case on Windows, however under Mac OS X and Linux the package builds nicely.

Do you have any idea why this error is created?

Best, tnaake

bioc-issue-bot commented 6 years ago

Received a valid push; starting a build. Commits are:

667806c set num.cores=1 in randomForest unittest

bioc-issue-bot commented 6 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 6 years ago

Received a valid push; starting a build. Commits are:

4896983 use rfPermute.default instead of rfPermute.formula...

bioc-issue-bot commented 6 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 6 years ago

Received a valid push; starting a build. Commits are:

fe39eaa print message when calculation of model in createS...

bioc-issue-bot commented 6 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details.

tnaake commented 6 years ago

Dear @nturaga the package now builds nicely. Could you tell me, please, if there needs to be done anything else from my side or when the package will be accepted?

Best tnaake

bioc-issue-bot commented 6 years ago

Received a valid push; starting a build. Commits are:

1213be7 replace psych::corr.test by WGCNA::corAndPValue to...