Closed averissimo closed 6 years ago
Hi @averissimo
Thanks for submitting your package. We are taking a quick look at it and you will hear back from us soon.
The DESCRIPTION file for this package is:
Package: glmSparseNet
Type: Package
Title: Network Centrality Metrics for Elastic-Net Regularized Models
Version: 0.1.8
Authors@R: c(person("André", "Veríssimo", email = "andre.verissimo@tecnico.ulisboa.pt", role = c("aut", "cre")),
person("Susana", "Vinga", email = "susanavinga@tecnico.ulisboa.pt", role = "aut"),
person("Eunice", "Carrasquinha", email = "eunice.trigueirao@tecnico.ulisboa.pt", role = "ctb"),
person("Marta", "Lopes", email = "marta.lopes@tecnico.ulisboa.pt", role = "ctb"))
Description: glmSparseNet is an R-package that generalizes sparse regression models when the features (e.g. genes)
have a graph structure (e.g. protein-protein interactions), by including network-based regularizers.
glmSparseNet uses the glmnet R-package, by including centrality measures of the network as penalty
weights in the regularization. The current version implements regularization based on node degree,
i.e. the strength and/or number of its associated edges, either by promoting hubs in the solution or
orphan genes in the solution. All the glmnet distribution families are supported, namely "gaussian",
"poisson", "binomial", "multinomial", "cox", and "mgaussian".
License: GPL (>=3)
Encoding: UTF-8
LazyData: true
NeedsCompilation: no
biocViews: Software,
StatisticalMethod,
DimensionReduction,
Regression,
Classification,
Survival,
Network,
GraphAndNetwork
Depends: R (>= 3.5), Matrix, MultiAssayExperiment, glmnet
Imports: SummarizedExperiment,
STRINGdb,
biomaRt,
futile.logger,
sparsebn,
sparsebnUtils,
forcats,
dplyr,
readr,
ggplot2,
ggfortify,
reshape2,
stats,
stringr,
rlang,
parallel,
methods,
digest
Suggests: testthat,
knitr,
rmarkdown,
survival,
survcomp,
pROC,
devtools,
roxygen2,
VennDiagram,
BiocStyle,
curatedTCGAData
VignetteBuilder: knitr
RoxygenNote: 6.1.0
BugReports: https://www.github.com/sysbiomed/glmSparseNet/issues
URL: https://www.github.com/sysbiomed/glmSparseNet
Add SSH keys to your GitHub account. SSH keys will are used to control access to accepted Bioconductor packages. See these instructions to add SSH keys to your GitHub account.
A reviewer has been assigned to your package. Learn what to expect during the review process.
IMPORTANT: Please read the instructions for setting up a push hook on your repository, or further changes to your repository will NOT trigger a new build.
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR, WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
51d2cc9 bumps versions
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR, WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
a7702d5 bumps version
Received a valid push; starting a build. Commits are:
43dfa4c sets object as data in documentation and bumps ver...
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR, WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR, WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
84d3341 exclude workflow image and bump version
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
acea830 removed a vignette to speed up R CHECK vignette i...
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
edit: Nevermind, I removed one of the redundant vignettes (from building) and it now passes BiocCheck without warnings.
The redundant vignettes, are in practice the same code applied to a different TCGA cancer project.
Can you advise on the warnings I'm getting @LiNk-NY
The warnings in the package are from two sources:
Exceed 5 minute check
I believe the source of this are the vignette building, as it retrieves and processes data from another BioC package it can take some time.
I can either/both:
Having to rebuild one of the files in inst/doc
This is the warning and I have no idea on how to solve this, I could not find any solution when searching online.
* creating vignettes ... OK
Warning: inst/doc file
example_brca_survival_ppi.R
ignored as vignettes have been rebuilt.
edit: The check time runs under 4 minutes in Mac/x64.. So both windows and linux take longer because they check 2 architectures.
Received a valid push; starting a build. Commits are:
8135432 bumps version
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
d72bacc version bump to add comment as it now passes bioc ...
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
684ef86 bumps version using loose.rock from cran
Received a valid push; starting a build. Commits are:
847048a removes digest as no longer used
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details.
Some more general functions (was in R/loose_rock_functions.R
) were packaged in loose.rock package in CRAN and removed from this one.
Makes it cleaner and more compact
Received a valid push; starting a build. Commits are:
df1427d bumps version
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
bf94463 removes old Rd file
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
2430148 corrects problem with documentation
Received a valid push; starting a build. Commits are:
daac009 extra alias
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details.
Hi André, @averissimo Apologies for the delay. I will get to your package soon. Best regards, Marcel
Hi André, @averissimo Thank you for your submission. The review can be seen below. Please respond to individual bullet points of the review.
If you have any questions, please feel free to reach out.
Best regards, Marcel
devtools
and roxygen
in the Suggests
field?.
dot delimiters in function names such as
build.string.network
unless you're creating S3 methods. The Bioconductor
convention is to use camelCase
TCGAbiolinks
rather than
curatedTCGAData
in the vignettesTCGAutils
that allow you to separate
assays by sample type code (referring to tumors, normals, etc.)data(sampleTypes)
in TCGAutils
TCGAbarcode
, splitAssays
,
intersectColumns
, as(X, "MatchedAssayExperiment")
etc.matrix
. Please create a
regular function and have checks in place so that it only works for certain
classes (in this case matrix
)degree.sparsebn
)NAMESPACE
with regards to the dots .
in functionsdegree.generic
and similar. You may also want to have a default function for
the fun
argumentBiocParallel
for parallel computationsseq(1, X)
use seq_len(X)
for robustnessdata.R
biocmaRt
. I'm not sure what package is
recommended here.SummarizedExperiment
and MultiAssayExperiment
)switch
for calc.penalty
options rather than a series of
callssource
and biocLite
calls with BiocManager
. See the devel
landing pages of any package on the Bioconductor website for examples or
check the Bioc-devel mailing list.Thanks for the feedback Marcel, I'll work on these and reply as soon as possible.
Received a valid push; starting a build. Commits are:
c632792 new version for bioconductor
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
1086ae9 speeds up vignette building
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR, WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
61506e2 bumps version
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
d75408d bumps version
Received a valid push; starting a build. Commits are:
56db0cc updates docs and bumps version
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR, WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
c7f5061 corrects long line and remove one more vignette to...
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
62c80d6 trying to keep check shorter
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details.
Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor
Confirm the following by editing each check box to '[x]'
[x] I understand that by submitting my package to Bioconductor, the package source and all review commentary are visible to the general public.
[x] I have read the Bioconductor Package Submission instructions. My package is consistent with the Bioconductor Package Guidelines.
[x] I understand that a minimum requirement for package acceptance is to pass R CMD check and R CMD BiocCheck with no ERROR or WARNINGS. Passing these checks does not result in automatic acceptance. The package will then undergo a formal review and recommendations for acceptance regarding other Bioconductor standards will be addressed.
[x] My package addresses statistical or bioinformatic issues related to the analysis and comprehension of high throughput genomic data.
[x] I am committed to the long-term maintenance of my package. This includes monitoring the support site for issues that users may have, subscribing to the bioc-devel mailing list to stay aware of developments in the Bioconductor community, responding promptly to requests for updates from the Core team in response to changes in R or underlying software.
I am familiar with the essential aspects of Bioconductor software management, including:
For help with submitting your package, please subscribe and post questions to the bioc-devel mailing list.