search

Bioconductor / DelayedArray

A unified framework for working transparently with on-disk and in-memory array-like datasets
https://bioconductor.org/packages/DelayedArray
24 stars 9 forks source link

Please consider adding RUnit to Suggests #24

Closed HenrikBengtsson closed 6 years ago

HenrikBengtsson commented 6 years ago

DelayedArray:::.test() calls BiocGenerics:::testPackage() which calls library("RUnit", quietly = TRUE). I Since RUnit is only a suggested package of BiocGenerics, I think this causes install.packages() on DelayedArray to fail picking up RUnit. This, in turn, causes automated reverse package dependency checks on DelayedArray to fail with:

     ERROR
    Running the tests in ‘tests/run_unitTests.R’ failed.
    Last 13 lines of output:

      The following objects are masked from 'package:matrixStats':

          colMaxs, colMins, colRanges, rowMaxs, rowMins, rowRanges

      The following objects are masked from 'package:base':

          aperm, apply

      [1] TRUE
      > DelayedArray:::.test()
      Error in library("RUnit", quietly = TRUE) : 
        there is no package called 'RUnit'
      Calls: <Anonymous> -> <Anonymous> -> library
      Execution halted

I observe this when running revdep checks on matrixStats. Adding RUnit to Suggests should fix this.

hpages commented 6 years ago

Thanks @HenrikBengtsson . This is corrected in DelayedArray 0.7.21 (BioC devel) and 0.6.2 (BioC release).

HenrikBengtsson commented 6 years ago

Confirming that those are live now. Thanks.