drop() doesn't preserve dimnames in release?

Bioconductor / DelayedArray

A unified framework for working transparently with on-disk and in-memory array-like datasets

https://bioconductor.org/packages/DelayedArray

24 stars 9 forks source link

drop() doesn't preserve dimnames in release? #86

Closed LTLA closed 3 years ago

LTLA commented 3 years ago

Seems like drop() on DA's doesn't preserve dimnames in BioC-release:

library(DelayedArray)
x <- DelayedArray(cbind(A=1:10, B=2:11))
x[1,]
## [1] 1 2

On BioC-devel, it does the right thing:

library(DelayedArray)
x <- DelayedArray(cbind(A=1:10, B=2:11))
x[1,]
## A B
## 1 2

Seems like a simple patch across to BioC-release would suffice.

hpages commented 3 years ago

Ah right, forgot to backport commit 8623979c85fff8be8721845981ba1673d6b8ff83 (discussed in issue #78) to the RELEASE_3_12 branch. Should be done now (in DelayedArray 0.16.1).