search

Bioconductor / GenomicDataCommons

Provide R access to the NCI Genomic Data Commons portal.
http://bioconductor.github.io/GenomicDataCommons/
83 stars 23 forks source link

magrittr in Depends field #41

Closed LiNk-NY closed 7 years ago

LiNk-NY commented 7 years ago

Hi Sean @seandavi, On second thought, it seems like it would be more convenient to keep magrittr in the Depends:. This would avoid all of the library calls in the examples. Usually, the Depends: field is used if the current package extends the that package.

Taking a quick look at Organism.dplyr, @mtmorgan puts dplyr in the Depends field: https://github.com/Bioconductor/Organism.dplyr/blob/master/DESCRIPTION#L16

@mtmorgan Thoughts?

Also, the tag should be @importFrom magrittr "%>%", at least that worked for me.

Thanks, Marcel

LiNk-NY commented 7 years ago

I can run a pull request with the changes: see #42

mtmorgan commented 7 years ago

Seems appropriate to have packages in the Depends: field that are needed for the end user to make effective use of the package. I think magrittr fits this bill.