Bioconductor / GenomicDataCommons

Provide R access to the NCI Genomic Data Commons portal.
http://bioconductor.github.io/GenomicDataCommons/
83 stars 23 forks source link

gdc_rnaseq.R: available_rnaseq_workflows() returns NULL #61

Open lyijin opened 6 years ago

lyijin commented 6 years ago

hi there,

i think there's a bug with the available_rnaseq_workflows() function--and i think i know what the problem is.

possible_workflows = files() %>% GenomicDataCommons::filter(~data_type == 
    "Gene Expression Quantification" & data_type == "Gene Expression Quantification") %>% 
    facet("analysis.workflow_type") %>% aggregations()

produces

> possible_workflows
$`analysis.workflow_type`
              key doc_count
1  HTSeq - Counts     11571
2    HTSeq - FPKM     11571
3 HTSeq - FPKM-UQ     11571

which means that the return statement in the function

return(possible_workflows[["key"]])

returns NULL because one has to refer to $analysis.workflow_type.

either of these replacements would work, and produce the intended return values!

> possible_workflows[['analysis.workflow_type']][['key']]
[1] "HTSeq - Counts"  "HTSeq - FPKM"    "HTSeq - FPKM-UQ"
> possible_workflows[[1]][['key']]
[1] "HTSeq - Counts"  "HTSeq - FPKM"    "HTSeq - FPKM-UQ"