search

Bioconductor / GenomicFiles

Distributed computing by file or by range
https://bioconductor.org/packages/GenomicFiles
2 stars 6 forks source link

added vcfFields-VcfStack-method #1

Closed Liubuntu closed 6 years ago

Liubuntu commented 6 years ago

In accordance with the newly added generic and method of vcfFields in VariantAnnotation (see here), Here I am adding the same method for VcfStack objects.

Updates includes adding method, documentation, runnable example, NEWS (new feature), NAMESPACE (export), and DESCRIPTION (version bump, Imports: VariantAnnotation >= 1.27.5).

Could pass R CMD check successfully.

Liubuntu commented 6 years ago

Hi @mtmorgan ,

Would you like to look at this pull request so that I can make the modifications inside VCFArray and possibly submit it? Basically that's the only thing needed before a submission. Thanks!

Best, Qian

mtmorgan commented 6 years ago

Looks like the VariantAnnotation commit https://github.com/Bioconductor/VariantAnnotation/commit/b36cfa524ca13135c9f00bafb541be75ed391707 was pushed to github, but not to git.bioconductor.org. @vobencha @Liubuntu I've synced the two repositories now.

Liubuntu commented 6 years ago

That will be great! Thanks.

On Sat, Oct 13, 2018, 11:14 AM Martin Morgan notifications@github.com wrote:

Looks like the VariantAnnotation commit Bioconductor/VariantAnnotation@ b36cfa5 https://github.com/Bioconductor/VariantAnnotation/commit/b36cfa524ca13135c9f00bafb541be75ed391707 was pushed to github, but not to git.bioconductor.org. @vobencha https://github.com/vobencha @Liubuntu https://github.com/Liubuntu I've synced the two repositories now.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Bioconductor/GenomicFiles/pull/1#issuecomment-429549814, or mute the thread https://github.com/notifications/unsubscribe-auth/AMGKyVaebn9-boBa2NkDMMYyluY0REXKks5ukgNPgaJpZM4WVutg .

mtmorgan commented 6 years ago

Closed via 49f9c5cf116e0d58fcd01975b095aba9882b50c8

vobencha commented 6 years ago

Thanks @mtmorgan .