search

Bioconductor / GenomicRanges

Representation and manipulation of genomic intervals
https://bioconductor.org/packages/GenomicRanges
41 stars 17 forks source link

replace KEGG.db usage with KEGGREST and fix a makeGRangesFromDataFrame.Rd example #50

Closed vjcitn closed 3 years ago

vjcitn commented 3 years ago

passes check cleanly on r79595

hpages commented 3 years ago

Hi Vince,

Looks good thanks. Do you think you can undo your changes to makeGRangesFromDataFrame.Rd example? The example is broken because rtracklayer is currently broken (see here) but it should work again as soon as rtracklayer gets repaired, which hopefully will happen soon. In the mean time I think we should just leave the makeGRangesFromDataFrame.Rd example as it is.

Also do you think you can use <- instead of = for the new code in GenomicRangesHOWTOs.Rnw? ;-)

Thx!

vjcitn commented 3 years ago

as requested, <- used and failing example restored (manually)

hpages commented 3 years ago

@vjcitn: Thanks Vince!