search

Bioconductor / GenomicRanges

Representation and manipulation of genomic intervals
https://bioconductor.org/packages/GenomicRanges
41 stars 17 forks source link

Unit tests succeed but for the wrong reason #8

Closed mtmorgan closed 4 years ago

mtmorgan commented 6 years ago

The test here https://github.com/Bioconductor/GenomicRanges/blob/master/inst/unitTests/test_GRangesList-class.R#L103 and immediately following fails because it is trying to assign to an object that does not exist outside the assignment

> start(GRangesList()) = NULL
Error in start(GRangesList()) = NULL : 
  invalid (NULL) left side of assignment

Probably the intention was

> grl = GRangesList()
> start(grl) = NULL
Error in `start<-`(`*tmp*`, value = NULL) : 
  replacement 'value' is not an IntegerList with the same elementNROWS as 'x'
lawremi commented 6 years ago

What's also weird (and irrelevant) is that somehow the <- in the code were converted into = in your quote of it.

hpages commented 4 years ago

Can't believe we had this bug since the very beginning of GenomicRanges. Fixed in beebde3790d3558c596f89bbdf0d816bfc2ca661