Refactor of reads methods.

Bioconductor / GoogleGenomics

[DEPRECATED] An R package for Google Genomics API queries.

Apache License 2.0

44 stars 23 forks source link

Refactor of reads methods. #16

Closed deflaux closed 10 years ago

deflaux commented 10 years ago

Similar to the refactor for variants, to allow arbitrary converters.

pgrosu commented 10 years ago

Looks great Nicole! Thank you for the added flexibility.

siddharthab commented 10 years ago

Good to go. Merge at will after resolving what you think needs to be resolved.

deflaux commented 10 years ago

Thanks for the review @siddharthab

pgrosu commented 10 years ago

Nicole, I always envisions the openness of the java api client for the R client. So, yes definitely! You won't regret it :)

pgrosu commented 10 years ago

Sid/Nicole, just use the .store value as the Java API client and spark-examples. It will simplify things. Using the another one like .Rprofile will lead to too many different configurations. Actually I just remembered that I posted in the following issue:

https://github.com/googlegenomics/api-client-r/issues/10