search

Bioconductor / MatrixGenerics

S4 Generic Summary Statistic Functions that Operate on Matrix-Like Objects
https://bioconductor.org/packages/MatrixGenerics
12 stars 1 forks source link

Why ... for every default function? #10

Closed const-ae closed 4 years ago

const-ae commented 4 years ago

If see it correctly, in https://github.com/Bioconductor/MatrixGenerics/pull/8/commits/81aa9cd4b298f489fe2557107f988e6ea5972f27 you added ... back to every function, right?

If matrixStats explicitly states in the documentation that the ... are not used within a function, I am not sure what is the advantage of having it in the method signature?

PeteHaitch commented 4 years ago

It seemed better that foo,matrix-method defined in MatrixGenerics exactly matched matrixStats::foo() but I could be persuaded otherwise. I kept them there in case Henrik starts using ... in matrixStats::foo(). FWIW there are some matrixStats::foo() that do use ..., e.g., matrixStats::colQuantiles().

const-ae commented 4 years ago

It seemed better that foo,matrix-method defined in MatrixGenerics exactly matched matrixStats::foo() but I could be persuaded otherwise.

Oh, I see you also added some tests that test if the signatures are equal. That is a good idea.

I kept them there in case Henrik starts using ... in matrixStats::foo().

Yeah, okay. I guess that makes sense. I will close this issue then :)