search

Bioconductor / MatrixGenerics

S4 Generic Summary Statistic Functions that Operate on Matrix-Like Objects
https://bioconductor.org/packages/MatrixGenerics
12 stars 1 forks source link

Add drop and type to generic signature of [row|col]Quantiles #14

Closed const-ae closed 3 years ago

const-ae commented 3 years ago

After some discussion with @LTLA in https://github.com/const-ae/sparseMatrixStats/issues/7, I decided that it is probably a good idea to include drop and type (which sparseMatrixStats now fully supports) in the generic method signature.

What do you think?

hpages commented 3 years ago

Well, as a general rule, if matrixStats::rowQuantiles has the arguments, the generic should probably have them too.

hpages commented 3 years ago

I'm talking about arguments that make sense for matrix-like objects in general. Not all arguments fall in that category but it seems that drop and type do.

PeteHaitch commented 3 years ago

Where do we sit on this?

const-ae commented 3 years ago

I rebased the PR on the current master to resolve the merge conflict. I think we can merge this now :)

PeteHaitch commented 3 years ago

Thanks, @const-ae!