Remove scalar center arguments in test-api_compatibility

Bioconductor / MatrixGenerics

S4 Generic Summary Statistic Functions that Operate on Matrix-Like Objects

https://bioconductor.org/packages/MatrixGenerics

12 stars 1 forks source link

Remove scalar center arguments in test-api_compatibility #18

Closed const-ae closed 4 years ago

const-ae commented 4 years ago

This beginns to address #17 and is in response to https://github.com/HenrikBengtsson/matrixStats/issues/183
The test still fails for colWeightedMads, but I think this is should be fixed in matrixStats, because right now the handling of center between colWeightedMads and colMads is inconsistent

PeteHaitch commented 4 years ago

Is this still WIP @const-ae ?

const-ae commented 4 years ago

Well, I still wait for https://github.com/HenrikBengtsson/matrixStats/issues/183#issuecomment-706306095 so that the tests for colWeightedMads don't fail anymore.

If you think it is better to not wait any longer, I can adapt the tests, so that they pass for now and revert the changes, when Henrik fixes colWeightedMads in matrixStats.

PeteHaitch commented 4 years ago

With the upcoming BioC release I think we may need to use a temporary work around until it's changed upstream.

const-ae commented 4 years ago

Okay, I added a special case for [col|row]WeightedMads in the tests, so that the unit tests now complete successfully :) This PR should be good to merge now.

PeteHaitch commented 4 years ago

Thanks, @const-ae. I'll keep an eye on https://github.com/HenrikBengtsson/matrixStats/issues/183 and revert once a new version of matrixStats is release (and accordingly bump the version of matrixStats required).

const-ae commented 4 years ago

Thank you very much for taking care :)