search

Bioconductor / MatrixGenerics

S4 Generic Summary Statistic Functions that Operate on Matrix-Like Objects
https://bioconductor.org/packages/MatrixGenerics
12 stars 1 forks source link

Apply matrixStats 1.0.0 breaking change for 'useNames' default [PR against devel] #33

Closed hpages closed 1 year ago

hpages commented 1 year ago

All generic functions and methods defined in MatrixGenerics now set the useNames argument to TRUE instead of NA by default, for consistency with matrixStats 1.0.0. See https://github.com/Bioconductor/MatrixGenerics/issues/31 for a discussion of this change.

PeteHaitch commented 1 year ago

Alright, I've got PR for devel branch of DelayedMatrixStats ready to go (https://github.com/PeteHaitch/DelayedMatrixStats/pull/96).

PeteHaitch commented 1 year ago

@hpages This PR is good to go from my end.

PeteHaitch commented 1 year ago

@hpages gentle nudge - shall we merge?

PeteHaitch commented 1 year ago

Merged and pushed to Bioconductor's git server.

hpages commented 1 year ago

Thanks Pete. Sorry for the slow response, I'm travelling and with only intermittent access to the internet.

PeteHaitch commented 1 year ago

All good, I figured you were probably on holiday or otherwise busy :)