Closed hpages closed 2 years ago
HI @hpages Thanks for all the changes! I'll go through the package to refresh my memories, and see if anything else (except for the rownames
) needed to be added (I've had a reimplement
branch earlier so maybe adding more changes based on that).
See issue #4 for a discussion of this change.
Starting with S4Vectors 0.33.3, DataFrame is a virtual class with no
listData
,nrows
, orrownames
slot, making it possible for SQLDataFrame to become a concrete subclass of DataFrame.The ultimate goal is to be able to use an SQLDataFrame object in any place where a DataFrame derivative is expected. For example inside a Vector derivative to store the metadata columns, or inside a SummarizedExperiment derivative to store the colData. With SQLDataFrame 1.9.1, this is now possible but with a big gotcha:
Looks good... BUT:
Basically, this fails because SQLDataFrame objects don't support
rownames<-
:Supporting
rownames<-
would go a long way in making SQLDataFrame objects drop-in replacements for DFrame objects.H.