search

Bioconductor / bioc_docker

[DEPRECATED] Docker containers for Bioconductor
https://github.com/bioconductor/bioconductor_docker
Artistic License 2.0
49 stars 27 forks source link

install libpng-dev #66

Closed lwaldron closed 5 years ago

lwaldron commented 5 years ago

https://github.com/Bioconductor/bioc_docker/blob/072c4e4a412a0cdad5be991a492f4869fe187a48/src/core/Dockerfile.in#L8

Not sure if that's the right place to do it, but can we add libpng-dev to the Dockerfile files? It's a lightweight addition that some popular package depend on. E.g.:

RUN apt-get install -y libpng-dev

lshep commented 5 years ago

For the record: This was not in the original list of system dependencies because it is not needed in the list of package we provide by default. technically it should not be added for this reason with the idea that if you wanted to add on packages, you would add them on your own including any system dependencies for those additional packages - keeping the base images with only necessities. We will rethink this policy and request like this will be decided on a 'case by case' basis.

In this case we will add this dependency. I'll look at making the change sometime this week.

lshep commented 5 years ago

These should now be in the devel and release base/core

lwaldron commented 5 years ago

Thanks @lshep!