Bioconductor / bioconductor_docker

Docker Containers for Bioconductor
https://bioconductor.org/help/docker/
Artistic License 2.0
73 stars 31 forks source link

Add BIOCONDUCTOR_USE_CONTAINER_REPOSITORY=FALSE before installations #62

Closed almahmoud closed 2 years ago

almahmoud commented 2 years ago

Fixes https://github.com/Bioconductor/bioconductor_docker/issues/59.

I went a bit in a circle trying to figure this one out, as I rebuilt binaries with new containers, but the binary for stringi seemed to not get updated. The issue was due to the fact that the stringi is a dependent package of one of the packages that we install beforehand in the docker image. After the change a few months ago to make BiocManager::install use binary repo (like previously only AnVIL::install would, the packages installed during the container building would use the binary repo, which prevented it from updating to the new container. The redis container building binaries inheriting from this, the old version of the library persisted.

This change ensures that the libraries built in the docker image are built from source every time, ensuring that rebuilding of the same release version does not keep stale libraries.

Will push forward this to devel after merging in 3_16