search

Bioconductor / packagebuilder

5 stars 7 forks source link

Fault tolerance #18

Closed b-long closed 8 years ago

b-long commented 8 years ago

_Do not merge yet_ (This branch represents a work-in-progerss).

As I'm working to make the SPB function without a particular node, I wanted to document a development workflow. For rendered version of the main document, see here: https://github.com/b-long/packagebuilder/blob/feature/fault-tolerance/documentation/Developing.md

b-long commented 8 years ago

NB: I'm using this package to test changes: https://github.com/Bioconductor/packagebuilder/issues/15#issuecomment-159715786

b-long commented 8 years ago

FYI @mtmorgan , I'm applying your commits atop this branch.

b-long commented 8 years ago

@dtenenba Mind taking a look at this branch? Morelia builds should now be disabled, and I think it's worth it to consider merging to master & deploying to production.

b-long commented 8 years ago

Note to anyone reviewing this PR, I'm currently depending on a change to the BBS (already merged to Bioconductor:feature/migrate_back_to_hutch). Make sure your local copy of the BBS has this change.

The code in BBS previously did something like : 

key = hostname # Hostname of the machine executing the SPB 
configuration = dictionary[key] # Get configuration specific to that host

Since we don't want every developer to have to modify either (1) their hostname or (2) the hard-coded configuration, the code referenced above is a workaround.

b-long commented 8 years ago

@dtenenba Any objection to giving this a whirl in production tomorrow morning?

dtenenba commented 8 years ago

@b-long No objection.